summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2020-11-19 15:13:53 +0100
committerThomas Haller <thaller@redhat.com>2020-11-20 16:59:56 +0100
commit190eeb5e9f66005b20812995fba752e6877d0b04 (patch)
tree5c17cefc76a35f87c00fe66d441c322899d40006
parent34dd7d73bbd6ee680341942151a1b69c9d5d8c88 (diff)
downloadNetworkManager-190eeb5e9f66005b20812995fba752e6877d0b04.tar.gz
dns: cleanup allocation of NMDnsConfigData and NMDnsIPConfigData
-rw-r--r--src/dns/nm-dns-manager.c24
1 files changed, 14 insertions, 10 deletions
diff --git a/src/dns/nm-dns-manager.c b/src/dns/nm-dns-manager.c
index 0ea5f6f6a9..eafdba9e9f 100644
--- a/src/dns/nm-dns-manager.c
+++ b/src/dns/nm-dns-manager.c
@@ -233,10 +233,12 @@ _ip_config_data_new(NMDnsConfigData *data, NMIPConfig *ip_config, NMDnsIPConfigT
nm_assert(NM_IS_IP_CONFIG(ip_config));
nm_assert(ip_config_type != NM_DNS_IP_CONFIG_TYPE_REMOVED);
- ip_data = g_slice_new0(NMDnsIPConfigData);
- ip_data->data = data;
- ip_data->ip_config = g_object_ref(ip_config);
- ip_data->ip_config_type = ip_config_type;
+ ip_data = g_slice_new(NMDnsIPConfigData);
+ *ip_data = (NMDnsIPConfigData){
+ .data = data,
+ .ip_config = g_object_ref(ip_config),
+ .ip_config_type = ip_config_type,
+ };
c_list_link_tail(&data->data_lst_head, &ip_data->data_lst);
c_list_link_tail(&NM_DNS_MANAGER_GET_PRIVATE(data->self)->ip_config_lst_head,
&ip_data->ip_config_lst);
@@ -267,7 +269,7 @@ _ip_config_data_free(NMDnsIPConfigData *ip_data)
ip_data);
g_object_unref(ip_data->ip_config);
- g_slice_free(NMDnsIPConfigData, ip_data);
+ nm_g_slice_free(ip_data);
}
static NMDnsIPConfigData *
@@ -292,7 +294,7 @@ _config_data_free(NMDnsConfigData *data)
_ASSERT_config_data(data);
nm_assert(c_list_is_empty(&data->data_lst_head));
- g_slice_free(NMDnsConfigData, data);
+ nm_g_slice_free(data);
}
static int
@@ -1740,10 +1742,12 @@ nm_dns_manager_set_ip_config(NMDnsManager * self,
}
if (!data) {
- data = g_slice_new0(NMDnsConfigData);
- data->ifindex = ifindex;
- data->self = self;
- c_list_init(&data->data_lst_head);
+ data = g_slice_new(NMDnsConfigData);
+ *data = (NMDnsConfigData){
+ .ifindex = ifindex,
+ .self = self,
+ .data_lst_head = C_LIST_INIT(data->data_lst_head),
+ };
_ASSERT_config_data(data);
g_hash_table_insert(priv->configs, GINT_TO_POINTER(ifindex), data);
}