summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiří Klimeš <jklimes@redhat.com>2015-05-29 08:09:53 +0200
committerJiří Klimeš <jklimes@redhat.com>2015-05-29 08:09:53 +0200
commit242fe0bfb0bf5e8f772506012ebdad4d129d0a5c (patch)
tree9bc7604643d619bc156a57e225df9eeadfaf6fa8
parentc47c06470a0de70f5495d8919fd7f6b5369a5070 (diff)
parent91a5f4ceb928b95a92d43bbd51c3f9f463a4d97b (diff)
downloadNetworkManager-242fe0bfb0bf5e8f772506012ebdad4d129d0a5c.tar.gz
merge: increase 'max_replies_per_connection' limit in D-Bus configuration
The limit seems to be too low and causes problems in libnm-glib. We increase the limit and warn in libnm-glib if it was exceeded.
-rw-r--r--libnm-glib/nm-remote-settings.c9
-rw-r--r--src/org.freedesktop.NetworkManager.conf2
2 files changed, 11 insertions, 0 deletions
diff --git a/libnm-glib/nm-remote-settings.c b/libnm-glib/nm-remote-settings.c
index d5f4ca67f0..ba0aa47be6 100644
--- a/libnm-glib/nm-remote-settings.c
+++ b/libnm-glib/nm-remote-settings.c
@@ -469,6 +469,7 @@ connection_inited (GObject *source, GAsyncResult *result, gpointer user_data)
AddConnectionInfo *addinfo;
const char *path;
GError *error = NULL, *local;
+ static gboolean print_once = TRUE;
path = nm_connection_get_path (NM_CONNECTION (remote));
addinfo = add_connection_info_find (self, remote);
@@ -504,6 +505,14 @@ connection_inited (GObject *source, GAsyncResult *result, gpointer user_data)
if (!dbus_g_error_has_name (error, "org.freedesktop.NetworkManager.Settings.PermissionDenied"))
g_hash_table_remove (priv->pending, path);
+ if (print_once && error->code == DBUS_GERROR_LIMITS_EXCEEDED) {
+ g_printerr ("Warning: libnm-glib:%s(): a D-Bus limit exceeded: %s. The application might not work properly.\n"
+ "Consider increasing max_replies_per_connection limit in /etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf "
+ "like <limit name=\"max_replies_per_connection\">2048</limit>",
+ __func__, error->message);
+ print_once = FALSE;
+ }
+
g_error_free (error);
}
diff --git a/src/org.freedesktop.NetworkManager.conf b/src/org.freedesktop.NetworkManager.conf
index fafa8f5bb5..dd03a70cfd 100644
--- a/src/org.freedesktop.NetworkManager.conf
+++ b/src/org.freedesktop.NetworkManager.conf
@@ -121,5 +121,7 @@
<deny send_interface="org.freedesktop.NetworkManager.VPN.Plugin"/>
<deny send_interface="org.freedesktop.NetworkManager.PPP"/>
</policy>
+
+ <limit name="max_replies_per_connection">1024</limit>
</busconfig>