diff options
| author | Sibo Dong <sibo.dong@outlook.com> | 2021-06-08 03:33:58 -0400 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2021-06-08 11:37:03 +0200 |
| commit | 5c1181c6f3b2f56c18c1333c55e75e554b00ae2d (patch) | |
| tree | a6b44fae146b83d90bfb5b91f2a0ecfb1ad1d582 | |
| parent | 9662f249950b42ec987d930604024c36ee00f3b2 (diff) | |
| download | NetworkManager-5c1181c6f3b2f56c18c1333c55e75e554b00ae2d.tar.gz | |
bash-completion: localize the prev variable
The prev variable is not localzed in the nmcli Bash completion script,
which calls _init_completion.
Even though prev does not appear in the completion script, it should
still be localized. This variable may otherwise appear in the user's
environment and clobber a user-defined variable of the same name, which
is bad.
Localize the prev variable.
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/741
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/882
| -rw-r--r-- | src/nmcli/nmcli-completion | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nmcli/nmcli-completion b/src/nmcli/nmcli-completion index 45dfe89c34..83ec1e3cb8 100644 --- a/src/nmcli/nmcli-completion +++ b/src/nmcli/nmcli-completion @@ -27,7 +27,7 @@ _nmcli_array_delete_at() _nmcli() { - local cur words cword i output + local cur prev words cword i output _init_completion || return # we don't care about any arguments after the current cursor position |