diff options
| author | Thomas Haller <thaller@redhat.com> | 2021-08-05 13:33:27 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2021-08-05 15:52:01 +0200 |
| commit | 8c7ab709155fda367ccc012a2a7213526138469a (patch) | |
| tree | 654f2987a41a2e85cf209c6bd9aad09ccf76c72a | |
| parent | 2cbaaed82077b4c63f214cd8e09204b8ed20b0c8 (diff) | |
| download | NetworkManager-8c7ab709155fda367ccc012a2a7213526138469a.tar.gz | |
dhcp: don't log plain pointer values for debugging
We avoid logging plain pointers. The logfile should not contain pointers
as that theoretically can defeat ASLR.
| -rw-r--r-- | src/core/dhcp/nm-dhcp-nettools.c | 4 | ||||
| -rw-r--r-- | src/core/dhcp/nm-dhcp-systemd.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/core/dhcp/nm-dhcp-nettools.c b/src/core/dhcp/nm-dhcp-nettools.c index 6e8c69c71f..56b485dd25 100644 --- a/src/core/dhcp/nm-dhcp-nettools.c +++ b/src/core/dhcp/nm-dhcp-nettools.c @@ -1219,7 +1219,7 @@ ip4_start(NMDhcpClient *client, const char *last_ip4_address, GError **error) return FALSE; } - _LOGT("dhcp-client4: start %p", (gpointer) priv->client); + _LOGT("dhcp-client4: start " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(priv->client)); nm_dhcp_client_start_timeout(client); return TRUE; @@ -1233,7 +1233,7 @@ stop(NMDhcpClient *client, gboolean release) NM_DHCP_CLIENT_CLASS(nm_dhcp_nettools_parent_class)->stop(client, release); - _LOGT("dhcp-client4: stop %p", (gpointer) priv->client); + _LOGT("dhcp-client4: stop " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(priv->client)); priv->probe = n_dhcp4_client_probe_free(priv->probe); } diff --git a/src/core/dhcp/nm-dhcp-systemd.c b/src/core/dhcp/nm-dhcp-systemd.c index 4bb58ee354..af1d2238b4 100644 --- a/src/core/dhcp/nm-dhcp-systemd.c +++ b/src/core/dhcp/nm-dhcp-systemd.c @@ -592,7 +592,7 @@ ip4_start(NMDhcpClient *client, const char *last_ip4_address, GError **error) return FALSE; } - _LOGT("dhcp-client4: set %p", sd_client); + _LOGT("dhcp-client4: set " NM_HASH_OBFUSCATE_PTR_FMT, NM_HASH_OBFUSCATE_PTR(sd_client)); r = sd_dhcp_client_attach_event(sd_client, NULL, 0); if (r < 0) { |