summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-10-19 16:33:05 +0200
committerThomas Haller <thaller@redhat.com>2019-10-27 14:30:51 +0100
commit1cf4de20ebb7d8762565379bdb0c78ab6c086300 (patch)
tree385b859925ae94099f5b834dffe63905d67f9325
parent6a0062e4ff57167fdbdfa014ec1be6d2cb2d347e (diff)
downloadNetworkManager-1cf4de20ebb7d8762565379bdb0c78ab6c086300.tar.gz
libnm: add comment about not-implement property NMDeviceVxlan:carrier
The server does not expose this property on D-Bus. It's always FALSE. Add a comment about that.
-rw-r--r--libnm/nm-device-vxlan.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/libnm/nm-device-vxlan.c b/libnm/nm-device-vxlan.c
index 006d3a12cb..f63e1bdf57 100644
--- a/libnm/nm-device-vxlan.c
+++ b/libnm/nm-device-vxlan.c
@@ -38,7 +38,6 @@ NM_GOBJECT_PROPERTIES_DEFINE_BASE (
typedef struct {
NMDevice *parent;
char *hw_address;
- gboolean carrier;
guint id;
char *group;
char *local;
@@ -99,13 +98,16 @@ nm_device_vxlan_get_hw_address (NMDeviceVxlan *device)
* Returns: %TRUE if the device has carrier.
*
* Since: 1.2
+ *
+ * This property is not implemented yet, and the function always returns
+ * FALSE.
**/
gboolean
nm_device_vxlan_get_carrier (NMDeviceVxlan *device)
{
g_return_val_if_fail (NM_IS_DEVICE_VXLAN (device), FALSE);
- return NM_DEVICE_VXLAN_GET_PRIVATE (device)->carrier;
+ return FALSE;
}
/**
@@ -415,7 +417,6 @@ init_dbus (NMObject *object)
NMDeviceVxlanPrivate *priv = NM_DEVICE_VXLAN_GET_PRIVATE (object);
const NMPropertiesInfo property_info[] = {
{ NM_DEVICE_VXLAN_HW_ADDRESS, &priv->hw_address },
- { NM_DEVICE_VXLAN_CARRIER, &priv->carrier },
{ NM_DEVICE_VXLAN_PARENT, &priv->parent, NULL, NM_TYPE_DEVICE },
{ NM_DEVICE_VXLAN_ID, &priv->id },
{ NM_DEVICE_VXLAN_GROUP, &priv->group },
@@ -559,6 +560,8 @@ nm_device_vxlan_class_init (NMDeviceVxlanClass *vxlan_class)
* Whether the device has carrier.
*
* Since: 1.2
+ *
+ * This property is not implemented yet, and the property is always FALSE.
**/
obj_properties[PROP_CARRIER] =
g_param_spec_boolean (NM_DEVICE_VXLAN_CARRIER, "", "",