summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTony Espy <espy@canonical.com>2021-03-05 15:09:30 +0530
committerThomas Haller <thaller@redhat.com>2021-03-15 13:32:47 +0100
commite4941696befcf758fda3b9328dce8f2d19132647 (patch)
tree6e096071916dee6f759a5c2f47bfd1f88985f6f1
parentc49fe910d643739d5c979623673bb3b415ba44bf (diff)
downloadNetworkManager-e4941696befcf758fda3b9328dce8f2d19132647.tar.gz
wwan/modem: do not mark connection as failed when connection drops
If the modem is connected, and registrations drops, and then is restored, the connection isn't re-activated. The fix was simply to change modem_state_cb to not return after setting the state to failed, which allows nm_device_queue_recheck_available to be called, which queues a state transition to UNAVAILABLE.
-rw-r--r--src/core/devices/wwan/nm-device-modem.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/core/devices/wwan/nm-device-modem.c b/src/core/devices/wwan/nm-device-modem.c
index 87d4023817..405ced64a1 100644
--- a/src/core/devices/wwan/nm-device-modem.c
+++ b/src/core/devices/wwan/nm-device-modem.c
@@ -357,7 +357,6 @@ modem_state_cb(NMModem *modem, int new_state_i, int old_state_i, gpointer user_d
nm_device_state_changed(device,
NM_DEVICE_STATE_FAILED,
NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER);
- return;
}
if (new_state > NM_MODEM_STATE_LOCKED && old_state == NM_MODEM_STATE_LOCKED) {