diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-08-01 07:50:53 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-08-09 07:51:59 +0200 |
| commit | 2976dbb43b100470d60074eeb6a33187ceca3376 (patch) | |
| tree | 00e723d969329df7c2e114f68b601a532c6fd3c2 | |
| parent | b32292003ea09cb23093775f0dfb69eec137a2d5 (diff) | |
| download | NetworkManager-2976dbb43b100470d60074eeb6a33187ceca3376.tar.gz | |
cli: don't require "ifname" when adding connectionth/nmcli-not-require-ifname
$ nmcli connection add type ethernet con-name t autoconnect no
Error: ifname argument is required.
This reverts commit a91eafdf95bc ('cli: 'con add': make ifname mandatory
(except bond,bridge,vlan) (bgo #698113)'). Apparently this argument was
required to avoid confusion (unexpected behavior). But I don't agree
that is an issue, it's just annoying. Often you really have just one ethernet
or Wi-Fi device, so this does not seem helpful.
| -rw-r--r-- | clients/common/nm-meta-setting-desc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index 86682e2e76..875ed93979 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -5015,7 +5015,6 @@ static const NMMetaPropertyInfo *const property_infos_CONNECTION[] = { PROPERTY_INFO_WITH_DESC (NM_SETTING_CONNECTION_INTERFACE_NAME, .is_cli_option = TRUE, .property_alias = "ifname", - .inf_flags = NM_META_PROPERTY_INF_FLAG_REQD, .prompt = NM_META_TEXT_PROMPT_IFNAME, .property_type = DEFINE_PROPERTY_TYPE ( .get_fcn = _get_fcn_gobject, |