diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-02-21 08:57:41 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-02-22 09:58:09 +0100 |
| commit | f7df8fda1a880a0922e08302d5666adf2be4ddfb (patch) | |
| tree | 13e3c3e1091fb4b2518d2bd12d7f21a1e757df7e | |
| parent | 82e31b2816149c8dc4cdf5bb50bb1683f3b93ecf (diff) | |
| download | NetworkManager-f7df8fda1a880a0922e08302d5666adf2be4ddfb.tar.gz | |
platform/netlink: assert for valid policy for string attribute in validate_nla
The policy for strings must indicate a minlen of at least 1.
Everything else is a bug, because the policy contains invalid
data -- and is determined at compile-time.
| -rw-r--r-- | src/platform/nm-netlink.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/platform/nm-netlink.c b/src/platform/nm-netlink.c index d367df304d..2d4f5ea549 100644 --- a/src/platform/nm-netlink.c +++ b/src/platform/nm-netlink.c @@ -586,7 +586,11 @@ validate_nla (const struct nlattr *nla, int maxtype, return -NME_UNSPEC; if (pt->type == NLA_STRING) { - const char *data = nla_data (nla); + const char *data; + + nm_assert (minlen > 0); + + data = nla_data (nla); if (data[nla_len (nla) - 1] != '\0') return -NME_UNSPEC; } |