diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-02-21 08:57:41 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-02-21 21:02:51 +0100 |
| commit | af29324d9ccc5862d773aff4cb882f2fd166b88c (patch) | |
| tree | 8f515e85cca1839b1fe6d207895428c2c8167b87 | |
| parent | 8a8343c297307288b81d9f411389a2e1dcca47a8 (diff) | |
| download | NetworkManager-af29324d9ccc5862d773aff4cb882f2fd166b88c.tar.gz | |
platform/netlink: assert for valid policy for string attribute in validate_nla
The policy for strings must indicate a minlen of at least 1.
Everything else is a bug, because the policy contains invalid
data -- and is determined at compile-time.
| -rw-r--r-- | src/platform/nm-netlink.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/platform/nm-netlink.c b/src/platform/nm-netlink.c index d367df304d..2d4f5ea549 100644 --- a/src/platform/nm-netlink.c +++ b/src/platform/nm-netlink.c @@ -586,7 +586,11 @@ validate_nla (const struct nlattr *nla, int maxtype, return -NME_UNSPEC; if (pt->type == NLA_STRING) { - const char *data = nla_data (nla); + const char *data; + + nm_assert (minlen > 0); + + data = nla_data (nla); if (data[nla_len (nla) - 1] != '\0') return -NME_UNSPEC; } |