summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-10-03 11:22:48 +0200
committerThomas Haller <thaller@redhat.com>2019-12-05 12:36:13 +0100
commit321a323df4ad5340eff843ceae1ffee2e8930066 (patch)
treefb9c93b8385cfb84b32dfa2aa49372dbf76f8b7e
parent8fbf67d13826f73be75fa301d8bd27f4dba8b52c (diff)
downloadNetworkManager-321a323df4ad5340eff843ceae1ffee2e8930066.tar.gz
initrd: fix use-after-free for variable "s_gateway" in nmi_dt_reader_parse()
-rw-r--r--src/initrd/nmi-dt-reader.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/initrd/nmi-dt-reader.c b/src/initrd/nmi-dt-reader.c
index d2e571d7a8..140ef12578 100644
--- a/src/initrd/nmi-dt-reader.c
+++ b/src/initrd/nmi-dt-reader.c
@@ -329,8 +329,6 @@ nmi_dt_reader_parse (const char *sysfs_dir)
if (netmask)
nm_ip_address_unref (netmask);
- if (gateway)
- nm_ip_address_unref (gateway);
}
if (!ipaddr) {
@@ -377,6 +375,8 @@ nmi_dt_reader_parse (const char *sysfs_dir)
if (ipaddr)
nm_ip_address_unref (ipaddr);
+ if (gateway)
+ nm_ip_address_unref (gateway);
if (duplex || speed || hwaddr || local_hwaddr) {
s_wired = nm_setting_wired_new ();