summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-12-09 09:51:55 +0100
committerThomas Haller <thaller@redhat.com>2019-12-09 09:54:17 +0100
commite0569ee575a40f401b2cca1acbd9cddd5fa567cd (patch)
tree385481e70fa4ce1771ac2213d0d92febd8883852
parenteb642fecdf4f57d4e8673065063cf429e986014a (diff)
downloadNetworkManager-e0569ee575a40f401b2cca1acbd9cddd5fa567cd.tar.gz
settings: assert that we don't leak error variable in impl_settings_load_connections()
-rw-r--r--src/settings/nm-settings.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/settings/nm-settings.c b/src/settings/nm-settings.c
index 1029474fc5..f964fb16e4 100644
--- a/src/settings/nm-settings.c
+++ b/src/settings/nm-settings.c
@@ -2750,9 +2750,10 @@ impl_settings_load_connections (NMDBusObject *obj,
for (i = 0; i < n_entries; i++) {
NMSettingsPluginConnectionLoadEntry *entry = &entries[i];
- if (!entry->handled)
+ if (!entry->handled) {
_LOGW ("load: no settings plugin could load \"%s\"", entry->filename);
- else if (entry->error) {
+ nm_assert (!entry->error);
+ } else if (entry->error) {
_LOGW ("load: failure to load \"%s\": %s", entry->filename, entry->error->message);
g_clear_error (&entry->error);
} else