diff options
| author | Thomas Haller <thaller@redhat.com> | 2016-09-27 11:09:13 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2016-09-27 12:06:46 +0200 |
| commit | 90952a85b9556287d6c296aae23ac54df68b13a0 (patch) | |
| tree | ae75c99854897abe13671baf0a3a76181f9503de | |
| parent | 94d07f45b12d2e89fe5333d4e9e142d2a8439057 (diff) | |
| download | NetworkManager-90952a85b9556287d6c296aae23ac54df68b13a0.tar.gz | |
proxy: reject huge pac_script values in verify()
| -rw-r--r-- | libnm-core/nm-setting-proxy.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/libnm-core/nm-setting-proxy.c b/libnm-core/nm-setting-proxy.c index 1d82d22e50..1cfd7cd491 100644 --- a/libnm-core/nm-setting-proxy.c +++ b/libnm-core/nm-setting-proxy.c @@ -173,6 +173,15 @@ verify (NMSetting *setting, NMConnection *connection, GError **error) } } + if (priv->pac_script && strlen (priv->pac_script) > 1*1024*1024) { + g_set_error (error, + NM_CONNECTION_ERROR, + NM_CONNECTION_ERROR_INVALID_PROPERTY, + _("the script is too large")); + g_prefix_error (error, "%s.%s: ", NM_SETTING_PROXY_SETTING_NAME, NM_SETTING_PROXY_PAC_SCRIPT); + return FALSE; + } + return TRUE; } |