summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Zaborowski <andrew.zaborowski@intel.com>2018-10-18 17:47:28 +0200
committerThomas Haller <thaller@redhat.com>2018-10-23 11:32:28 +0200
commitb98f269b91fc69d1242e6583033cbda7d8550a87 (patch)
treecae3e18348a9578b3576a00f63da075d62306921
parentba52c4ea0a71bf22405c86f1a8024e03b65481d7 (diff)
downloadNetworkManager-b98f269b91fc69d1242e6583033cbda7d8550a87.tar.gz
wifi/iwd: print warning if known network exists in interface-added
Something is possibly wrong with the DBus signal handling if a newly added KnownNetwork interface already has an entry in priv->known_networks, but since we handle this case add a warning and update the GDBusProxy pointer for that existing entry.
-rw-r--r--src/devices/wifi/nm-iwd-manager.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/devices/wifi/nm-iwd-manager.c b/src/devices/wifi/nm-iwd-manager.c
index 24cb8a63ba..1ba8587299 100644
--- a/src/devices/wifi/nm-iwd-manager.c
+++ b/src/devices/wifi/nm-iwd-manager.c
@@ -544,9 +544,12 @@ interface_added (GDBusObjectManager *object_manager, GDBusObject *object,
id = known_network_id_new (name, security);
data = g_hash_table_lookup (priv->known_networks, id);
- if (data)
+ if (data) {
+ _LOGW ("DBus error: KnownNetwork already exists ('%s', %s)",
+ name, type_str);
g_free (id);
- else {
+ nm_g_object_ref_set (&data->known_network, proxy);
+ } else {
data = g_slice_new0 (KnownNetworkData);
data->known_network = g_object_ref (proxy);
g_hash_table_insert (priv->known_networks, id, data);