summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2017-12-12 11:05:52 +0100
committerThomas Haller <thaller@redhat.com>2017-12-12 11:15:38 +0100
commitf44f21c87e157c84ab865334f115e9fecd302465 (patch)
tree33b2a4c30d79c7f28561c875607da831c61299a2
parentc274b565a66e0c2932377554ce4d33a4772602e4 (diff)
downloadNetworkManager-f44f21c87e157c84ab865334f115e9fecd302465.tar.gz
core: avoid leaks parsing team link-watcher
Found by coverity.
-rw-r--r--libnm-core/nm-utils.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/libnm-core/nm-utils.c b/libnm-core/nm-utils.c
index 73eb4b520b..73035e5ecb 100644
--- a/libnm-core/nm-utils.c
+++ b/libnm-core/nm-utils.c
@@ -5155,13 +5155,16 @@ _nm_utils_team_link_watcher_from_json (json_t *json_element)
g_return_val_if_fail (json_element, NULL);
json_object_foreach (json_element, j_key, j_val) {
- if (nm_streq (j_key, "name"))
+ if (nm_streq (j_key, "name")) {
+ g_free (name);
name = strdup (json_string_value (j_val));
- else if (nm_streq (j_key, "target_host"))
+ } else if (nm_streq (j_key, "target_host")) {
+ g_free (target_host);
target_host = strdup (json_string_value (j_val));
- else if (nm_streq (j_key, "source_host"))
+ } else if (nm_streq (j_key, "source_host")) {
+ g_free (source_host);
source_host = strdup (json_string_value (j_val));
- else if (NM_IN_STRSET (j_key, "delay_up", "init_wait"))
+ } else if (NM_IN_STRSET (j_key, "delay_up", "init_wait"))
val1 = json_integer_value (j_val);
else if (NM_IN_STRSET (j_key, "delay_down", "interval"))
val2 = json_integer_value (j_val);