diff options
author | Thomas Haller <thaller@redhat.com> | 2018-04-27 11:10:13 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2018-05-14 17:53:03 +0200 |
commit | fc475f25f2ad29efad7af0ac8d6bef4989a0bf15 (patch) | |
tree | 23ae3be37433cb217c48435b76365596e35e51ae /clients/cli/common.c | |
parent | 5975e4a39e81fab9a23db4adc74d531097ac5a41 (diff) | |
download | NetworkManager-th/cli-connection-handling.tar.gz |
cli: use macro for list of argument for NmcMetaGenericInfo.get_fcn()th/cli-connection-handling
The reasons are:
- I want to locate all implmenetations of the get_fcn() handler. By
consistently using this macro, you can just grep for the macro and
find them all.
- all implementations should follow the same style. This macro
enforces the same names for arguments and avoids copy&paste.
- if we are going to add or change an argument, it becomes easier.
That's because we can easily identify all implementation and can
change arguments in one place.
Diffstat (limited to 'clients/cli/common.c')
-rw-r--r-- | clients/cli/common.c | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/clients/cli/common.c b/clients/cli/common.c index 50723a6809..e566de47c8 100644 --- a/clients/cli/common.c +++ b/clients/cli/common.c @@ -100,15 +100,7 @@ _ip_config_get_routes (NMIPConfig *cfg) } static gconstpointer -_metagen_ip4_config_get_fcn (const NMMetaEnvironment *environment, - gpointer environment_user_data, - const NmcMetaGenericInfo *info, - gpointer target, - NMMetaAccessorGetType get_type, - NMMetaAccessorGetFlags get_flags, - NMMetaAccessorGetOutFlags *out_flags, - gboolean *out_is_default, - gpointer *out_to_free) +_metagen_ip4_config_get_fcn (NMC_META_GENERIC_INFO_GET_FCN_ARGS) { NMIPConfig *cfg4 = target; GPtrArray *ptr_array; @@ -183,15 +175,7 @@ arr_out: } static gconstpointer -_metagen_ip6_config_get_fcn (const NMMetaEnvironment *environment, - gpointer environment_user_data, - const NmcMetaGenericInfo *info, - gpointer target, - NMMetaAccessorGetType get_type, - NMMetaAccessorGetFlags get_flags, - NMMetaAccessorGetOutFlags *out_flags, - gboolean *out_is_default, - gpointer *out_to_free) +_metagen_ip6_config_get_fcn (NMC_META_GENERIC_INFO_GET_FCN_ARGS) { NMIPConfig *cfg6 = target; GPtrArray *ptr_array; |