diff options
author | Thomas Haller <thaller@redhat.com> | 2018-10-09 11:50:26 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2018-10-10 09:55:45 +0200 |
commit | 411243c6541e2a82c21b19efc538ced9d01f8cb4 (patch) | |
tree | b001b548c89b603098e16b3ddb954e3ddf43f9f2 /clients/cli/nmcli.c | |
parent | 0be65a4b78289894c6d2056f6293142bb9e18090 (diff) | |
download | NetworkManager-411243c6541e2a82c21b19efc538ced9d01f8cb4.tar.gz |
cli: don't use global nm_cli in nmc_readline_*()
Globals are bad. Don't let nmc_readline_helper() access
nm_cli.
Instead, pass nmc_config along. nmc_config albeit being
a complex struct, is much more begning:
- the configuration nmc_config is initialized early on
and afterwards immutable.
- it only contains simple fields, which affect the behavior.
- it's not a global. While passing around the complex configuration
struct, it is clear that all callpaths don't access additional
global information.
Diffstat (limited to 'clients/cli/nmcli.c')
0 files changed, 0 insertions, 0 deletions