summaryrefslogtreecommitdiff
path: root/clients/cli/utils.h
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2018-04-27 11:10:13 +0200
committerThomas Haller <thaller@redhat.com>2018-05-14 17:53:03 +0200
commitfc475f25f2ad29efad7af0ac8d6bef4989a0bf15 (patch)
tree23ae3be37433cb217c48435b76365596e35e51ae /clients/cli/utils.h
parent5975e4a39e81fab9a23db4adc74d531097ac5a41 (diff)
downloadNetworkManager-th/cli-connection-handling.tar.gz
cli: use macro for list of argument for NmcMetaGenericInfo.get_fcn()th/cli-connection-handling
The reasons are: - I want to locate all implmenetations of the get_fcn() handler. By consistently using this macro, you can just grep for the macro and find them all. - all implementations should follow the same style. This macro enforces the same names for arguments and avoids copy&paste. - if we are going to add or change an argument, it becomes easier. That's because we can easily identify all implementation and can change arguments in one place.
Diffstat (limited to 'clients/cli/utils.h')
-rw-r--r--clients/cli/utils.h22
1 files changed, 13 insertions, 9 deletions
diff --git a/clients/cli/utils.h b/clients/cli/utils.h
index 422d4e8e1d..dc0ce08391 100644
--- a/clients/cli/utils.h
+++ b/clients/cli/utils.h
@@ -138,15 +138,19 @@ struct _NmcMetaGenericInfo {
const char *name;
const char *name_header;
const NmcMetaGenericInfo *const*nested;
- gconstpointer (*get_fcn) (const NMMetaEnvironment *environment,
- gpointer environment_user_data,
- const NmcMetaGenericInfo *info,
- gpointer target,
- NMMetaAccessorGetType get_type,
- NMMetaAccessorGetFlags get_flags,
- NMMetaAccessorGetOutFlags *out_flags,
- gboolean *out_is_default,
- gpointer *out_to_free);
+
+#define NMC_META_GENERIC_INFO_GET_FCN_ARGS \
+ const NMMetaEnvironment *environment, \
+ gpointer environment_user_data, \
+ const NmcMetaGenericInfo *info, \
+ gpointer target, \
+ NMMetaAccessorGetType get_type, \
+ NMMetaAccessorGetFlags get_flags, \
+ NMMetaAccessorGetOutFlags *out_flags, \
+ gboolean *out_is_default, \
+ gpointer *out_to_free
+
+ gconstpointer (*get_fcn) (NMC_META_GENERIC_INFO_GET_FCN_ARGS);
};
#define NMC_META_GENERIC(n, ...) \