summaryrefslogtreecommitdiff
path: root/clients
diff options
context:
space:
mode:
authorFrancesco Giudici <fgiudici@redhat.com>2017-03-29 11:11:05 +0200
committerFrancesco Giudici <fgiudici@redhat.com>2017-03-29 11:37:15 +0200
commit9a38eb4c66a34af34551cae582b1dfc4904909c2 (patch)
tree33ee2c063276109a2d6cc380d96ec593380edcfb /clients
parent6198c2a5a4c74c35e621cd2d70d5fb6b7b90c133 (diff)
downloadNetworkManager-9a38eb4c66a34af34551cae582b1dfc4904909c2.tar.gz
nmcli: fix nmcli connection edit
fix extra parameters check in nmc_parse_args() e.g.: nmcli connection edit type ethernet Fixes: 16902a2be66866aa541bb56ccb98c765ac21d1a2 (cherry picked from commit 0e73a0664690f8e3190c9750c7fba86673bc2996)
Diffstat (limited to 'clients')
-rw-r--r--clients/cli/utils.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/clients/cli/utils.c b/clients/cli/utils.c
index a6f18c5f0e..fbd643ffc4 100644
--- a/clients/cli/utils.c
+++ b/clients/cli/utils.c
@@ -134,13 +134,13 @@ nmc_parse_args (nmc_arg_t *arg_arr, gboolean last, int *argc, char ***argv, GErr
}
if (p->has_value) {
- if (!argc) {
+ (*argc)--;
+ (*argv)++;
+ if (!*argc) {
g_set_error (error, NMCLI_ERROR, NMC_RESULT_ERROR_USER_INPUT,
_("Error: value for '%s' argument is required."), *(*argv-1));
return FALSE;
}
- argc--;
- argv++;
*(p->value) = **argv;
}
p->found = TRUE;