libnm: rework checkpoint API

The libnm API fir checkpoints was only introduced with 1.11. It
is not yet stable, so there is still time to adjust it. Note that
this changes API/ABI of the development branch.

Changes:

- we only add async variants of the checkpoint functions. I believe
  that synchronous D-Bus methods are fundamentally flawed, because
  they mess up the ordering of events.
  Rename the async functions by removing the "_async" suffix. This
  matches glib style, for which the async form is also not specially
  marked.

- for function that refere to a particular checkpoint (rollback and
  destroy), accept the D-Bus path as string, instead of an NMCheckpoint
  instance. This form is more flexible, because it allows to use
  the function without having a NMCheckpoint instance at hand. On the
  other hand, if one has a NMCheckpoint instance, he can trivially
  obtain the path to make the call.

1 files changed, 17 insertions, 17 deletions

diff --git a/libnm/nm-client.h b/libnm/nm-client.h
index f7ec4b7a2c..6f4a86c957 100644
--- a/libnm/nm-client.h
+++ b/libnm/nm-client.h
@@ -408,35 +408,35 @@ NM_AVAILABLE_IN_1_12
 const GPtrArray *nm_client_get_checkpoints (NMClient *client);
 
 NM_AVAILABLE_IN_1_12
-void nm_client_checkpoint_create_async (NMClient *client,
-                                        const GPtrArray *devices,
-                                        guint32 rollback_timeout,
-                                        NMCheckpointCreateFlags flags,
-                                        GCancellable *cancellable,
-                                        GAsyncReadyCallback callback,
-                                        gpointer user_data);
+void nm_client_checkpoint_create (NMClient *client,
+                                  const GPtrArray *devices,
+                                  guint32 rollback_timeout,
+                                  NMCheckpointCreateFlags flags,
+                                  GCancellable *cancellable,
+                                  GAsyncReadyCallback callback,
+                                  gpointer user_data);
 NM_AVAILABLE_IN_1_12
 NMCheckpoint *nm_client_checkpoint_create_finish (NMClient *client,
                                                   GAsyncResult *result,
                                                   GError **error);
 
 NM_AVAILABLE_IN_1_12
-void nm_client_checkpoint_destroy_async (NMClient *client,
-                                         NMCheckpoint *checkpoint,
-                                         GCancellable *cancellable,
-                                         GAsyncReadyCallback callback,
-                                         gpointer user_data);
+void nm_client_checkpoint_destroy (NMClient *client,
+                                   const char *checkpoint_path,
+                                   GCancellable *cancellable,
+                                   GAsyncReadyCallback callback,
+                                   gpointer user_data);
 NM_AVAILABLE_IN_1_12
 gboolean nm_client_checkpoint_destroy_finish (NMClient *client,
                                               GAsyncResult *result,
                                               GError **error);
 
 NM_AVAILABLE_IN_1_12
-void nm_client_checkpoint_rollback_async (NMClient *client,
-                                          NMCheckpoint *checkpoint,
-                                          GCancellable *cancellable,
-                                          GAsyncReadyCallback callback,
-                                          gpointer user_data);
+void nm_client_checkpoint_rollback (NMClient *client,
+                                    const char *checkpoint_path,
+                                    GCancellable *cancellable,
+                                    GAsyncReadyCallback callback,
+                                    gpointer user_data);
 NM_AVAILABLE_IN_1_12
 GHashTable *nm_client_checkpoint_rollback_finish (NMClient *client,
                                                   GAsyncResult *result,