diff options
| author | Lubomir Rintel <lkundrak@v3.sk> | 2016-02-12 09:05:27 +0100 |
|---|---|---|
| committer | Lubomir Rintel <lkundrak@v3.sk> | 2016-02-12 09:05:27 +0100 |
| commit | 4c3e69f9e91fdecbbcc657e03bec7d7fc086cd1a (patch) | |
| tree | 8a8c4723e116c90da09f2ae24ced4d9cd2cac78f /shared | |
| parent | 87edaa2a429a63cb1813fa39363b22d6940702af (diff) | |
| download | NetworkManager-4c3e69f9e91fdecbbcc657e03bec7d7fc086cd1a.tar.gz | |
test: use g_assert_not_reached () instead of asserting FALSE
It's declared as never returning, making do a better at understanding control
flow. Otherwise it makes a poor guess:
In file included from test-crypto.c:37:
../../shared/nm-test-utils.h:1344:3: error: variable 'family' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
g_assert (FALSE);
^~~~~~~~~~~~~~~~
Diffstat (limited to 'shared')
| -rw-r--r-- | shared/nm-test-utils.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/shared/nm-test-utils.h b/shared/nm-test-utils.h index fcae761228..66cacb7859 100644 --- a/shared/nm-test-utils.h +++ b/shared/nm-test-utils.h @@ -1341,7 +1341,7 @@ nmtst_setting_ip_config_add_address (NMSettingIPConfig *s_ip, else if (nm_utils_ipaddr_valid (AF_INET6, address)) family = AF_INET6; else - g_assert (FALSE); + g_assert_not_reached (); addr = nm_ip_address_new (family, address, prefix, NULL); g_assert (addr); @@ -1366,7 +1366,7 @@ nmtst_setting_ip_config_add_route (NMSettingIPConfig *s_ip, else if (nm_utils_ipaddr_valid (AF_INET6, dest)) family = AF_INET6; else - g_assert (FALSE); + g_assert_not_reached (); route = nm_ip_route_new (family, dest, prefix, next_hop, metric, NULL); g_assert (route); |