diff options
| author | Dan Williams <dcbw@redhat.com> | 2016-10-06 11:27:45 -0500 |
|---|---|---|
| committer | Dan Williams <dcbw@redhat.com> | 2016-10-07 14:54:27 -0500 |
| commit | 6126c32e6bd58c3f83d834d3b28fa3f3cfc176c8 (patch) | |
| tree | d80feba4b7bee1457f1aff4cf22c409e99a48e05 /src/devices/nm-device-ethernet.c | |
| parent | 3ceaef90fefbaf3199a8d52c5cfaa06420a81747 (diff) | |
| download | NetworkManager-6126c32e6bd58c3f83d834d3b28fa3f3cfc176c8.tar.gz | |
wwan/ppp: send explicit port speed to pppd when port speed is zero (rh #1281731)
Some TTY drivers or devices appear to ignore port speed and always
report zero. Technically this means the port is hung up and control
lines should be disconnected, but with USB devices many of the serial
port attributes are meaningless and ignored by some devices.
pppd requires the port's speed to be greater than zero, and will
exit immediately when that is not the case, even though these
modems will work fine. Passing an explicit speed to pppd in this
case works around the issue, as pppd attempts to set that speed
on the port and doesn't actually care if that operation fails.
https://bugzilla.redhat.com/show_bug.cgi?id=1281731
Diffstat (limited to 'src/devices/nm-device-ethernet.c')
| -rw-r--r-- | src/devices/nm-device-ethernet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/devices/nm-device-ethernet.c b/src/devices/nm-device-ethernet.c index fd80a607a2..3604a168a8 100644 --- a/src/devices/nm-device-ethernet.c +++ b/src/devices/nm-device-ethernet.c @@ -937,7 +937,7 @@ pppoe_stage3_ip4_config_start (NMDeviceEthernet *self, NMDeviceStateReason *reas g_assert (s_pppoe); priv->ppp_manager = nm_ppp_manager_new (nm_device_get_iface (NM_DEVICE (self))); - if (nm_ppp_manager_start (priv->ppp_manager, req, nm_setting_pppoe_get_username (s_pppoe), 30, &err)) { + if (nm_ppp_manager_start (priv->ppp_manager, req, nm_setting_pppoe_get_username (s_pppoe), 30, 0, &err)) { g_signal_connect (priv->ppp_manager, NM_PPP_MANAGER_STATE_CHANGED, G_CALLBACK (ppp_state_changed), self); |