diff options
author | Thomas Haller <thaller@redhat.com> | 2015-07-08 16:53:40 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2015-07-14 15:52:50 +0200 |
commit | 9020cd1aacf26a03cf1bc46b040d42a791a89935 (patch) | |
tree | 0fd5cb155c3c42b72f533658d1dbbbc6260b4c1e /src/main.c | |
parent | 09ba572174e9109988ede039342b6098d61bc7e0 (diff) | |
download | NetworkManager-9020cd1aacf26a03cf1bc46b040d42a791a89935.tar.gz |
logging: remove nm_logging_syslog_closelog()
Remove nm_logging_syslog_closelog(). The reasons are:
- closelog() is optional according to the manual.
- we called nm_logging_syslog_closelog() at the end of the
main() function. But we have destructors running afterwards,
so we were closing the log before logging the last line.
Apparently that had no bad consequences either, so why was
closelog() even useful?
Also, it's hard to determine when we log the last line and
only closelog() afterwards.
- closelog() does not revert what openlog() did, this is ugly.
Diffstat (limited to 'src/main.c')
-rw-r--r-- | src/main.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main.c b/src/main.c index ad44471df6..7b1e522467 100644 --- a/src/main.c +++ b/src/main.c @@ -486,8 +486,6 @@ main (int argc, char *argv[]) done: g_clear_object (&manager); - nm_logging_syslog_closelog (); - if (global_opt.pidfile && wrote_pidfile) unlink (global_opt.pidfile); |