summaryrefslogtreecommitdiff
path: root/src/settings/nm-inotify-helper.h
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-06-01 10:28:42 +0200
committerThomas Haller <thaller@redhat.com>2019-06-02 08:48:07 +0200
commit8ea5fddf848e1bd95a85d3460630f3e4c34f2919 (patch)
tree0dc5b4027a28ee520ea5f0230b89a970e1fb5fc3 /src/settings/nm-inotify-helper.h
parent4277607d2737add5920f28f7c07b831a4b6b2f86 (diff)
downloadNetworkManager-th/team-fix.tar.gz
libnm/team: strict validate team settings by libnm clients not sending the JSONth/team-fix
When parsing a NMSettingTeam/NMSettingTeamPort from GVariant, the JSON "config" is always preferred. If that field is present, all other attributes are ignored (aside from validating that the individual fields are as expected). The idea is that the JSON config anyway must contain everything that artificial properties could. In this mode, also no validation is performed and the setting is always accepted (regardless whether libnm thinks the setting verifies). When a libnm client created the setting via the artificial properties, only send them via D-Bus and exclude the JSON config. This turns on strict validation server side. Now we actually get validation of the settings: $ nmcli connection add type team team.runner-tx-hash l3 Error: Failed to add 'team' connection: team.runner: runner-tx-hash is only allowed for runners loadbalance,lacp this is obviously a change in behavior as previously all settings would have been accepted, regardless whether they made sense.
Diffstat (limited to 'src/settings/nm-inotify-helper.h')
0 files changed, 0 insertions, 0 deletions