diff options
author | Thomas Haller <thaller@redhat.com> | 2018-11-30 11:22:20 +0100 |
---|---|---|
committer | Beniamino Galvani <bgalvani@redhat.com> | 2018-12-01 15:16:48 +0100 |
commit | 92efe8a53cd405c4e8e6c7faa65dd9aec2aabce6 (patch) | |
tree | 7e8a6b931895aba36857b8f5af64933aa88e156f /src/tests/test-general.c | |
parent | 6dfb42270f6c069853cd7334b78e31a8f4537ef7 (diff) | |
download | NetworkManager-92efe8a53cd405c4e8e6c7faa65dd9aec2aabce6.tar.gz |
clients: use NM_MAKE_STRV() instead of VALUES_STATIC()
VALUES_STATIC() was a macro to initialize the values_static pointer with
a (static) strv array.
For one, it lacked a "const" in "(const char *[])", which means
the data is not put in a read only section by the linker. That should
be fixed.
Anyway, we already have a macro for creating such constant strv arrays:
NM_MAKE_STRV().
I think it is good to the concept of "initializing values_static" a
name (VALUES_STATIC()). But it also hides (for better or worse), that
this is a strv array. Let's use NM_MAKE_STRV() instead. By looking at
the code, it's still clear that this initializes the "values_static"
array, but it also makes it clear that this is a plain strv array.
Diffstat (limited to 'src/tests/test-general.c')
0 files changed, 0 insertions, 0 deletions