summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* ifcfg-rh: emit a warning when DEFROUTE=no and GATEWAY is setbg/gateway-never-default-rh1313091-v2Beniamino Galvani2016-04-221-0/+5
|
* libnm-core: remove gateway when never-default=yes in NMSettingIPConfigBeniamino Galvani2016-04-223-1/+76
| | | | | | | | | | Having a gateway defined when never-default=yes causes troubles in connection matching and anyway makes no sense. If the combination is found, remove the gateway during the normalization phase. https://bugzilla.redhat.com/show_bug.cgi?id=1313091
* dhcp: refactor nm_dhcp_client_stop_existing()Thomas Haller2016-04-221-34/+32
|
* core: minor cleanup of nm_utils_get_start_time_for_pid()Thomas Haller2016-04-221-17/+19
| | | | | | And for @out_state, return ' ' instead of '\0' in case of failure. That is more friendly, when the user happens to print the value.
* docs: include the D-Bus enums reference with the API documentationLubomir Rintel2016-04-225-1/+214
| | | | | | Otherwise the types links would be dangling or resolved to slightly irrelevant documentation in libnm or completely irrelevant documentation in libnm-util.
* libnm-core: don't link to NMDevice type from the D-Bus specLubomir Rintel2016-04-221-2/+2
| | | | | | It isn't right in that context -- NMDevice is a libnm-core object, not a bus object. In rendered documentation this would generate a dangling link.
* misc: update maintainers and authorsDan Williams2016-04-212-9/+4
|
* dns: avoid using global "/etc/dnsmasq.conf" config for dnsmasqThomas Haller2016-04-211-0/+1
| | | | | | | | | | | Pass an empty configuration file otherwise dnsmasq loads "/etc/dnsmasq.conf". We already allow for a config.d/ directory "/etc/NetworkManager/dnsmasq.d" to allow the user to overwrite configuration. We don't want to consider the global config file. Fixes: 497a8aa5c6463404200a3fcc745aa65396dc4f22
* dns: merge branch 'th/dnsmasq-dbus-bgo765043'Thomas Haller2016-04-213-139/+308
|\ | | | | | | | | https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00144.html https://bugzilla.gnome.org/show_bug.cgi?id=765043
| * dns: various cleanup for new dnsmasq's D-Bus supportThomas Haller2016-04-214-210/+116
| |
| * dns: use DBus to make dnsmasq nameserver changesMathieu Trudel-Lapierre2016-04-215-63/+318
| | | | | | | | | | | | | | | | | | Use DBus to make nameserver updates rather than restarting the dnsmasq binary again and again. Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com> https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00144.html
| * dns: add and use _NMLOG() logging macro in nm-dns-plugin.cThomas Haller2016-04-211-9/+31
| |
| * dns: cleanup managing child process for NMDnsPluginThomas Haller2016-04-211-26/+28
| | | | | | | | | | | | | | The 4 private fields pid, watch_id, progname and pidfile strictly belong together. When spawning a child, we set all 4 of them and when killing the child all get cleared. Cleanup to code to always set those 4 fields together.
| * dns: remove unnecessary finalize() implementation from NMDnsPluginThomas Haller2016-04-211-13/+0
| | | | | | | | | | dispose() already calls nm_dns_plugin_child_kill(), which clears both pidfile and progname.
| * dns: minor code cleanup in NMDnsPluginThomas Haller2016-04-211-8/+5
|/
* platform: stack-allocate anycast_mask path in _linktype_get_type()Thomas Haller2016-04-211-4/+6
|
* platform: refactor wifi_utils_is_wifi() not to pass sysfs_pathThomas Haller2016-04-213-11/+14
| | | | | | | wifi_utils_is_wifi() only has one caller, so it's very clear what the passed in @sysfs_path contains. Instead of accepting a redundant argument, compute the sysfs path internally based on @iface alone.
* platform: stack-allocate temporary string in _linktype_read_devtype()Thomas Haller2016-04-211-3/+8
| | | | And while at it, don't pass the sysfs_path but instead the ifname to it.
* dns: add trace logging when writing resolv.confThomas Haller2016-04-201-22/+79
| | | | | It is interesting to find in the logfile when we write to "/etc/resolv.conf" or our internal version "/var/run/NetworkManager/resolv.conf".
* manager: fix wrongly removing DNS configuration on shutdownThomas Haller2016-04-203-4/+20
| | | | | | | When NetworkManager exits, it must preserve the DNS configuration of devices that are left up. Fixes: 9498ea507eb1d5042736c4351337e91b9c13bdf6
* audit: log changed properties when updating a connectionBeniamino Galvani2016-04-205-20/+78
| | | | | | | | | | | | | | The main purpose of audit logging is to understand who did what to the system configuration, so it is useful to log also the list of changed properties when a connection is updated: op="connection-update" uuid="2f3e48fc-5f47-41d9-9278-d2871378df43" name="pppoe1" args="pppoe.username,pppoe.password" <======== pid=9523 uid=1001 result="success"
* modem: cancel secrets only if there's an outstanding requestLubomir Rintel2016-04-201-1/+2
| | | | | Fixes an assertion failure on WWAN connection attempts that fail before secrets are requested.
* platform: merge branch 'th/platform-infiniband-cleanup-bgo765303'Thomas Haller2016-04-205-49/+118
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=765303
| * platform: request link after deleting inifiniband partitionThomas Haller2016-04-201-24/+36
| | | | | | | | | | After issuing the sysctl "delete_child", we must request the link to get the platform cache in sync.
| * platform: stack allocate string buffers in _infiniband_partition_action()Thomas Haller2016-04-201-7/+7
| |
| * platform: use nm_utils_new_infiniband_name()Thomas Haller2016-04-203-17/+18
| |
| * core: add nm_utils_new_infiniband_name() utilThomas Haller2016-04-202-0/+28
| |
| * platform: preserve errno in nm_platform_sysctl_set()Thomas Haller2016-04-201-9/+31
| | | | | | | | | | We want to preserve the relevant errno during nm_platform_sysctl_set(). Also, if the final close() fails, fail altogether.
| * platform: restrict valid p_key for infiniband partitionsThomas Haller2016-04-202-1/+7
|/
* libnm/vpn-service-plugin: don't register a bus name before creating the VPN ↵Lubomir Rintel2016-04-201-13/+13
| | | | | | | | | | object Otherwise NetworkManager can be too fast calling a method: <error> [1461073999.2362] vpn-connection[0x7fe39ec491e0,be049803-a705-438f-b8f5-49db87640c93,"libreswan",0]: plugin NeedSecrets request #1 failed: No such interface 'org.freedesktop.NetworkManager.VPN.Plugin' on object at path /org/freedesktop/NetworkManager/VPN/Plugin
* platform: avoid using the nm_platform_link_*() getters excessivelyLubomir Rintel2016-04-201-6/+8
| | | | Thomas thinks it's a sin.
* infiniband: remove the partitions on unrealizingLubomir Rintel2016-04-203-8/+48
| | | | | | The infiniband drivers don't implement the rtnetlink link deletions. Therefore we unrealize the NMDevice instance but the backing resources stay around, preventing us from ever realizing the device again.
* platform: add functionality to remove infiniband partitionsLubomir Rintel2016-04-204-18/+87
|
* libnm-core: empty key is not a pkcs12 fileLubomir Rintel2016-04-202-0/+6
| | | | | | nmcli> set 802-1x.ca-cert file:///tmp/certs/eaptest_ca_cert.pem (process:31015): libnm-CRITICAL **: crypto_is_pkcs12_data: assertion 'data != NULL' failed Error: failed to set 'ca-cert' property: PEM certificate had no start tag '-----BEGIN CERTIFICATE-----'.
* examples: fix crash in add-connection-libnmBeniamino Galvani2016-04-201-1/+1
| | | | Reported-by: Ali Nematollahi <alirezan1@gmail.com>
* Revert "core: don't leak ActiveConnection object on AddAndActivate failure"Dan Williams2016-04-191-1/+0
| | | | | | This reverts commit 8b6a1ac62f2cb39b1246d7dff3525b1a8bb48f2c. Original patch was in error; 'active' is already gs_unref_object.
* libnm/vpn: search VPN plugin in NMPLUGINDIRThomas Haller2016-04-195-77/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit ca000cffbb9ef20c6dd965283df3f1babf0a7745, we changed to accept a plugin library name without path. One reason for that is to keep architecture dependent parts out of the .name file and possibly support multilib. However, the shared libraries of VPN plugins are not installed in a global library search path, but for example into "/usr/lib64/NetworkManager/libnm-vpn-plugin-openvpn.so". In that case, specifying "plugin=libnm-vpn-plugin-openvpn.so" would not be enough to find plugin. Instead, when configuring a plugin name without path, assume it is in NMPLUGINDIR directory. Modify nm_vpn_editor_plugin_load_from_file() to allow path-less plugin-names. Previously such names would be rejected as not being absolute. This API allows to do file verification before loading the plugin, but it now supports prepending NMPLUGINDIR to the plugin name. Basically, this function mangles the plugin_name argument and checks that such a file exists. The recently added nm_vpn_editor_plugin_load() continues to behave as before: it does no checks whatsoever and passes the name directly to dlopen(). That way, it uses system search paths like LD_LIBRARY_PATH and performs no checks on the file. Fixes: ca000cffbb9ef20c6dd965283df3f1babf0a7745
* libnm/vpn: merge branch 'th/vpn-load-plugin-bgo765225'Thomas Haller2016-04-1910-91/+185
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=765225
| * libnm/vpn: add nm_vpn_editor_plugin_load() functionThomas Haller2016-04-193-1/+51
| | | | | | | | | | | | Contrary to nm_vpn_editor_plugin_load_from_file(), this allows to specify a library name without path. In this case, g_module_open() (dlopen()) will search for a library in various system directories.
| * libnm/vpn: allow specifying non-absolute plugin name in VPN .name fileThomas Haller2016-04-193-39/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit 3dfbbb227e82b47973f612b6b031d8d591727436, we enforce that the plugin path in the .name file is absolute and we perform several checks on the file before loading it (ownership, etc). Relax that, to also allow libray names without path component. In that case, g_module_open()/dlopen() will search for a library in various search paths. This allows, to omit absolute paths in the .name file. The latter is problematic, because by default we install the .name file in the architecture independent location /usr/lib/NetworkManager. As such, it should not contain paths to architecture dependent libraries. With this change, a .name file can contain only the library name and it will be loaded using the usual mechanism. However, specifying absolute paths is still possible and works same as before, including checking file permissions. As such, distributions probably should package the VPN plugins to have no path in the .name file. On the other hand, a user compiling from source probably wants to specify an absolute path. The reason is, that the user probably doesn't build the plugin for multiple achitectures and that way, he can install the plugin in a separate (private) prefix.
| * libnm/vpn: fix code comment for nm_vpn_editor_plugin_load_from_file()Thomas Haller2016-04-191-5/+1
| | | | | | | | | | | | | | The @plugin_filename argument must be an absolute path. That was changed later, but forgot to update the comment. Fixes: 3dfbbb227e82b47973f612b6b031d8d591727436
| * libnm/vpn: clear internal "keyfile" from NMVpnPluginInfoThomas Haller2016-04-191-4/+6
| | | | | | | | | | The GKeyFile is no longer needed after constuction. All strings are copied over to the "keys" hash.
| * libnm/vpn: lookup nm_vpn_plugin_info_supports_multiple() from cached valuesThomas Haller2016-04-191-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of looking into the keyfile, lookup the "supports-multiple-connections" setting in the "keys" hash. This has some behavioral difference: - g_key_file_get_boolean() first does g_key_file_get_value(), and then converts the string using the private g_key_file_parse_value_as_boolean() function -- which is case-sensitive, accepts "true|false|0|1" and considers only the text until the first whitespace. - now, we put g_key_file_get_string() into the cache "keys" and parse it with _nm_utils_ascii_str_to_bool(). The latter is case insensitive, allows also "yes|no|on|off", strips whitespaces. However, the difference is subtle and shouldn't matter. The point of this change is to free "keyfile" after construction.
| * shared: move nm_utils_ascii_str_to_bool() to shared/nm-shared-utils.hThomas Haller2016-04-195-40/+38
|/
* device: check for a parent deviceLubomir Rintel2016-04-193-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | The device creation can be attempted if the name can be determined. It alone is doesn't mean that there's a parent device -- the name could just have been hardcoded in the connection. NetworkManager[21519]: nm_device_get_ifindex: assertion 'NM_IS_DEVICE (self)' failed Program received signal SIGTRAP, Trace/breakpoint trap. g_logv (log_domain=0x5555557fb2e5 "NetworkManager", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffd3d0) at gmessages.c:1046 1046 g_private_set (&g_log_depth, GUINT_TO_POINTER (depth)); (gdb) bt #0 0x00007ffff4ec88c3 in g_logv (log_domain=0x5555557fb2e5 "NetworkManager", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffd3d0) at gmessages.c:1046 #1 0x00007ffff4ec8a3f in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at gmessages.c:1079 #2 0x00005555555d2090 in nm_device_get_ifindex (self=0x0) at devices/nm-device.c:562 #3 0x00005555555ef77a in nm_device_supports_vlans (self=0x0) at devices/nm-device.c:9865 #4 0x00005555555bf2f9 in create_and_realize (device=0x555555c549b0 [NMDeviceVlan], connection=0x555555b451e0, parent=0x0, out_plink=0x7fffffffd5f8, error=0x7fffffffd700) at devices/nm-device-vlan.c:225 #5 0x00005555555d5757 in nm_device_create_and_realize (self=0x555555c549b0 [NMDeviceVlan], connection=0x555555b451e0, parent=0x0, error=0x7fffffffd700) at devices/nm-device.c:1783 #6 0x0000555555688601 in system_create_virtual_device (self=0x555555af51c0 [NMManager], connection=0x555555b451e0) at nm-manager.c:1120 #7 0x000055555568894e in connection_changed (settings=0x555555ae8220 [NMSettings], connection=0x555555b451e0, manager=0x555555af51c0 [NMManager]) at nm-manager.c:1172 #8 0x0000555555693448 in nm_manager_start (self=0x555555af51c0 [NMManager], error=0x7fffffffda30) at nm-manager.c:4466 #9 0x00005555555d166f in main (argc=1, argv=0x7fffffffdba8) at main.c:454 (gdb) Fixes: 332994f1b19ded7cb343ef573443916bab05aaec
* infiniband: check that the connection to be created is a partition firstLubomir Rintel2016-04-191-7/+8
| | | | | No functional change. It will make it a bit easier to produce a good error message in subsequent commit.
* infiniband: consistently use the error codeLubomir Rintel2016-04-191-3/+3
| | | | Only report CREATION_FAILED when we did actually attempt creation.
* macvlan: fix error handlingLubomir Rintel2016-04-191-1/+2
|
* merge: merge branch 'systemd' into masterThomas Haller2016-04-1916-97/+241
|\
| * systemd: update code from upstreamThomas Haller2016-04-1915-94/+239
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a direct dump from systemd git on 2016-04-19, git commit 490d20e65dd85628f910299a3925bbff466b2e74. ====== SYSTEMD_DIR=../systemd COMMIT=490d20e65dd85628f910299a3925bbff466b2e74 ( cd "$SYSTEMD_DIR" git checkout "$COMMIT" git reset --hard git clean -fdx ) git ls-files :/src/systemd/src/ | xargs -d '\n' rm -f nm_copy_sd() { mkdir -p "./src/systemd/$(dirname "$1")" cp "$SYSTEMD_DIR/$1" "./src/systemd/$1" } nm_copy_sd "src/basic/alloc-util.c" nm_copy_sd "src/basic/alloc-util.h" nm_copy_sd "src/basic/async.h" nm_copy_sd "src/basic/escape.c" nm_copy_sd "src/basic/escape.h" nm_copy_sd "src/basic/ether-addr-util.c" nm_copy_sd "src/basic/ether-addr-util.h" nm_copy_sd "src/basic/fileio.c" nm_copy_sd "src/basic/fileio.h" nm_copy_sd "src/basic/fd-util.c" nm_copy_sd "src/basic/fd-util.h" nm_copy_sd "src/basic/fs-util.c" nm_copy_sd "src/basic/fs-util.h" nm_copy_sd "src/basic/hash-funcs.c" nm_copy_sd "src/basic/hash-funcs.h" nm_copy_sd "src/basic/hashmap.c" nm_copy_sd "src/basic/hashmap.h" nm_copy_sd "src/basic/hexdecoct.c" nm_copy_sd "src/basic/hexdecoct.h" nm_copy_sd "src/basic/hostname-util.c" nm_copy_sd "src/basic/hostname-util.h" nm_copy_sd "src/basic/in-addr-util.c" nm_copy_sd "src/basic/in-addr-util.h" nm_copy_sd "src/basic/io-util.c" nm_copy_sd "src/basic/io-util.h" nm_copy_sd "src/basic/list.h" nm_copy_sd "src/basic/log.h" nm_copy_sd "src/basic/macro.h" nm_copy_sd "src/basic/mempool.h" nm_copy_sd "src/basic/mempool.c" nm_copy_sd "src/basic/parse-util.c" nm_copy_sd "src/basic/parse-util.h" nm_copy_sd "src/basic/path-util.c" nm_copy_sd "src/basic/path-util.h" nm_copy_sd "src/basic/prioq.h" nm_copy_sd "src/basic/prioq.c" nm_copy_sd "src/basic/random-util.c" nm_copy_sd "src/basic/random-util.h" nm_copy_sd "src/basic/refcnt.h" nm_copy_sd "src/basic/set.h" nm_copy_sd "src/basic/signal-util.h" nm_copy_sd "src/basic/siphash24.c" nm_copy_sd "src/basic/siphash24.h" nm_copy_sd "src/basic/socket-util.c" nm_copy_sd "src/basic/socket-util.h" nm_copy_sd "src/basic/sparse-endian.h" nm_copy_sd "src/basic/stdio-util.h" nm_copy_sd "src/basic/string-table.c" nm_copy_sd "src/basic/string-table.h" nm_copy_sd "src/basic/string-util.c" nm_copy_sd "src/basic/string-util.h" nm_copy_sd "src/basic/strv.c" nm_copy_sd "src/basic/strv.h" nm_copy_sd "src/basic/time-util.c" nm_copy_sd "src/basic/time-util.h" nm_copy_sd "src/basic/umask-util.h" nm_copy_sd "src/basic/unaligned.h" nm_copy_sd "src/basic/utf8.c" nm_copy_sd "src/basic/utf8.h" nm_copy_sd "src/basic/util.c" nm_copy_sd "src/basic/util.h" nm_copy_sd "src/libsystemd-network/arp-util.c" nm_copy_sd "src/libsystemd-network/arp-util.h" nm_copy_sd "src/libsystemd-network/dhcp6-internal.h" nm_copy_sd "src/libsystemd-network/dhcp6-lease-internal.h" nm_copy_sd "src/libsystemd-network/dhcp6-network.c" nm_copy_sd "src/libsystemd-network/dhcp6-option.c" nm_copy_sd "src/libsystemd-network/dhcp6-protocol.h" nm_copy_sd "src/libsystemd-network/dhcp-identifier.c" nm_copy_sd "src/libsystemd-network/dhcp-identifier.h" nm_copy_sd "src/libsystemd-network/dhcp-internal.h" nm_copy_sd "src/libsystemd-network/dhcp-lease-internal.h" nm_copy_sd "src/libsystemd-network/dhcp-network.c" nm_copy_sd "src/libsystemd-network/dhcp-option.c" nm_copy_sd "src/libsystemd-network/dhcp-packet.c" nm_copy_sd "src/libsystemd-network/dhcp-protocol.h" nm_copy_sd "src/libsystemd-network/lldp-internal.h" nm_copy_sd "src/libsystemd-network/lldp-neighbor.c" nm_copy_sd "src/libsystemd-network/lldp-neighbor.h" nm_copy_sd "src/libsystemd-network/lldp-network.c" nm_copy_sd "src/libsystemd-network/lldp-network.h" nm_copy_sd "src/libsystemd-network/network-internal.c" nm_copy_sd "src/libsystemd-network/network-internal.h" nm_copy_sd "src/libsystemd-network/sd-dhcp6-client.c" nm_copy_sd "src/libsystemd-network/sd-dhcp6-lease.c" nm_copy_sd "src/libsystemd-network/sd-dhcp-client.c" nm_copy_sd "src/libsystemd-network/sd-dhcp-lease.c" nm_copy_sd "src/libsystemd-network/sd-ipv4ll.c" nm_copy_sd "src/libsystemd-network/sd-ipv4acd.c" nm_copy_sd "src/libsystemd-network/sd-lldp.c" nm_copy_sd "src/libsystemd/sd-event/sd-event.c" nm_copy_sd "src/libsystemd/sd-id128/sd-id128.c" nm_copy_sd "src/shared/dns-domain.c" nm_copy_sd "src/shared/dns-domain.h" nm_copy_sd "src/systemd/_sd-common.h" nm_copy_sd "src/systemd/sd-dhcp6-client.h" nm_copy_sd "src/systemd/sd-dhcp6-lease.h" nm_copy_sd "src/systemd/sd-dhcp-client.h" nm_copy_sd "src/systemd/sd-dhcp-lease.h" nm_copy_sd "src/systemd/sd-event.h" nm_copy_sd "src/systemd/sd-ndisc.h" nm_copy_sd "src/systemd/sd-id128.h" nm_copy_sd "src/systemd/sd-ipv4acd.h" nm_copy_sd "src/systemd/sd-ipv4ll.h" nm_copy_sd "src/systemd/sd-lldp.h"
View Lorry Controller Status