summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* wifi: set the BridgeIfname supplicant property when neededbg/wifi-bridgeBeniamino Galvani2020-10-123-0/+62
| | | | | | | | | | | | | | | When a wifi device is in a bridge, the supplicant must be aware of it, as a socket must be opened on the bridge to receive packets. Set the BridgeIfname property of the supplicant Interface object before starting the association. Note that the property was read-only in the past and recently [1] became read-write. When using a supplicant version without the patch, writing the property will return an InvalidArgs error and NetworkManager will print a warning. [1] https://w1.fi/cgit/hostap/commit/?id=1c58317f56e312576b6872440f125f794e45f991 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/83
* wifi: re-add code for tracking a peers groupsBenjamin Berg2020-10-123-3/+23
| | | | | | | | | | | | The code to track the property was accidentally removed in commit 21d4a2618868 ('core: remove code for unused NM_WIFI_P2P_PEER_GROUPS property') causing all P2P connections to fail after 5 seconds. Fixes: 21d4a2618868 ('core: remove code for unused NM_WIFI_P2P_PEER_GROUPS property') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/551 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/650
* device/wifi: fix leak of NMSupplicantPeerInfo.peer_path in NMSupplicantInterfaceThomas Haller2020-10-121-0/+2
| | | | Fixes: b83f07916a54 ('supplicant: large rework of wpa_supplicant handling')
* po: update Portuguese (pt) translationJuliano de Souza Camargo2020-10-121-47/+48
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/648
* po: update Ukrainian (uk) translationYuri Chornoivan2020-10-121-2078/+2148
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/647
* dns: add edns0 and trust-ad options when using local resolverbg/dns-stub-edns0Beniamino Galvani2020-10-091-0/+16
| | | | | | | | | | | | | | | | | | | | | | EDNS(0) is not enabled by default in glibc because the option has interoperability issues with some DNS servers. dnsmasq and systemd-resolved don't have such problems. Enable the option automatically when using a local resolver so that the data provided via EDNS(0) (e.g. SSH fingerprints or DNSSEC information) is available to applications. While at it, also enable 'trust-ad', as otherwise glibc (from version 2.31) strips the AD bit from responses [1]. systemd-resolved also adds both flags to resolv.conf when using the stub resolver [2]. [1] https://sourceware.org/git/?p=glibc.git;a=blobdiff;f=NEWS;h=12b239c1fbbe789114e59fed136efcdeecc5c9cd;hp=4e28dc473c844ef230e973fc8861bfbd4bc36b74;hb=446997ff1433d33452b81dfa9e626b8dccf101a4;hpb=4a2ab5843a5cc4a5db1b3b79916a520ea8b115dc [2] https://github.com/systemd/systemd/blob/v246/src/resolve/resolved-resolv-conf.c#L310 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/233 https://bugzilla.redhat.com/show_bug.cgi?id=1878166
* initrd: merge branch 'ac/cmdline_reader_ipv6_off' into masterAntonio Cardace2020-10-093-3/+58
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/539
| * NEWS: updateac/cmdline_reader_ipv6_offAntonio Cardace2020-10-091-0/+4
| | | | | | | | Signed-off-by: Antonio Cardace <acardace@redhat.com>
| * initrd: disable ipv6 when 'off|none' is set in the 'ip' optionAntonio Cardace2020-10-092-3/+54
|/ | | | | | | | | | | | | | | This is potentially a breaking change, formerly speciyfing 'none|off' in the kernel cmdline option 'ip' was understood by the dracut network-module as doing 'ipv6.method=auto' which is clearly incosistent with the 'off' naming, thus 'off|none' now means to actually disable both ipv6 and ipv4 (unless a static ip is provided). Unit test added. https://bugzilla.redhat.com/show_bug.cgi?id=1883958 Reverts: 440a0b4078c6 ('initrd: set ipv6.method=auto when the autoconfiguration field is 'none'') Signed-off-by: Antonio Cardace <acardace@redhat.com>
* contrib/checkpatch: complain about patch format with "Reverts:" tagThomas Haller2020-10-091-1/+1
|
* device: in NMDeviceVxlan let address_matches ensure the unused address is NULLThomas Haller2020-10-091-1/+4
| | | | | | We should only either set addr4 or addr6, not both. Let address_matches() check that the respective other address is null/unspecified.
* device: cleanup NMDeviceVxlan to use our NMIPAddr helpersThomas Haller2020-10-091-21/+18
|
* device: ensure unique counter for udi placeholder variableThomas Haller2020-10-091-2/+8
| | | | | | | | - use a guint64 variable to avoid wrapping the counter - cache the used ID in NMDevice. This way, the same NMDevice instance will get the same UDI path when it realizes and unrealizes multiple times.
* dns: merge branch 'bg/dns-vpn'Beniamino Galvani2020-10-099-12/+109
|\ | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1863041 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/631
| * dns: change default DNS priority of VPNs to -50Beniamino Galvani2020-10-094-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the default DNS priority of VPNs to -50, to avoid leaking queries out of full-tunnel VPNs. This is a change in behavior. In particular: - when using dns=default (i.e. no split-dns) before this patch both VPN and the local name server were added (in this order) to resolv.conf; the result was that depending on resolv.conf options and resolver implementation, the name servers were tried in a certain manner which does not prevent DNS leaks. With this change, only the VPN name server is added to resolv.conf. - When using a split-dns plugin (systemd-resolved or dnsmasq), before this patch the full-tunnel VPN would get all queries except those ending in a local domain, that would instead be directed to the local server. After this patch, the VPN gets all queries. To revert to the old behavior, set the DNS priority to 50 in the connection profile.
| * dns: add wildcard domain to VPNs with never-default=no and no domainsBeniamino Galvani2020-10-091-2/+19
| | | | | | | | | | | | | | | | | | | | If a VPN has never-default=no but doesn't get a default route (this can happen for example when the server pushes routes with openconnect), and there are no search domains, then the name servers pushed by the server would be unused. It is preferable in this case to use the VPN DNS server for all queries. https://bugzilla.redhat.com/show_bug.cgi?id=1863041
| * core: add never-default field to NMIP{4,6}ConfigBeniamino Galvani2020-10-094-0/+74
| |
| * dns: slightly refactor rebuild_domain_lists()Beniamino Galvani2020-10-091-6/+7
|/ | | | Centralize wildcard domain assignment in a single place.
* cli: fix showing active state for `nmcli con show` with fieldsThomas Haller2020-10-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With "connection.multi-connect", a profile can be activated multiple times on a device with `nmcli connection show`. Also, a profile may be in the process of deactivating on one device, while activating on another one. So, in general it's possible that `nmcli connection show` lists the same profile on multiple lines (reflecting their multiple activation states). If the user requests no fields that are part of the activation state, then the active connections are ignored. For example with `nmcli -f UUID,NAME connection show`. In that case, each profile is listed only once. On the other hand, with `nmcli -g UUID,NAME,DEVICE connection show` the user again requested also to see the activation state, and a profile can appear multiple times. To handle that, we need to consider which fields were requested. There was a bug where the "ACTIVE" field was not treated as part of the activation state. That results in `nmcli -f UUID,NAME,ACTIVE connection show` always returning "no". Fix that. Fixes: a1b25a47b08c ('cli: rework printing of `nmcli connection` for multiple active connections') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/547 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/642
* cli: merge branch 'th/cli-cleanup-set-color'Thomas Haller2020-10-093-137/+184
|\ | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1886336 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/641
| * cli: introduce NmcColorPalette struct instead of plain arrayThomas Haller2020-10-093-48/+84
| | | | | | | | We do have types in C. Use them.
| * cli: refactor resolve_color_alias() to use binary searchThomas Haller2020-10-081-30/+29
| |
| * cli: move string to NMMetaColor conversion to separate functionThomas Haller2020-10-081-59/+61
| | | | | | | | And use NM_UTILS_STRING_TABLE_LOOKUP_DEFINE(), which does a binary search.
| * cli: honor and prefer color schemes with ".scheme" extensionThomas Haller2020-10-081-4/+14
|/ | | | | | | | According to `man terminal-colors.d`, the extension should be ".scheme" and not ".schem". Prefer that, but keep honoring ".schem" file, if it exists. https://bugzilla.redhat.com/show_bug.cgi?id=1886336
* shared: enforce trailing semicolon after NM_UTILS_STRING_TABLE_LOOKUP_DEFINE()Thomas Haller2020-10-081-1/+2
|
* all: use _NM_DUMMY_STRUCT_FOR_TRAILING_SEMICOLON define for trailing semicolonThomas Haller2020-10-082-5/+5
|
* all: add trailing semicolon after NM_UTILS_STRING_TABLE_LOOKUP_DEFINE()Thomas Haller2020-10-082-4/+6
|
* shared: add NM_HASH_OBFUSCATE_PTR_STR() helper macroThomas Haller2020-10-081-0/+8
| | | | | Contrary to NM_HASH_OBFUSCATE_PTR(), this allows to special case a %NULL pointer. Also, it quotes the obfuscated value in square brackets.
* systemd: merge branch systemd into masterThomas Haller2020-10-083-14/+88
|\
| * systemd: update code from upstream (2020-10-08)Thomas Haller2020-10-084-16/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a direct dump from systemd git. ====== SYSTEMD_DIR=../systemd COMMIT=cd2065989163a5b6f71c8f1e4a8d73f1be63a52b ( cd "$SYSTEMD_DIR" git checkout "$COMMIT" git reset --hard git clean -fdx ) git ls-files -z :/src/systemd/src/ \ :/shared/systemd/src/ \ :/shared/nm-std-aux/unaligned.h | \ xargs -0 rm -f nm_copy_sd_shared() { mkdir -p "./shared/systemd/$(dirname "$1")" cp "$SYSTEMD_DIR/$1" "./shared/systemd/$1" } nm_copy_sd_core() { mkdir -p "./src/systemd/$(dirname "$1")" cp "$SYSTEMD_DIR/$1" "./src/systemd/$1" } nm_copy_sd_stdaux() { mkdir -p "./shared/nm-std-aux/" cp "$SYSTEMD_DIR/$1" "./shared/nm-std-aux/${1##*/}" } nm_copy_sd_core "src/libsystemd-network/arp-util.c" nm_copy_sd_core "src/libsystemd-network/arp-util.h" nm_copy_sd_core "src/libsystemd-network/dhcp-identifier.c" nm_copy_sd_core "src/libsystemd-network/dhcp-identifier.h" nm_copy_sd_core "src/libsystemd-network/dhcp-internal.h" nm_copy_sd_core "src/libsystemd-network/dhcp-lease-internal.h" nm_copy_sd_core "src/libsystemd-network/dhcp-network.c" nm_copy_sd_core "src/libsystemd-network/dhcp-option.c" nm_copy_sd_core "src/libsystemd-network/dhcp-packet.c" nm_copy_sd_core "src/libsystemd-network/dhcp-protocol.h" nm_copy_sd_core "src/libsystemd-network/dhcp6-internal.h" nm_copy_sd_core "src/libsystemd-network/dhcp6-lease-internal.h" nm_copy_sd_core "src/libsystemd-network/dhcp6-network.c" nm_copy_sd_core "src/libsystemd-network/dhcp6-option.c" nm_copy_sd_core "src/libsystemd-network/dhcp6-protocol.h" nm_copy_sd_core "src/libsystemd-network/lldp-internal.h" nm_copy_sd_core "src/libsystemd-network/lldp-neighbor.c" nm_copy_sd_core "src/libsystemd-network/lldp-neighbor.h" nm_copy_sd_core "src/libsystemd-network/lldp-network.c" nm_copy_sd_core "src/libsystemd-network/lldp-network.h" nm_copy_sd_core "src/libsystemd-network/network-internal.c" nm_copy_sd_core "src/libsystemd-network/network-internal.h" nm_copy_sd_core "src/libsystemd-network/sd-dhcp-client.c" nm_copy_sd_core "src/libsystemd-network/sd-dhcp-lease.c" nm_copy_sd_core "src/libsystemd-network/sd-dhcp6-client.c" nm_copy_sd_core "src/libsystemd-network/sd-dhcp6-lease.c" nm_copy_sd_core "src/libsystemd-network/sd-ipv4acd.c" nm_copy_sd_core "src/libsystemd-network/sd-ipv4ll.c" nm_copy_sd_core "src/libsystemd-network/sd-lldp.c" nm_copy_sd_core "src/libsystemd/sd-event/event-source.h" nm_copy_sd_core "src/libsystemd/sd-event/event-util.c" nm_copy_sd_core "src/libsystemd/sd-event/event-util.h" nm_copy_sd_core "src/libsystemd/sd-event/sd-event.c" nm_copy_sd_core "src/libsystemd/sd-id128/id128-util.c" nm_copy_sd_core "src/libsystemd/sd-id128/id128-util.h" nm_copy_sd_core "src/libsystemd/sd-id128/sd-id128.c" nm_copy_sd_core "src/systemd/_sd-common.h" nm_copy_sd_core "src/systemd/sd-dhcp-client.h" nm_copy_sd_core "src/systemd/sd-dhcp-lease.h" nm_copy_sd_core "src/systemd/sd-dhcp-option.h" nm_copy_sd_core "src/systemd/sd-dhcp6-client.h" nm_copy_sd_core "src/systemd/sd-dhcp6-lease.h" nm_copy_sd_core "src/systemd/sd-dhcp6-option.h" nm_copy_sd_core "src/systemd/sd-event.h" nm_copy_sd_core "src/systemd/sd-id128.h" nm_copy_sd_core "src/systemd/sd-ipv4acd.h" nm_copy_sd_core "src/systemd/sd-ipv4ll.h" nm_copy_sd_core "src/systemd/sd-lldp.h" nm_copy_sd_core "src/systemd/sd-ndisc.h" nm_copy_sd_shared "src/basic/alloc-util.c" nm_copy_sd_shared "src/basic/alloc-util.h" nm_copy_sd_shared "src/basic/async.h" nm_copy_sd_shared "src/basic/cgroup-util.h" nm_copy_sd_shared "src/basic/env-file.c" nm_copy_sd_shared "src/basic/env-file.h" nm_copy_sd_shared "src/basic/env-util.c" nm_copy_sd_shared "src/basic/env-util.h" nm_copy_sd_shared "src/basic/errno-util.h" nm_copy_sd_shared "src/basic/escape.c" nm_copy_sd_shared "src/basic/escape.h" nm_copy_sd_shared "src/basic/ether-addr-util.c" nm_copy_sd_shared "src/basic/ether-addr-util.h" nm_copy_sd_shared "src/basic/extract-word.c" nm_copy_sd_shared "src/basic/extract-word.h" nm_copy_sd_shared "src/basic/fd-util.c" nm_copy_sd_shared "src/basic/fd-util.h" nm_copy_sd_shared "src/basic/fileio.c" nm_copy_sd_shared "src/basic/fileio.h" nm_copy_sd_shared "src/basic/format-util.c" nm_copy_sd_shared "src/basic/format-util.h" nm_copy_sd_shared "src/basic/fs-util.c" nm_copy_sd_shared "src/basic/fs-util.h" nm_copy_sd_shared "src/basic/hash-funcs.c" nm_copy_sd_shared "src/basic/hash-funcs.h" nm_copy_sd_shared "src/basic/hashmap.c" nm_copy_sd_shared "src/basic/hashmap.h" nm_copy_sd_shared "src/basic/hexdecoct.c" nm_copy_sd_shared "src/basic/hexdecoct.h" nm_copy_sd_shared "src/basic/hostname-util.c" nm_copy_sd_shared "src/basic/hostname-util.h" nm_copy_sd_shared "src/basic/in-addr-util.c" nm_copy_sd_shared "src/basic/in-addr-util.h" nm_copy_sd_shared "src/basic/io-util.c" nm_copy_sd_shared "src/basic/io-util.h" nm_copy_sd_shared "src/basic/list.h" nm_copy_sd_shared "src/basic/log.h" nm_copy_sd_shared "src/basic/macro.h" nm_copy_sd_shared "src/basic/memory-util.c" nm_copy_sd_shared "src/basic/memory-util.h" nm_copy_sd_shared "src/basic/mempool.c" nm_copy_sd_shared "src/basic/mempool.h" nm_copy_sd_shared "src/basic/missing_fcntl.h" nm_copy_sd_shared "src/basic/missing_random.h" nm_copy_sd_shared "src/basic/missing_socket.h" nm_copy_sd_shared "src/basic/missing_stat.h" nm_copy_sd_shared "src/basic/missing_syscall.h" nm_copy_sd_shared "src/basic/missing_type.h" nm_copy_sd_shared "src/basic/parse-util.c" nm_copy_sd_shared "src/basic/parse-util.h" nm_copy_sd_shared "src/basic/path-util.c" nm_copy_sd_shared "src/basic/path-util.h" nm_copy_sd_shared "src/basic/prioq.c" nm_copy_sd_shared "src/basic/prioq.h" nm_copy_sd_shared "src/basic/process-util.c" nm_copy_sd_shared "src/basic/process-util.h" nm_copy_sd_shared "src/basic/random-util.c" nm_copy_sd_shared "src/basic/random-util.h" nm_copy_sd_shared "src/basic/set.h" nm_copy_sd_shared "src/basic/signal-util.c" nm_copy_sd_shared "src/basic/signal-util.h" nm_copy_sd_shared "src/basic/siphash24.h" nm_copy_sd_shared "src/basic/socket-util.c" nm_copy_sd_shared "src/basic/socket-util.h" nm_copy_sd_shared "src/basic/sort-util.h" nm_copy_sd_shared "src/basic/sparse-endian.h" nm_copy_sd_shared "src/basic/stat-util.c" nm_copy_sd_shared "src/basic/stat-util.h" nm_copy_sd_shared "src/basic/stdio-util.h" nm_copy_sd_shared "src/basic/string-table.c" nm_copy_sd_shared "src/basic/string-table.h" nm_copy_sd_shared "src/basic/string-util.c" nm_copy_sd_shared "src/basic/string-util.h" nm_copy_sd_shared "src/basic/strv.c" nm_copy_sd_shared "src/basic/strv.h" nm_copy_sd_shared "src/basic/strxcpyx.c" nm_copy_sd_shared "src/basic/strxcpyx.h" nm_copy_sd_shared "src/basic/time-util.c" nm_copy_sd_shared "src/basic/time-util.h" nm_copy_sd_shared "src/basic/tmpfile-util.c" nm_copy_sd_shared "src/basic/tmpfile-util.h" nm_copy_sd_shared "src/basic/umask-util.h" nm_copy_sd_shared "src/basic/user-util.h" nm_copy_sd_shared "src/basic/utf8.c" nm_copy_sd_shared "src/basic/utf8.h" nm_copy_sd_shared "src/basic/util.c" nm_copy_sd_shared "src/basic/util.h" nm_copy_sd_shared "src/shared/dns-domain.c" nm_copy_sd_shared "src/shared/dns-domain.h" nm_copy_sd_shared "src/shared/web-util.c" nm_copy_sd_shared "src/shared/web-util.h" nm_copy_sd_stdaux "src/basic/unaligned.h"
* | systemd: basic/missing_syscall: fix syscall numbers for mips*Michael Biebl2020-10-081-2/+26
| | | | | | | | | | | | | | | | Thanks Christian Brauner @brauner https://github.com/systemd/systemd/commit/cd2065989163a5b6f71c8f1e4a8d73f1be63a52b https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/545
* | shared/c-rbtree: reimportThomas Haller2020-10-070-0/+0
|\ \ | | | | | | | | | git subtree pull --prefix shared/c-rbtree git@github.com:c-util/c-rbtree.git master --squash
| * | Squashed 'shared/c-rbtree/' changes from 7624b79b26d0..bd1c14dc0d93Thomas Haller2020-10-072-11/+11
| | | | | | | | | | | | | | | | | | | | | bd1c14dc0d93 c-rbtree: reduce alignment constraints git-subtree-dir: shared/c-rbtree git-subtree-split: bd1c14dc0d939edf6186057d4ed7a623e21c5209
* | | c-rbtree: reduce alignment constraintsDavid Rheinsberg2020-10-072-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are some Debian-supported architectures where `max_align_t` is only aligned to 4-bytes. This is unfortunate and breaks our assumptions. While glibc-malloc still guarantees 8 / 16 bytes alignment, this is not necessarily guaranteed by the C standard (and alternative allocators will deviate (see jemalloc, for instance)). Fortunately, we only need 2 flags, so a 4-byte alignment is more than enough. Reported-by: Thomas Haller Signed-off-by: David Rheinsberg <david.rheinsberg@gmail.com> https://github.com/c-util/c-rbtree/pull/4
* | | platform/tests: skip test_platform_ip_address_pretty_sort_cmp() on non-amd64 ↵Thomas Haller2020-10-071-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | archs The test only works on amd64, because it relies on the memory layout of the structures. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/546
* | | platform/tests: print details about test failure for ↵Thomas Haller2020-10-071-0/+13
| | | | | | | | | | | | | | | | | | | | | test_platform_ip_address_pretty_sort_cmp() When the test is about to fail, print the wrong data to help debugging the test failure.
* | | platform/tests: adjust regeneration of test code for ↵Thomas Haller2020-10-071-4/+6
| | | | | | | | | | | | | | | | | | | | | test_platform_ip_address_pretty_sort_cmp() Since re-formatting our source code, the generated output no longer matched the required formatting. Adjust it.
* | | platform: use also statvfs() to check for udevdAlfonso Sánchez-Beato2020-10-061-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check whether or not there is a running udevd by using statvfs() on "/sys" and use access() as a fallback. This is in line with what is done by systemd [1] and helps in case NM is not really running in a container but has been confined by a MAC so it does not have full access to sysfs (access() returns EACCES). [1] https://github.com/systemd/systemd/blob/v246/src/basic/stat-util.c#L132 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/639
* | | tests: adjust timeouts for test nm_utils_kill_child()Thomas Haller2020-10-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test spawns processes and tries to kill them, with timeouts and retry. That is inherently racy, and it's hard to deterministically test the interesting cases, without having unstable tests. Try to adjust the timeout, to make it more stable: 14:02:27 /builds/NetworkManager/NetworkManager/tools/run-nm-test.sh --called-from-make /builds/NetworkManager/NetworkManager/build --launch-dbus=auto /builds/NetworkManager/NetworkManager/build/src/tests/test-core-with-expect --- stdout --- # random seed: R02S7748fae8fc946b7a755b72efb5815250 1..5 # Start of general tests ok 1 /general/nm_utils_monotonic_timestamp_as_boottime # NetworkManager-DEBUG: <debug> [1601992953.4091] kill child process 'test-s-1-3' (18615): sending SIGKILL... # NetworkManager-DEBUG: <debug> [1601992953.4242] kill child process 'test-s-1-3' (18615): waiting for process to terminate after sending no signal (0) and SIGKILL... # NetworkManager-DEBUG: <debug> [1601992953.4257] kill child process 'test-s-1-3' (18615): after sending no signal (0) and SIGKILL, process 18615 exited by signal 9 (20807 usec elapsed) Bail out! GLib:ERROR:../src/tests/test-core-with-expect.c:154:test_nm_utils_kill_child_sync_do: Did not see expected message NetworkManager-DEBUG: *<debug> [*] kill child process 'test-s-1-3' (*): waiting up to 1 milliseconds for process to terminate normally after sending no signal (0)... Bail out! test:ERROR:../src/tests/test-core-with-expect.c:457:test_nm_utils_kill_child: assertion failed (exit_status == 0): (6 == 0) --- stderr --- ** GLib:ERROR:../src/tests/test-core-with-expect.c:154:test_nm_utils_kill_child_sync_do: Did not see expected message NetworkManager-DEBUG: *<debug> [*] kill child process 'test-s-1-3' (*): waiting up to 1 milliseconds for process to terminate normally after sending no signal (0)... ** test:ERROR:../src/tests/test-core-with-expect.c:457:test_nm_utils_kill_child: assertion failed (exit_status == 0): (6 == 0) /builds/NetworkManager/NetworkManager/tools/run-nm-test.sh: line 279: 18325 Aborted "${NMTST_DBUS_RUN_SESSION[@]}" "${NMTST_LIBTOOL[@]}" "$NMTST_VALGRIND" --quiet --error-exitcode=$VALGRIND_ERROR --leak-check=full --gen-suppressions=all "${NMTST_SUPPRESSIONS[@]}" --num-callers=100 --log-file="$LOGFILE" "$TEST" "$@"
* | | CONTRIBUTING: add comments about our clang-format and various adjustments of ↵Thomas Haller2020-10-061-14/+33
| | | | | | | | | | | | markdown
* | | build/release: before release check that all gitlab-ci tests ran successfullyThomas Haller2020-10-061-1/+37
| | |
* | | wifi/iwd: merge branch 'balrog-kun:iwd-fixes'Thomas Haller2020-10-062-43/+53
|\ \ \ | | | | | | | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/640
| * | | iwd: Subscribe to object-added/removed ObjectManager signalsAndrew Zaborowski2020-10-061-17/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GDBusObjectManagerClient's interface-added and interface-removed signals are not emitted when the new interfaces are added to a completely new object or the removal results in the object disappearing. In other words one interface is never reported both through interface-added and object-added (or -removed) signals. This kind of makes sense but isn't documented explicitly so interface-added seemed to correspond to DBus InterfacesAdded signals which it doesn't. We need to watch for both kinds of signals and although most things work without us receiving the signals at all, it causes some race conditions. For example on hotplug, devices wouldn't transition to "disconnected" if a device was discovered by NMManager before it appeared on IWD's dbus interface because that scenario relied on the dbus signal.
| * | | iwd: Disable periodic scanning when connectedAndrew Zaborowski2020-10-061-15/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The automatic scanning every 20 seconds while connected has been annoying users because of the extra connection latency, drop it. The UIs are supposed to be requesting scans whenever an AP list update is needed (?).
| * | | iwd: Disconnect signals in NMDeviceIwd's disposeAndrew Zaborowski2020-10-061-11/+1
|/ / / | | | | | | | | | | | | | | | | | | Fix a crash on device unplugging caused by keeping our signal handlers for GDBusProxies connected after a call to dispose(). Do this by replacing most cleanup steps by a nm_device_iwd_set_dbus_object(self, NULL) call which is more meticulous.
* | | build: fix "create-exports-NetworkManager.sh" to fail if "nm" failsThomas Haller2020-10-061-4/+7
| | | | | | | | | | | | | | | | | | | | | Despite `set -e`, the shell script does not fail if the command in the here document fails. This can happen if binutils' "nm" fails. NM=/bin/false "./tools/create-exports-NetworkManager.sh" --called-from-build "."
* | | NEWS: updateThomas Haller2020-10-061-3/+8
| | |
* | | build/travis: remove travis integrationThomas Haller2020-10-052-87/+0
| | | | | | | | | | | | | | | | | | | | | We already build a large variety of configurations in gitlab-ci, we don't need yet another configuration to run tests on travis-ci. Also, because the travis-ci setup is outdated and we don't look at it. Let's focus on gitlab-ci instead.
* | | systemd: workaround compilation failures against old glibcThomas Haller2020-10-052-0/+6
| | | | | | | | | | | | | | | | | | Building against older libc/kernel headers can fail, because our glue code for systemd has issues. Fix them by forward declaring "struct statx" and by disabling parts of "socket-util.c".
* | | contrib/release: restore original branch in dry-run modeThomas Haller2020-10-051-1/+7
| | | | | | | | | | | | | | | | | | | | | In dry-run mode, reset the branch to the state where it was before. Also, in real mode delete the temporary "release-branch" branch on success.