summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fixup! ifcfg-rh: handle DEVTIMEOUT property (rh #1171917)danw/devtimeout-rh1171917Dan Winship2015-01-082-2/+5
|
* fixup! core: allow connections to participate in NMManager:startup-completeDan Winship2015-01-081-1/+1
|
* ifcfg-rh: handle DEVTIMEOUT property (rh #1171917)Dan Winship2015-01-083-1/+131
| | | | | | | | | | If an ifcfg file has a DEVTIMEOUT property (and a DEVICE, and is ONBOOT=yes), and the device is not present at startup, then wait up to DEVTIMEOUT seconds for it to appear before declaring the connection ready. This allows for a hacky workaround to devices that take a bizarrely long time to be probed.
* core: allow connections to participate in NMManager:startup-completeDan Winship2015-01-085-4/+118
| | | | | | | Add an NMSettingsConnection:ready property, which indicates if the connection is ready to use. Add NMSettings:startup-complete, which is TRUE when all connections are ready. Make NMManager:startup-complete take NMSettings:startup-complete into account.
* libnm: fix documentation for nm_utils_file_search_in_paths()Thomas Haller2015-01-082-2/+2
|
* core: add /bin to the default search pathThomas Haller2015-01-081-0/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=742576
* build: fix --enable-lto configure option to allow disabling option explicitlyThomas Haller2015-01-081-2/+3
| | | | | | | | | | When specifying '--enable-lto=anything' or '--disable-lto', the configure script would always set enable_lto=yes. The only way to disable lto, was *not* specifying the configure option. https://bugzilla.gnome.org/show_bug.cgi?id=742575
* tests: check for no pending expected_messages on exit of testsThomas Haller2015-01-071-7/+8
| | | | | | | | | On the end of the test there should be no unchecked expected messages. Register a destructor function in nmtst to assert against that. Also call nmtst_free() in the destructor. That way, we always release the allocated data without requiring the test to do it explicitly.
* tui: fix crash when editing DSL connectionJiří Klimeš2015-01-071-0/+2
| | | | | | | | | | | | | | | | | | | | | Program received signal SIGSEGV, Segmentation fault. 0x000000000041b3e5 in nmt_page_dsl_constructed (object=0x7fffec0228c0 [NmtPageDsl]) at nmt-page-dsl.c:109 109 priv->ethernet_page = nmt_page_ethernet_new (conn, nmt_editor_page_device_get_device_entry (NMT_EDITOR_PAGE_DEVICE (dsl))); Missing separate debuginfos, use: debuginfo-install libffi-3.0.10-3.fc18.x86_64 newt-0.52.15-1.fc19.x86_64 (gdb) bt #0 0x000000000041b3e5 in nmt_page_dsl_constructed (object=0x7fffec0228c0 [NmtPageDsl]) at nmt-page-dsl.c:109 #1 0x0000003e9ac161e3 in g_object_newv (object_type=1, object_type@entry=16203872, n_parameters=n_parameters@entry=2, parameters=parameters@entry=0xf74350) at gobject.c:1741 #2 0x0000003e9ac16560 in g_object_new_valist (object_type=object_type@entry=16203872, first_property_name=first_property_name@entry=0x42e524 "connection", var_args=var_args@entry=0x7fffffffcef8) at gobject.c:1830 #3 0x0000003e9ac16894 in g_object_new (object_type=16203872, first_property_name=first_property_name@entry=0x42e524 "connection") at gobject.c:1545 #4 0x000000000041b504 in nmt_page_dsl_new (conn=<optimized out>, deventry=deventry@entry=0x974690 [NmtDeviceEntry]) at nmt-page-dsl.c:47 #5 0x000000000041808e in nmt_editor_constructed (object=<optimized out>) at nmt-editor.c:355 #6 0x0000003e9ac161e3 in g_object_newv (object_type=1, object_type@entry=16174256, n_parameters=n_parameters@entry=4, parameters=parameters@entry=0xf6cec0) at gobject.c:1741 ... (gdb) p priv $1 = (NmtPageDslPrivate *) 0x0
* ifcfg: refactor utils_get_ifcfg_name()Thomas Haller2015-01-071-21/+26
| | | | | | | | | | No need to allocate a temporary "base" variable. Just search for the last '/' ourselves. All the special handling that g_path_get_basename() does, for example handling empty filenames and removing trailing slashes, is not needed. Thereby fix not to return empty names such as from "ifcfg-".
* tui: fix saving "Available to all users" (rh #1176042)Jiří Klimeš2015-01-071-1/+1
|
* Revert "ifcfg-rh: avoid passing NULL error to connection_from_file_full()"Thomas Haller2015-01-061-8/+3
| | | | | | | | | This reverts commit 35988ec633bc7dc9a4f85b17b5a59f62645e0f7d. Since commit ffe0fde235aed7cf6341843adc1488995f8cc346, wireless_connection_from_ifcfg() accepts a missing @error argument. Revert this commit because the caller then can control whether to log the error by providing @error.
* session: prefer new configure optionsPavel Šimerda2015-01-061-11/+13
| | | | | | | | The main motivation for this change is to be able to build configure command lines that will work for both old and new versions of NetworkManager. Acked-By: Thomas Haller <thaller@redhat.com>
* build: fix compilation with GLib 2.32Jiří Klimeš2015-01-061-0/+1
| | | | for g_clear_pointer()
* libnm-glib: crash when NMRemoteSettings is quickly destroyed (bgo #742138)Dan Winship2015-01-051-1/+3
| | | | | | | | NMRemoteSettings queues a bunch of async NMRemoteConnection creations, but wasn't doing anything to ensure that it was still alive when they completed. Pointed out by Cosimo Cecchi. https://bugzilla.gnome.org/show_bug.cgi?id=742138
* session: merge nm-session-monitor-* modulesPavel Šimerda2015-01-057-1000/+362
| | | | | | | | | | | | | | Merged all session tracking modules into one source file and simplified it substantially. Now systemd-logind and ConsoleKit support can be built in at the same time and both are detected at runtime. This is useful on source based as well as binary distributions. Original patch written by Fabio Erculiani <lxnay@sabayon.org>, modified by Pavel Šimerda <psimerda@redhat.com> and Thomas Haller <thaller@redhat.com>. https://bugzilla.gnome.org/show_bug.cgi?id=686997 Acked-By: Thomas Haller <thaller@redhat.com>
* main: don't initialize the session monitorPavel Šimerda2015-01-051-5/+0
| | | | | | The session monitor will be initialized as soon as it's needed. Acked-By: Thomas Haller <thaller@redhat.com>
* session: switch code to nm_session_monitor_{,dis}connect()Pavel Šimerda2015-01-053-8/+37
| | | | Acked-By: Thomas Haller <thaller@redhat.com>
* auth: remove session monitor argumentPavel Šimerda2015-01-056-13/+1
| | | | | | | There's no need to call `nm_session_monitor_get()` individually for each call to `nm_auth_is_subject_in_acl()`. Acked-By: Thomas Haller <thaller@redhat.com>
* session: switch code to nm_session_monitor_session_exists()Pavel Šimerda2015-01-055-29/+43
| | | | Acked-By: Thomas Haller <thaller@redhat.com>
* session: merge nm-session-utils into nm-session-managerPavel Šimerda2015-01-057-70/+42
| | | | Acked-By: Thomas Haller <thaller@redhat.com>
* consolekit: fix memory leak on errorPavel Šimerda2015-01-051-1/+1
| | | | Acked-By: Thomas Haller <thaller@redhat.com>
* libnm/tests: fix GetAccessPoints() in test-networkmanager-service.py for ↵Thomas Haller2015-01-051-5/+1
| | | | | | | hidden APs There was a bug checking for "if a.ssid():". Refactor the whole line to use a list comprehension.
* libnm/tests: cleanup handling object paths in test-networkmanager-service.pyThomas Haller2015-01-051-9/+9
|
* libnm/tests: fix handling ByteArray in test-networkmanager-service.py for ↵Thomas Haller2015-01-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | Python 3 In Python 3, dbus.ByteArray() must be created using a byte string, while strings obtained via DBUS are unicode strings. This was wrong in WifiAp.__get_props() which broke the test test_wifi_ap_added_removed(). File "/usr/lib/python3.3/site-packages/dbus/service.py", line 707, in _message_cb retval = candidate_method(self, *args, **keywords) File "./NetworkManager/tools/test-networkmanager-service.py", line 102, in GetAll return self._get_dbus_properties(iface) File "./NetworkManager/tools/test-networkmanager-service.py", line 96, in _get_dbus_properties return self.__dbus_ifaces[iface]() File "./NetworkManager/tools/test-networkmanager-service.py", line 315, in __get_props props[PP_SSID] = dbus.ByteArray(self.ssid) TypeError: string argument without an encoding https://bugzilla.gnome.org/show_bug.cgi?id=739448
* docs: fix out-of-tree buildYou-Sheng Yang2015-01-032-1/+4
| | | | | | | | | | | When compiling NetworkManager with --enable-gtk-doc outside the source tree, the generated documents are slightly different from those generated in tree. This patch fixes that missed COPYING file in $(top_builddir) and adds $(top_builddir)/libnm-util to DOC_SOURCE_DIR. https://bugzilla.gnome.org/show_bug.cgi?id=742139 Signed-off-by: You-Sheng Yang <vicamo@gmail.com>
* ifcfg-rh: refactor g_return statements in reader.cThomas Haller2015-01-021-12/+6
|
* ifcfg-rh: fix wireless_connection_from_ifcfg() to accept missing @error argumentThomas Haller2015-01-021-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | wireless_connection_from_ifcfg() did not support being called without error argument. #0 0x00007fe4fa2204e9 in g_logv (log_domain=0x7fe4f0597060 "NetworkManager-ifcfg-rh", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fff1c7aaf00) at gmessages.c:989 #1 0x00007fe4fa22063f in g_log (log_domain=<optimized out>, log_level=<optimized out>, format=<optimized out>) at gmessages.c:1025 #2 0x00007fe4f057eec3 in wireless_connection_from_ifcfg (file=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", ifcfg=0x7fe4fec6f730, error=0x0) at reader.c:3431 #3 0x00007fe4f057e2b6 in connection_from_file_full (filename=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", network_file=0x7fe4f05976aa "/etc/sysconfig/network", test_type=0x0, out_unhandled=0x7fff1c7ab1f8, error=0x0, out_ignore_error=0x7fff1c7ab174) at reader.c:4750 #4 0x00007fe4f057db80 in connection_from_file (filename=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", out_unhandled=0x7fff1c7ab1f8, error=0x0) at reader.c:4834 #5 0x00007fe4f057b4a6 in nm_ifcfg_connection_new (source=0x0, full_path=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", error=0x0) at nm-ifcfg-connection.c:119 #6 0x00007fe4f0579c1d in _internal_new_connection (self=0x7fe4fec6cd00, path=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", source=0x0, error=0x0) at plugin.c:136 #7 0x00007fe4f0579256 in connection_new_or_changed (self=0x7fe4fec6cd00, path=0x7fe4fec7c800 "/etc/sysconfig/network-scripts/ifcfg-Wi-Fi-1", existing=0x0, out_old_path=0x7fff1c7ab458) at plugin.c:265 #8 0x00007fe4f0578f61 in read_connections (plugin=0x7fe4fec6cd00) at plugin.c:462 #9 0x00007fe4f0578839 in get_connections (config=0x7fe4fec6cd00) at plugin.c:497 #10 0x00007fe4fdc9affb in nm_system_config_interface_get_connections (config=0x7fe4fec6cd00) at settings/nm-system-config-interface.c:143 #11 0x00007fe4fdc9764f in load_connections (self=0x7fe4fec6ca40) at settings/nm-settings.c:201 #12 0x00007fe4fdc96d74 in nm_settings_new (error=0x7fff1c7abb18) at settings/nm-settings.c:1802 #13 0x00007fe4fdc37146 in main (argc=1, argv=0x7fff1c7abcd8) at main.c:415 Fixes: 356849f70c72f920d1600ab98611f9f7ed10214c Fixes: 12bfaf5a8da788ae5ed50c0c93c203250a6ecf8b
* ifcfg-rh: avoid passing NULL error to connection_from_file_full()Lubomir Rintel2015-01-021-3/+8
| | | | | | | | It causes an assertion failure: (NetworkManager:20800): NetworkManager-ifcfg-rh-CRITICAL **: wireless_connection_from_ifcfg: assertion 'error != NULL' failed Fixes: 12bfaf5a8da788ae5ed50c0c93c203250a6ecf8b
* libnm: make NMDhcp6Config inherit from NMDhcpConfigLubomir Rintel2015-01-021-1/+1
| | | | | | | | | | | Otherwise it does not register the "options" property and an assertion fails when the user prints connection that has DHCPv6 options: $ LIBNM_GLIB_DEBUG=properties-changed nmcli c show yolo ... libnm-Message: Property 'options' unhandled. ... (process:13522): libnm-CRITICAL **: nm_dhcp_config_get_options: assertion 'NM_IS_DHCP_CONFIG (config)' failed
* dns-manager: don't replace /etc/resolv.conf installed by other toolsPavel Šimerda2014-12-231-0/+35
| | | | | | | | | | Resolves: * https://bugzilla.gnome.org/show_bug.cgi?id=732941 * https://bugzilla.redhat.com/show_bug.cgi?id=1116999 Acked-By: Dan Williams <dcbw@redhat.com> Acked-By: Thomas Haller <thaller@redhat.com>
* dns-manager: make /etc/resolv.conf a symlink to ↵Pavel Šimerda2014-12-231-54/+57
| | | | | | | | | | | | /run/NetworkManager/resolv.conf.default Related: * https://bugzilla.gnome.org/show_bug.cgi?id=732941 * https://bugzilla.redhat.com/show_bug.cgi?id=1116999 Acked-By: Thomas Haller <thaller@redhat.com> Acked-By: Dan Williams <dcbw@redhat.com>
* contrib: fix team sub-package obsoletesDan Williams2014-12-221-0/+2
| | | | | | | | Team was split out between NM 0.9.10 and NM 1.0 after the other sub-packages, so the existing obsoletes won't work for it (they would cause all upgrades to install all sub-packages, instead of replacing existing sub-packages without adding uninstalled ones). We only want to unconditionally add the team sub-package.
* nmcli/bash-completion: don't allow specifying connection by apath for ↵Thomas Haller2014-12-221-1/+1
| | | | | | | | 'connection modify' The following must not be allowed: $ nmcli connection modify apath /org/freedesktop/NetworkManager/ActiveConnection/0
* nmcli/bash-completion: fix detecting connection for connection modifyThomas Haller2014-12-221-2/+2
| | | | | | | | | | Previously we would only complete connections given by ID. The following would work: $ nmcli connection modify id <ID> <TAB> $ nmcli connection modify <ID> <TAB> $ nmcli connection modify uuid <UUID> <TAB> but the following would not work: $ nmcli connection modify <UUID> <TAB>
* po: update Polish (pl) translation (bgo #741839)Piotr Drąg2014-12-211-2280/+3422
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=741839
* po: fix broken Telugu (te) and Turkish (tr) translationsPiotr Drąg2014-12-212-4/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=741838
* core: fix re-activation of connections on EXTERNAL_DOWN interfaces (bgo #741742)Dan Williams2014-12-191-29/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When userspace IPv6LL capability is compiled into NetworkManager, during deactivation NM will toggle userspace IPv6LL in some cases. This causes link change events in the platform, which show up in nm-device.c::device_link_changed(). When an EXTERNAL_DOWN interface was activated, the EXTERNAL_DOWN flag was never cleared even if the device was set IFF_UP or if a connection was activated via D-Bus (which explicitly sets the device up). Second, the device_link_changed() code changed device state whether or not IFF_UP had actually changed, it simply looked at the current value. Together, this caused the first activation of an EXTERNAL_DOWN device to succeed, but the EXTERNAL_DOWN flag was never cleared even though the activation set the device IFF_UP. When a second activation request came in, the device was moved to DISCONNECTED state and IPv6LL genmode was reset, causing device_link_changed() to run. Since the device had EXTERNAL_DOWN and IFF_UP were still set, nm_device_set_unmanaged_flag() code was triggered to clear EXTERNAL_DOWN, which resulted in a state transition to UNAVAILABLE with a reason of CONNECTION_ASSUMED. This caused the second activation request to fail because UNAVAILABLE devices cannot activate connections by definition. The fix has three parts: 1) Only change EXTERNAL_DOWN if IFF_UP actually changes, to prevent spurious changes when something other than IFF_UP changes 2) Only clear EXTERNAL_DOWN when IFF_UP changes while the device is UNMANAGED, since any state higher than UNMANAGED implies that either an activation request was received (and thus the device should be managed) or IFF_UP was set 3) Clear EXTERNAL_DOWN (without triggering state changes) when any state higher than UNAVAILABLE is entered, since this implies that a connection is activating or the device is no longer IFF_UP fixes:NetworkManager_Test108_testcase_303655 https://bugzilla.gnome.org/show_bug.cgi?id=741742
* contrib/fedora: add file REQUIRED_PACKAGES listing fedora packages for ↵Thomas Haller2014-12-191-0/+45
| | | | development
* build: fix check-exports.sh for ppc64 archThomas Haller2014-12-191-1/+1
| | | | | | | | On ppc64, `nm` reports the exported symbols as 'D' instead of 'T'. This caused `make check` to fail. "D" The symbol is in the initialized data section. "T" The symbol is in the text (code) section.
* libnm/tests: make tested IPv4 addresses non-palindromicThomas Haller2014-12-191-16/+16
| | | | | | For IPv4 addresses, the binary representation is in network-order, contrary to host-order. It's better to choose addresses for testing that are differently on big and little endian systems.
* libnm/tests: fix build failure on big-endian machinesThomas Haller2014-12-191-2/+4
| | | | | | | | | | | | `make check` fails: make check-TESTS make[4]: Entering directory `/builddir/build/BUILD/NetworkManager-1.1.0/libnm-core/tests' ... /core/general/test_setting_802_1x_changed_signal: OK /core/general/test_setting_ip4_gateway: ** ERROR:test-general.c:3652:test_setting_ip4_gateway: assertion failed (nm_setting_ip_config_get_gateway (s_ip4) == "192.168.1.1"): ("1.1.168.192" == "192.168.1.1") /bin/sh: line 5: 44957 Aborted (core dumped) ${dir}$tst
* contrib/rpm: exclude device plugins for ADSL and Wi-Fi on s390Thomas Haller2014-12-191-0/+4
| | | | | | | | | | | | | | | | | | s390 does not enable several device plugins, but ADSL and Wi-Fi plugins are still build. They must be excluded in the spec file, otherwise rpmbuild fails. This partly reverts commit 1f631cd08d0f01cd118e7222822518d62916f117. Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/NetworkManager-1.1.0-11242.9709d009d5.el7.s390x RPM build errors: error: Installed (but unpackaged) file(s) found: /usr/lib64/NetworkManager/libnm-device-plugin-adsl.so /usr/lib64/NetworkManager/libnm-device-plugin-wifi.so Installed (but unpackaged) file(s) found: /usr/lib64/NetworkManager/libnm-device-plugin-adsl.so /usr/lib64/NetworkManager/libnm-device-plugin-wifi.so Child returncode was: 1
* contrib/rpm: fix spec file for s390/s390xThomas Haller2014-12-191-2/+6
| | | | | | | | | On s390/s390x we would disable hardware plugins, especially %{with_bluetooth} and %{with_wwan}. Depending on that we would set 'BuildRequires: ModemManager-glib-devel'. This was not corresponding to the '--with-modem-manager-1' configure option, hence we did not have ModemManager-glib-devel, but '--with-modem-manager-1=yes'
* contrib/rpm: fix --srpm option of build_clean.shThomas Haller2014-12-191-0/+2
| | | | | Forgot to export the $BUILDTYPE variable. Hence --srpm did not work.
* po: update Tamil (ta) translation (bgo #741752)Shantha kumar2014-12-191-1909/+3178
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=741752
* po: update Turkish (tr) translation (bgo #741737)Necdet Yücel2014-12-191-1491/+6954
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=741737
* libnm-util, libnm-glib: bump sonames for 1.0Dan Winship2014-12-182-2/+2
| | | | libnm-util.so.2.7.0, libnm-glib.so.4.9.0
* docs: misc small fixesDan Winship2014-12-1816-81/+114
| | | | Cleans up all of the warnings that aren't overly annoying to clean up.
* release: update NEWSDan Williams2014-12-181-0/+2
|
View Lorry Controller Status