summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fixup! dhcp: add systemd-based "internal" DHCP clientdcbw/dhcp-systemdDan Williams2014-11-062-25/+35
|
* dhcp: add systemd-based "internal" DHCP clientDan Williams2014-11-065-3/+926
| | | | | | | | | We must also remove -Waggregate-return from m4/compiler-warnings.m4 because systemd uses aggregate return (correctly) in a couple cases, and we cannot keep single-level makefiles and override aggregate-return only for the systemd sub-library. This client currently only supports DHCPv4 because the base systemd code does not yet fully support DHCPv6.
* dhcp: add nm_dhcp_utils_client_id_string_to_bytes()Dan Williams2014-11-064-6/+110
| | | | | Generic function to convert a DHCP client identifier string in either hex form ("aa:bb:cc") or string form ("blahblah") to bytes.
* dhcp: systemd DHCP code changes necessary for NM integrationDan Williams2014-11-062-29/+18
| | | | Random functionality that's necessary for our use of the library.
* fixup! dhcp: make systemd DHCP code into a libraryDan Williams2014-11-061-5/+6
|
* dhcp: make systemd DHCP code into a libraryDan Williams2014-11-0623-0/+433
| | | | | | | | | | | | | The systemd code was modified to add "#if 0 /* NM_IGNORED */" around lines that cause problems for compilation or code that is not actually used in the library. An adaptation layer (nm-sd-adapt) was added for glue between systemd functions and NetworkManager, but changes to the actual systemd code have been kept to a minimum. The sd_event/sd_event_source functions of systemd have been re-implemented on top of the GLib main loop.
* dhcp: fix compiler warning in IN_SET macroThomas Haller2014-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clang warns: dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-client.c:120:24: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier] assert_return (IN_SET(client->state, DHCP_STATE_INIT, ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:376:17: note: expanded from macro 'IN_SET' const typeof(_y) _x = (x); \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:238:34: note: expanded from macro 'assert_return' if (_unlikely_(!(expr))) { \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:42:44: note: expanded from macro '_unlikely_' #define _unlikely_(x) (__builtin_expect(!!(x),0)) ^ dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-client.c:120:24: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier] ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:379:47: note: expanded from macro 'IN_SET' for (_i = 0; _i < 1 + sizeof((const typeof(_x)[]) { __VA_ARGS__ })/sizeof(const typeof(_x)); _i++) \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:238:34: note: expanded from macro 'assert_return' if (_unlikely_(!(expr))) { \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:42:44: note: expanded from macro '_unlikely_' #define _unlikely_(x) (__builtin_expect(!!(x),0)) ^ dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-client.c:120:24: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier] ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:379:91: note: expanded from macro 'IN_SET' for (_i = 0; _i < 1 + sizeof((const typeof(_x)[]) { __VA_ARGS__ })/sizeof(const typeof(_x)); _i++) \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:238:34: note: expanded from macro 'assert_return' if (_unlikely_(!(expr))) { \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:42:44: note: expanded from macro '_unlikely_' #define _unlikely_(x) (__builtin_expect(!!(x),0)) ^ dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-client.c:120:24: error: duplicate 'const' declaration specifier [-Werror,-Wduplicate-decl-specifier] ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:380:31: note: expanded from macro 'IN_SET' if (((const typeof(_x)[]) { _y, __VA_ARGS__ })[_i] == _x) { \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:238:34: note: expanded from macro 'assert_return' if (_unlikely_(!(expr))) { \ ^ ../src/dhcp-manager/systemd-dhcp/src/shared/macro.h:42:44: note: expanded from macro '_unlikely_' #define _unlikely_(x) (__builtin_expect(!!(x),0)) ^ Signed-off-by: Thomas Haller <thaller@redhat.com>
* sd-dhcp-client: fix REBOOT state handlingDan Williams2014-11-061-18/+15
| | | | | | | | | | | | | client->secs wasn't getting set in the REBOOT state, causing an assertion. REBOOT should work the same way as INIT, per RFC 2131: secs 2 Filled in by client, seconds elapsed since client began address acquisition or renewal process. REBOOT is necessary because many DHCP servers (especially on home routers) do not hand back the same IP address when in response to a DISCOVER packet, even if the same client ID is used.
* sd-dhcp-client: clean up raw socket sd_event_source when creating UDP sourceDan Williams2014-11-061-0/+3
| | | | | | | The raw socket sd_event_source used for DHCP server solicitations was simply dropped on the floor when creating the new UDP socket after a lease has been acquired. Clean it up properly so we're not still listening and responding to events on it.
* sd-dhcp-lease: expose load/save functionsDan Williams2014-11-063-5/+5
| | | | They're useful outside of networkd itself.
* sd-dhcp-lease: load/save client IDDan Williams2014-11-064-1/+80
| | | | | The lease is intimately tied to the client ID in use, so when loading and renewing a lease, the same client ID should be used.
* sd-dhcp-client: support custom client IDsDan Williams2014-11-062-12/+105
| | | | | | | Non-ethernet interface types use different client identifier formats, plus when doing DHCPv4 and DHCPv6 on the same interface, the client identifier should be related per RFC 4361. Thus let the caller override the existing MAC-based client identifier if necessary.
* sd-dhcp6-client: fix off-by-two error in DUID lengthDan Williams2014-11-061-5/+5
| | | | | The duid data passed by the client does not include the DUID type, but client->duid_len does account for the size of the DUID type.
* dhcp: add systemd DHCP codeDan Williams2014-11-0644-0/+19423
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a direct dump from systemd git on 2014-10-28, git commit c4ac990007. Only relevant files were included. SYSTEMD_DIR=../systemd COMMIT=c4ac990007cd0069bb7e76ec15dd731320f382fd mkdir -p ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/ mkdir -p ./src/dhcp-manager/systemd-dhcp/src/shared/ mkdir -p ./src/dhcp-manager/systemd-dhcp/src/systemd/ ( cd "$SYSTEMD_DIR" git checkout "$COMMIT" git clean -fdx ) /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-internal.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-internal.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-lease-internal.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-lease-internal.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-network.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-network.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-option.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-option.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-packet.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-packet.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp-protocol.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp-protocol.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp6-internal.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp6-internal.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp6-lease-internal.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp6-lease-internal.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp6-network.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp6-network.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp6-option.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp6-option.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/dhcp6-protocol.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/dhcp6-protocol.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/network-internal.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/network-internal.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/network-internal.h ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/network-internal.h /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/sd-dhcp-client.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-client.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/sd-dhcp-lease.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp-lease.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/sd-dhcp6-client.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp6-client.c /bin/cp "$SYSTEMD_DIR"/src/libsystemd-network/sd-dhcp6-lease.c ./src/dhcp-manager/systemd-dhcp/src/libsystemd-network/sd-dhcp6-lease.c /bin/cp "$SYSTEMD_DIR"/src/shared/async.h ./src/dhcp-manager/systemd-dhcp/src/shared/async.h /bin/cp "$SYSTEMD_DIR"/src/shared/fileio.c ./src/dhcp-manager/systemd-dhcp/src/shared/fileio.c /bin/cp "$SYSTEMD_DIR"/src/shared/fileio.h ./src/dhcp-manager/systemd-dhcp/src/shared/fileio.h /bin/cp "$SYSTEMD_DIR"/src/shared/list.h ./src/dhcp-manager/systemd-dhcp/src/shared/list.h /bin/cp "$SYSTEMD_DIR"/src/shared/macro.h ./src/dhcp-manager/systemd-dhcp/src/shared/macro.h /bin/cp "$SYSTEMD_DIR"/src/shared/refcnt.h ./src/dhcp-manager/systemd-dhcp/src/shared/refcnt.h /bin/cp "$SYSTEMD_DIR"/src/shared/siphash24.c ./src/dhcp-manager/systemd-dhcp/src/shared/siphash24.c /bin/cp "$SYSTEMD_DIR"/src/shared/siphash24.h ./src/dhcp-manager/systemd-dhcp/src/shared/siphash24.h /bin/cp "$SYSTEMD_DIR"/src/shared/socket-util.h ./src/dhcp-manager/systemd-dhcp/src/shared/socket-util.h /bin/cp "$SYSTEMD_DIR"/src/shared/sparse-endian.h ./src/dhcp-manager/systemd-dhcp/src/shared/sparse-endian.h /bin/cp "$SYSTEMD_DIR"/src/shared/strv.c ./src/dhcp-manager/systemd-dhcp/src/shared/strv.c /bin/cp "$SYSTEMD_DIR"/src/shared/strv.h ./src/dhcp-manager/systemd-dhcp/src/shared/strv.h /bin/cp "$SYSTEMD_DIR"/src/shared/time-util.c ./src/dhcp-manager/systemd-dhcp/src/shared/time-util.c /bin/cp "$SYSTEMD_DIR"/src/shared/time-util.h ./src/dhcp-manager/systemd-dhcp/src/shared/time-util.h /bin/cp "$SYSTEMD_DIR"/src/shared/utf8.c ./src/dhcp-manager/systemd-dhcp/src/shared/utf8.c /bin/cp "$SYSTEMD_DIR"/src/shared/utf8.h ./src/dhcp-manager/systemd-dhcp/src/shared/utf8.h /bin/cp "$SYSTEMD_DIR"/src/shared/util.c ./src/dhcp-manager/systemd-dhcp/src/shared/util.c /bin/cp "$SYSTEMD_DIR"/src/shared/util.h ./src/dhcp-manager/systemd-dhcp/src/shared/util.h /bin/cp "$SYSTEMD_DIR"/src/shared/in-addr-util.c ./src/dhcp-manager/systemd-dhcp/src/shared/in-addr-util.c /bin/cp "$SYSTEMD_DIR"/src/shared/in-addr-util.h ./src/dhcp-manager/systemd-dhcp/src/shared/in-addr-util.h /bin/cp "$SYSTEMD_DIR"/src/systemd/_sd-common.h ./src/dhcp-manager/systemd-dhcp/src/systemd/_sd-common.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-dhcp-client.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-dhcp-client.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-dhcp-lease.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-dhcp-lease.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-dhcp6-client.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-dhcp6-client.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-dhcp6-lease.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-dhcp6-lease.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-event.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-event.h /bin/cp "$SYSTEMD_DIR"/src/systemd/sd-id128.h ./src/dhcp-manager/systemd-dhcp/src/systemd/sd-id128.h
* nmcli/bash-completion: complete "help" for `nmcli general status|permissions ↵Thomas Haller2014-11-061-0/+6
| | | | | | <TAB>` Signed-off-by: Thomas Haller <thaller@redhat.com>
* nmcli/bash-completion: complete logging level "TRACE"Thomas Haller2014-11-061-1/+1
| | | | | Fixes: bdea7d61d031c4cf1912dbc018e533f5b98556a4 Signed-off-by: Thomas Haller <thaller@redhat.com>
* platform: fix lifetime/preferred type in _address_get_lifetime()Dan Williams2014-11-051-1/+1
| | | | | | | They are defined as gint32 but are assigned a guint32 value and then immediately passed back to the caller of _address_get_lifetime() as guint32. They can never be negative, and may receive values greater than G_MAXINT32, so they should be unsigned.
* Revert "tui: additional fix for 'primary' option"Lubomir Rintel2014-11-041-1/+1
| | | | | | | | | It makes no sense -- the primary option is specific to active-backup bonds; not mandatory. It blocks validation and prvents using other options. This reverts commit 37f12088e45a663271e2ee6759a2b924c9745cd1. https://bugzilla.redhat.com/show_bug.cgi?id=1142864
* cli: Activating an already activated connection failsLubomir Rintel2014-11-031-2/+1
| | | | | | | The new ActiveConnection starts in UNKNOWN state and we immediately assume it failed. We should wait for DEACTIVATED or ACTIVATED instead. https://bugzilla.gnome.org/show_bug.cgi?id=739339
* wimax/build: use NM_PRAGMA_WARNING_DISABLE() macro instead of #pragmaThomas Haller2014-10-311-4/+3
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* all: add macros to suppress compiler warningsThomas Haller2014-10-311-0/+41
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* doc: fix IGNORE_HFILES in libnm-glibThomas Haller2014-10-311-2/+1
| | | | | | | | | nm-dbus-helpers-private.h is a private header file to libnm-glib/. nm-settings-connection-glue.h and nm-settings-glue.h are not part of libnm-glib/, they are inside src/. Signed-off-by: Thomas Haller <thaller@redhat.com>
* doc: fix IGNORE_HFILES referencing non-existing *-bindings.h filesThomas Haller2014-10-311-17/+0
| | | | | Fixes: 8ad3ff24ad2e2e2879cd1694be89f939791db1bb Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: merge branch 'th/bgo738590_dhcp_server_route' (bgo #738590)Thomas Haller2014-10-318-11/+99
|\ | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=738590 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * dhcp: don't add special route to DHCP server when having direct routeThomas Haller2014-10-311-5/+5
| | | | | | | | | | | | | | | | | | | | | | When the DHCP server address is not on the same subnet, we used to add a /32 route to the server IP address via the gateway. Do not add this route, if we already got a direct route from DHCP. https://bugzilla.gnome.org/show_bug.cgi?id=738590 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: add nm_ipX_config_get_direct_route_for_host() functionsThomas Haller2014-10-316-6/+77
| | | | | | | | | | | | | | | | | | | | add two functions nm_ip4_config_get_direct_route_for_host() and nm_ip6_config_get_direct_route_for_host() to check if we have a direct (non-gw) route to a certain host. Signed-off-by: Thomas Haller <thaller@redhat.com> https://bugzilla.gnome.org/show_bug.cgi?id=738590
| * core: add nm_utils_ip6_route_metric_normalize() functionThomas Haller2014-10-312-0/+17
|/ | | | | | | | | Kernel treats IPv6 route metrics with value zero (0) special. Add a utility function that helps accounting for that. Signed-off-by: Thomas Haller <thaller@redhat.com> https://bugzilla.gnome.org/show_bug.cgi?id=738590
* test,examples: fix scripts to avoid 'has_key' for Python 3Thomas Haller2014-10-312-7/+7
| | | | | | 'has_key' on Dictionaries is removed from Python3 in favor of 'in'. Signed-off-by: Thomas Haller <thaller@redhat.com>
* libnm: Fix a nm_running_changed raceLubomir Rintel2014-10-311-1/+3
| | | | | | | Unhook the nm_running_changed signal, so that it does not attempt to free connections after they've been disposed already. https://bugzilla.gnome.org/show_bug.cgi?id=739127
* Merge branch 'lr/ap'Lubomir Rintel2014-10-318-51/+172
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=738439
| * ifcfg-rh: add support for MODE=Aplr/apJiří Klimeš2014-10-232-1/+5
| | | | | | | | | | | | | | | | | | | | It is an extension against initscripts. However, we have many other Wi-Fi related extensions. So the NM-written ifcfg file will not be 100% backwards compatible anyway. Moreover, initscripts changed from using iwconfig to iw and dropped support (accidently?) for some traditional variable, like KEY1-KEY4, CHANNEL, etc. They should be fixed bring back by initscripts. https://git.fedorahosted.org/cgit/initscripts.git/commit/sysconfig/network-scripts/ifup-wireless?id=ddda5f6f818831b1fa37337be0ac9c0f619df1ca
| * cli: Add mode option for wifi connecitonsLubomir Rintel2014-10-235-24/+140
| | | | | | | | | | | | Only default (infrastructure) mode connections can be created and as it's not possible to write mode=ap connections with ifcfg-rh plugins, they can't be switched to mode=ap.
| * wifi: Use SSID from connection also if AP is not configuredLubomir Rintel2014-10-231-26/+27
| | | | | | | | | | | | | | | | Creating a mode=ap connection (as GNOME control center does) would otherwise assert in complete_connection despite having a proper SSID set: NetworkManager-wifi:ERROR:nm-device-wifi.c:1118:complete_connection: assertion failed: (ssid) Aborted
* | Merge branch 'lr/rpm-make-check'Lubomir Rintel2014-10-3011-22/+63
|\ \ | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=739127
| * | contrib/rpm: Run make checklr/rpm-make-checkLubomir Rintel2014-10-301-0/+7
| | |
| * | tests: Fix /general/nm_utils_kill_child raceLubomir Rintel2014-10-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | /general/nm_utils_kill_child: ** GLib:ERROR:test-general-with-expect.c:105:test_nm_utils_kill_child_sync_do: Did not see expected message NetworkManager-DEBUG: *kill child process 'test-s-1-1' (*): waiting up to 500 milliseconds for process to terminate normally after sending SIGTERM (15)... Aborted The first test case assumes the child does not go away immediately after being delivered a TERM signal. Add some delay to its teardown code path, so that NM will set up the timeout the test expects.
| * | libnm/tests: Properly wait for devices in /libnm/activate-virtualLubomir Rintel2014-10-301-0/+2
| | | | | | | | | | | | | | | Ignore the signal if we're signalled before the second device is available and wait for another one.
| * | libnm: Ignore NoReply errors when NM has vanished from the busLubomir Rintel2014-10-241-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the /libnm/client-nm-running test failure when a race condition is hit: test-nm-client:10350): libnm-WARNING **: updated_properties: error reading NMRemoteSettings properties: GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) What actually happens is that nm_running_changed_cb() calls GetAll() for a NMRemoteSettings object when NM appears on the bus. If it disappears shortly afterwards, another nm_running_changed_cb() is called which suppresses further object updates, but the original GetAll() might not have finished yet and DBus will generate a NoReply() response for it. We ought to ignore it.
| * | core: Fall back to CLOCK_MONOTONIC if CLOCK_BOOTTIME unsupportedLubomir Rintel2014-10-241-8/+29
| | | | | | | | | | | | | | | It was added fairly recently (2.6.39), this breaks run (and test run in mock) on RHEL-6 with 2.6.32.
| * | tests: Don't run session-long dbus daemons for testsLubomir Rintel2014-10-242-6/+10
| | | | | | | | | | | | | | | | | | They require a tty or X11 displays, thus are not suitable for headless runs (such as in mock). Furthermore, they die with the tty or X11 session, which is somehow late -- a lot of them may accumulate. Let's kill them right away.
| * | build: Don't conditionally omit files from distributionLubomir Rintel2014-10-204-8/+8
| | |
* | | core/logging: make log level and domain a C enumThomas Haller2014-10-302-33/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This way the compiler issues a warning when accidently switching the level and domain arguments when logging. Make LOGD_ALL and LOGD_DEFAULT members of the enum instead defining them. Previously the LOGD_ALL define included all the defined domains, hence this is no functional change. Also define the logging domain aliases as enum members (instead of preprocessor defines). Signed-off-by: Thomas Haller <thaller@redhat.com>
* | | core/logging: adjust numerical values of the logging domain flagsThomas Haller2014-10-301-35/+35
| | | | | | | | | | | | | | | | | | | | | | | | The numerical value 0x01 was unused. Shift all the values to fill the "hole". Fixes: 552ed76f59517edb4a75b28e665e492ae123fad1 Signed-off-by: Thomas Haller <thaller@redhat.com>
* | | merge: show connection secrets in nmcli when required (bgo #737415)Jiří Klimeš2014-10-307-71/+130
|\ \ \ | | | | | | | | | | | | | | | | Secrets will be displayed when '--show-secrets' is used for 'nmcli con show', or nmcli> nmcli show-secrets yes in the editor.
| * | | cli: allow showing secrets in the editorJiří Klimeš2014-10-303-5/+26
| | | |
| * | | cli: display '<hidden>' string for secret propertiesJiří Klimeš2014-10-303-52/+55
| | | | | | | | | | | | | | | | unless the user explicitly say to show them.
| * | | cli/bash-completion: update bash completion for '--show-secrets' optionThomas Haller2014-10-301-2/+5
| | | |
| * | | cli: add '--show-secrets' option for 'nmcli connection show'Jiří Klimeš2014-10-302-14/+46
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | It can be used to display connection secrets (passwords). When used, it will get secrets for the connection profile and merge it into the connection's settings before displaying it. Example: nmcli con show -s hotel-wifi
* | | merge: allow connection normalization in nmcli editor (rh #1157164)Jiří Klimeš2014-10-303-8/+69
|\ \ \ | | | | | | | | | | | | | | | | | | | | - introduce 'verify fix' command in the editor for normalizing the connection - check IP settings when connection.master property is changed and offer their removal (slaves are not allowed to have IP configuration)
| * | | cli: add 'verify fix' command for nmcli connection editorJiří Klimeš2014-10-301-7/+26
| | | | | | | | | | | | | | | | | | | | Some connection verification errors are normalizable by NetworkManager. So we can allow users to normalize the connection using one command.
View Lorry Controller Status