| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
startup_complete
We connect to notify::startup-complete signal of each connection,
but after we signal startup-complete once, we don't need that
signal anymore. Disconnect.
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=765387
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The following settings are effectively identical:
dns=none,rc-manager=*any*
dns=none,rc-manager=unmanaged
dns=default,rc-manager=unmanaged
The new setting is only there for completeness and only
makes sense for a dns plugin.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Already previously, the mode and rc-manager were intertwined in a complicated
way:
- dns=none effectively disables rc-manager.
- if resolv.conf was immutable, it would disable the rc-manager
by setting "resolv_conf_mode=NM_DNS_MANAGER_RESOLV_CONF_UNMANAGED".
- resolv_conf_mode was anyway a redundant piece of information to
rc_manager.
Now there are only two relevant settings: priv->plugin and
priv->rc_manager. And they can be set independently from each other.
Before that was not possible. For example, you could not set a
dns plugin with rc-manager=unmanaged (the only way to achive that
was via an immutable resolv.conf or by having rc-manager=symlink
and let resolv.conf link somewhere else.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The "dns" and "rc-manager" properties are strongly related. Initialize them
together in init_resolv_conf_mode().
One difference is, that we now set rc_manager before setting the mode.
But that shouldn't matter.
|
| |
| |
| |
| |
| | |
Makes more sense in the next commit, when init_resolv_conf_manager()
gets merged with init_resolv_conf_mode(). Bear with me.
|
|/
|
|
|
|
| |
We already have "rc-manager=file", rename "rc-manager=none" to "symlink"
because that better describes what it is actually doing. Of course, the
old name is still accepted.
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=765464
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Generate a stable connection UUID for the default-wired-connection.
Otherwise, on every reboot, the UUID changes although the generated
connection is the same.
But also hash into the UUID the machine-id, the device name and the
hardware address. So, the UUID is only the same if the connection is
identical in every aspect.
Also, the UUID is used as Network_ID for the stable-privacy address
generation mode. It is bad to re-create different UUIDs on every boot
as it causes different addresses.
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some device types, we use the DEVTYPE from sysfs to determine the
link type. However, the way we read from sysfs can race with device
renames and we could miss the chance to read DEVTYPE correctly.
This doesn't completely fix the sysfs race, but cures the boot-time race
with systemd renaming the device while we are initializing the link.
We ideally should use GUDev for all sysfs accesses, but that would need
some more work for this particular case as currently we need the link type
before we have an udev device instance.
https://bugzilla.gnome.org/show_bug.cgi?id=764803
Co-Authored-By: Beniamino Galvani <bgalvani@redhat.com>
|
|
|
|
|
| |
Fixes: 89d1e466157839096b446068a780cb2563424a5a
Tested-by: Celti on IRC
|
|
|
|
|
| |
The value cannot be unset. It must be set to one of the two currently
supported values.
|
|
|
|
| |
(cherry picked from commit 3ad7be3e6a124fe9e279ec6d9de06c423ca50cc2)
|
|\ |
|
| | |
|
| | |
|
|/
|
|
| |
https://mail.gnome.org/archives/networkmanager-list/2016-April/msg00075.html
|
|\
| |
| |
| | |
Some cleanup of "nm-sleep-monitor-systemd.c"
|
| |
| |
| |
| |
| | |
The lifetime of the proxy is not necesarily the same as the lifetime
of the NMSleepMonitor instance. Disconnect the signals during dispose().
|
| |
| |
| |
| |
| |
| | |
The daemon does not run with a particular locale of a user. Localizing
makes no sense (at least, we don't do it usually and it would make
logging localized).
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As we don't take a reference on @self during the asynchronous
request, we must properly support cancelling in case of early
destruction.
I think, it's gdbus' responsibility not to leak any file descriptors
when cancelling a D-Bus request that returns file descriptors. Thus,
our usual pattern works here too.
|
| |
| |
| |
| |
| | |
When destroing the sleep monitor before the D-Bus proxy is created,
we must cancel creation of the proxy.
|
| | |
|
| |
| |
| |
| |
| | |
To release resources, dispose() is preferred over finalize()
because it is called earlier.
|
| | |
|
|/ |
|
|
|
|
|
|
| |
@error
Fixes: 07a9364d9c151bc3086a863759d31d0857ae011e
|
|
|
|
| |
Fixes: 4271c9650c1cfcbd487cc471099b1c0c9bbfa290
|
|
|
|
| |
Fixes: f15c412015647b378a187bdf98ccf8cd75eb0475
|
|
|
|
|
|
|
| |
libnm-core/nm-vpn-plugin-info.c: In function ‘nm_vpn_plugin_info_get_auth_dialog’:
shared/gsystem-local-alloc.h:53:46: error: ‘prog_basename’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
Fixes: a3f94f451b910bbaf38a172f6bb9a2050a9553e5
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidepid
When mounting /proc with hidepid, we might fail to read the
start-time of the process from /proc/$PID/stat. In this case,
we should just accept a start-time of zero.
On the other side of authentication, polkit should accept a zero
start-time too.
nm_utils_get_start_time_for_pid() has other uses in NetworkManager,
mostly when killing a process from a PIDFILE or during
nm_utils_kill_process_sync(). In both these cases, this will only
succeed if we try to kill a process that also runs a root.
For processes started by the current instance, we don't care about the
PIDFILE and use nm_utils_kill_child_?sync() -- so there is no problem
with hidepid there.
https://bugzilla.gnome.org/show_bug.cgi?id=764502
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=765329
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Re-add nm_vpn_plugin_info_get_service(). This function *is* useful
and could be used by nm-applet.
This reverts commit 3517084b92aa64817ce8cd82163e5ab6e1947017.
|
|/
|
|
|
|
|
| |
_nm_vpn_plugin_info_list_load_dir()
No need to assert against an empty dirname. It's not different from
any other non-existing directory and we should be graceful about that.
|
| |
|
|
|
|
|
|
| |
And for @out_state, return ' ' instead of '\0' in case of
failure. That is more friendly, when the user happens to
print the value.
|
|
|
|
|
|
| |
Otherwise the types links would be dangling or resolved to slightly
irrelevant documentation in libnm or completely irrelevant documentation
in libnm-util.
|
|
|
|
|
|
| |
It isn't right in that context -- NMDevice is a libnm-core object,
not a bus object. In rendered documentation this would generate
a dangling link.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Pass an empty configuration file otherwise dnsmasq loads
"/etc/dnsmasq.conf".
We already allow for a config.d/ directory "/etc/NetworkManager/dnsmasq.d"
to allow the user to overwrite configuration. We don't want to consider
the global config file.
Fixes: 497a8aa5c6463404200a3fcc745aa65396dc4f22
|
|\
| |
| |
| |
| | |
https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00144.html
https://bugzilla.gnome.org/show_bug.cgi?id=765043
|
| | |
|