summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fixup! modem-broadband: update modem's supported-ip-families (rh #1263959)jk/modem-ip-families-rh1263959Thomas Haller2015-09-231-1/+1
|
* modem-broadband: update modem's supported-ip-families (rh #1263959)Jiří Klimeš2015-09-231-0/+17
| | | | | | | | | | | If SIM in a modem is locked, ModemManager can't initialize SupportedIpFamilies and NetworkManager will set the property to 0. ModemManager then updates the property after the modem is unlocked, but NetworkManager did not watch changes to the property. And that resulted in a connection failure: (ttyUSB1): Failed to connect 'O2 Internet': Connection requested IPv4 but IPv4 is unsuported by the modem. (ttyUSB1): device state change: prepare -> failed (reason 'modem-init-failed') [40 120 28] https://bugzilla.redhat.com/show_bug.cgi?id=1263959
* dns-manager: fix DNS options syntax in resolv.confBeniamino Galvani2015-09-221-1/+1
| | | | Fixes: e7ff906f910e948f3a0b0ddd08f7c645c9a09cc4
* contrib/rpm: fix creating proper po/Makefile.in.in (rh #1265117)Jiří Klimeš2015-09-221-2/+2
| | | | | | | | Without that DATADIRNAME was not present in po/Makefile.in.in and it resulted in /usr/\@DATADIRNAME\@/locale/cs/LC_MESSAGES/ path instead of /usr/share/locale/cs/LC_MESSAGES/. https://bugzilla.redhat.com/show_bug.cgi?id=1265117
* manager: cleanup NMRfkillManager in dispose()Jiří Klimeš2015-09-221-0/+5
| | | | Fixes: b15fb8641e26eb63c2d83d9dcc9510705086e2f2
* manager: disconnect signal handlers on 'settings' in dispose() (rh #1264676)Jiří Klimeš2015-09-221-1/+10
| | | | | | Otherwise a crash can occur when shutting down. https://bugzilla.redhat.com/show_bug.cgi?id=1264676
* device: refactor beginning of _set_state_full()Thomas Haller2015-09-211-8/+18
| | | | | | - Reorder statements, to first g_return_if_fail() and log state-change. - Also log a message when leaving _set_state_full() early due to missing firmware.
* cli: fix type on printed nmcli error messageThomas Haller2015-09-211-2/+2
| | | | Fixes: 4dffbf8f6abe48a5677e5d702cb107f9946c824f
* nmcli/bash-completion: fix completion for device names for `nmcli device set`Thomas Haller2015-09-211-1/+1
| | | | Fixes: 7405d5c7b742fd429d6d4815a416c35f363752bd
* merge: make VPN timeout configurable - vpn.timeout property (bgo #754754)Jiří Klimeš2015-09-216-3/+85
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=754754
| * man: document that vpn.timeout property supports a default valueJiří Klimeš2015-09-211-0/+5
| |
| * vpn: use vpn.timeout property as timeout value for IP config (bgo #754754)Jiří Klimeš2015-09-211-2/+19
| | | | | | | | | | | | | | | | | | Some VPN services may take their time when establishing a connection. Let's make our timeout configurable to be able to give such services a chance. https://mail.gnome.org/archives/networkmanager-list/2015-April/msg00007.html https://bugzilla.gnome.org/show_bug.cgi?id=754754
| * cli: support vpn.timeout property in nmcliJiří Klimeš2015-09-211-1/+13
| |
| * libnm-core: add vpn.timeout property for establishing connectionsJiří Klimeš2015-09-213-0/+48
|/ | | | [1] https://mail.gnome.org/archives/networkmanager-list/2015-April/msg00007.html
* device: log the flags that are set/cleared in _set_unmanaged_flags()Thomas Haller2015-09-211-2/+2
| | | | Don't show only the flags that are set/cleared *in addition*.
* merge: fix ADSL in nmcli and libnm-core/libnm-utils (rh #1264089)Jiří Klimeš2015-09-215-5/+189
|\ | | | | | | | | | | - implements 'nmcli connection add type adsl' - initializes adsl.protocol for 'nmcli con edit type adsl' - fixes errors in adsl properties in libnm-core/libnm-util
| * cli: allow creating ADSL connections with 'nmcli connection add' (rh #1264089)Jiří Klimeš2015-09-213-1/+171
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1264089
| * cli: initialize adsl.protocol in editor when creating a new connectionJiří Klimeš2015-09-211-0/+8
| | | | | | | | | | The protocol is required and it is nice to have a valid initial value for the property.
| * libnm-core/libnm-util: fix an assertion in adsl settingJiří Klimeš2015-09-212-4/+10
|/ | | | (process:7799): GLib-CRITICAL **: g_ascii_strdown: assertion 'str != NULL' failed
* core: fix crash in NMManager message filterBeniamino Galvani2015-09-211-2/+2
| | | | | | | | | | | | | | | | g_dbus_message_get_interface() can return NULL in the message filter, for example when the client does: #!/usr/bin/env python import dbus bus = dbus.SystemBus() proxy = bus.get_object("org.freedesktop.NetworkManager", "/org/freedesktop/NetworkManager") proxy.foobar() Use g_strcmp0() to compare the interface and member names. Fixes: 34ba4e14b8674dc74327975159e101710ebd5403
* device: remove unused ip_ifaceJiří Klimeš2015-09-211-7/+0
|
* wifi: remove unused variablesJiří Klimeš2015-09-211-4/+0
|
* exported-object: explicitly disconnect bindings and signal handlers to ↵Thomas Haller2015-09-181-11/+59
| | | | | | | | | | | | | GDBusInterfaceSkeleton interfaces While an NMExportedObject is exported (i.e. registered at NMBusManager), it has a list of GDBusInterfaceSkeleton interfaces. The properties of the nm-object are bound to the interfaces and the signals connected. Previously, when unexporting the NMExportedObject, we would only unref the interfaces, but not explicitly disconnect. As there is no guarantee that the lifetime of the interfaces is shorter then the lifetime of the nm-object, hence, explicitly disconnect.
* core: merge branch 'lr/applied-connection-bgo724041'Thomas Haller2015-09-1844-1134/+1740
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=724041
| * core: separate active and applied connectionLubomir Rintel2015-09-1836-843/+1326
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clone the connection upon activation. This makes it safe for the user to modify the original connection while it is activated. This involves several changes: - NMActiveConnection gets @settings_connection and @applied_connection. To support add-and-activate, we constructing a NMActiveConnection with no connection set. Previously, we would set the "connection" field to a temporary NMConnection. Now NMManager piggybacks this temporary connection as object-data (TAG_ACTIVE_CONNETION_ADD_AND_ACTIVATE). - get rid of the functions nm_active_connection_get_connection_type() and nm_active_connection_get_connection_uuid(). From their names it is unclear whether this returns the settings or applied connection. The (few) callers should figure that out themselves. - rename nm_active_connection_get_id() to nm_active_connection_get_settings_connection_id(). This function is only used internally for logging. - dispatcher calls now get two connections as well. The applied-connection is used for the connection data, while the settings-connection is used for the connection path. - needs special handling for properties that apply immediately when changed (nm_device_reapply_settings_immediately()). Co-Authored-By: Thomas Haller <thaller@redhat.com> https://bugzilla.gnome.org/show_bug.cgi?id=724041
| * libnm: mark properties that take effect immediately on active connection ↵Thomas Haller2015-09-185-2/+39
| | | | | | | | | | | | (REAPPLY_IMMEDIATELY) The flag is still unused.
| * libnm: use NM_FLAGS_HAS() in nm_setting_compare()Thomas Haller2015-09-181-5/+7
| |
| * secrets: make agent-manager independent from NMSettingsConnectionThomas Haller2015-09-186-24/+59
| | | | | | | | | | | | | | | | | | | | NMSecretAgent (and in turn NMAgentManager) used the @connection argument both for the connection data, but also for the connection path. Detangle these, and accept the path separate from the connection. This makes NMSecretAgent and NMAgentManager truly operate on a plain NMConnection, without the non-obvious requirement, that the path of the connection must be set.
| * vpn-connection: refactor cancellation of secretsThomas Haller2015-09-181-9/+21
| |
| * settings: use nm_settings_connection_get_id/uuid() utilsThomas Haller2015-09-182-16/+15
| |
| * settings: add nm_settings_connection_get_id/uuid() utilsThomas Haller2015-09-182-0/+15
| |
| * libnm: don't assert in nm_connection_get_*() for verified connectionThomas Haller2015-09-181-2/+4
| | | | | | | | | | | | | | | | | | | | Those getters are convenience methods to retrieve the id/type from the NMSettingConnection. If the NMSettingConnection was missing (and thus the connection invalid) we would raise an assertion. Don't be so strict and just silently return NULL. Otherwise, the caller cannot use the functions on unverified connections.
| * audit-manager: don't log connection whose addition failsLubomir Rintel2015-09-182-4/+3
| | | | | | | | | | In AddAndActivate the uuid and id make no sense until authorization succeeds and the connection is saved.
| * vpn-connection: use logging macros _LOG*()Thomas Haller2015-09-181-120/+92
| | | | | | | | | | | | | | | | | | | | This now gives every logging line of a NMVpnConnection a fully descriptive prefix. Especially for non-debug logging, this looks a bit verbose and repetitive, so we could suppress the prefix in that case. I still add it because I think the verbose information does help during debugging.
| * vpn-connection: add logging macros _LOG*()Thomas Haller2015-09-181-0/+55
| |
| * vpn-connection/trivial: consistently rename @connection argument to @selfThomas Haller2015-09-182-120/+120
| |
| * core/manager: use active_connection_get_by_path() in ↵Thomas Haller2015-09-181-9/+4
|/ | | | impl_manager_deactivate_connection()
* libnm: fix missing case in "nm-remote-connection.c"Thomas Haller2015-09-181-1/+1
| | | | Fixes: d20bed069c718e161f0a2457c9fb8204fc5c9fac
* libnm: fix initializing of new connectionsJiří Klimeš2015-09-182-1/+4
| | | | | | | | | | | | | | | | | | | | | connection_added() can be called before init_get_settings_cb(), and we can't complete the connection until it is visible, else it would be uninitialized. Test case: * have 'em1' interface $ nmcli con add type ethernet con-name myeth ifname em1 autoconnect no (process:9039): libnm-CRITICAL **: nm_connection_get_id: assertion 's_con != NULL' failed Connection '(null)' ((null)) successfully added. $ nmcli con add type ethernet con-name myeth ifname em1X autoconnect no Connection 'myeth' (71159504-c2af-4773-8ca9-a3626aa0da33) successfully added. https://bugzilla.gnome.org/show_bug.cgi?id=754767 https://bugzilla.gnome.org/show_bug.cgi?id=754794 [lkundrak@v3.sk: This is not quite the correct fix, we shouldn't emit NMObject:connection-added for an unfinished object. Nevertheless, let's go with it until we have a better one. Will revert this afterwards. See linked bugs.]
* core: merge branch 'th/secret-requests-bgo754508'Thomas Haller2015-09-1815-755/+809
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=754508
| * agent-manager: always invoke complete function for asynchronous ↵Thomas Haller2015-09-189-102/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nm_agent_manager_get_secrets() Refactor agent-manager to always invoke the complete function for nm_agent_manager_get_secrets(). In general, the complete function is always invoked asnychronously when starting the operation. On the other hand, when cancelling the operation or disposing the manager with pending operations, we now (always) synchronously invoke the callback. This makes it simpler for the user to reliably cancel the request and perform potential cleanup. This behavior bubbles up through NMSettingsConnection and NMActRequest, and other callers that make directly or indicrectly make use of nm_agent_manager_get_secrets().
| * secret-agent/trivial: add code commentThomas Haller2015-09-181-0/+11
| |
| * settings: refactor call_id type of async functions for NMAgentManager, ↵Thomas Haller2015-09-1811-163/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NMSettingsConnection and NMActRequest Instead of having the call_id of type guint32, make it an (opaque) pointer type. This has the advantage of strong typing and avoids the possiblity of reusing an invalid integer (or overflow of the call-id counter). OTOH, it has the disadvantage, that after a call_id is disposed, it might be reused for future invocations (because malloc might reuse the memory). In fact, it is always an error to use a call_id that is already completed. This commit also adds assertions to the cancel() calls that the provided call_id is a pending call. Hence, such a bug will be uncovered by assertions (that only might not tigger in certain unlikely cases where a call-id got reused). Note that for NMAgentManager, save_secrets() and delete_secrets() both returned a call_id. But they didn't also provide a callback when the operation completes. So the user trying to cancel such a call, cannot know whether the operation is still in process and he cannot avoid triggering an assertion. Fix that by not returning a call-id for these operations. No caller cared about it anyway. For NMSettingsConnection, also track the internally scheduled requests for so that we can cancel them on dispose.
| * agent-manager: fix type of idle_id in Request structureThomas Haller2015-09-181-1/+1
| |
| * agent-manager/refact: return early from _con_get_try_complete_early() ↵Thomas Haller2015-09-181-49/+43
| | | | | | | | instead of if-else-if
| * agent-manager/trivial: rename functionsThomas Haller2015-09-181-41/+41
| |
| * agent-manager/refact: replace get_start() by request_start()Thomas Haller2015-09-181-10/+19
| | | | | | | | | | Let all implementations call request_start(), instead of getting-secrets doing something special and call get_start().
| * agent-manager/refact: replace function callbacks by direct calls or inlineThomas Haller2015-09-181-159/+81
| | | | | | | | | | Drop the function pointers. Instead either inline them or call them explicitly (possibly after switching on the request_type).
| * agent-manager/refact: merge the subclasses into RequestThomas Haller2015-09-181-324/+285
| | | | | | | | Merge ConnectionRequest structure into Request.
| * core/trivial: add code comment to nm_utils_get_shared_wifi_permission()Thomas Haller2015-09-181-0/+6
| |
View Lorry Controller Status