summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* core/trivial: add code comment to nm_utils_get_shared_wifi_permission()lr/applied-connection-bgo724041-3Thomas Haller2015-09-021-0/+6
|
* fixup! auth-utils: some refactoring in nm-auth-utils.cThomas Haller2015-09-021-11/+16
|
* auth-utils: some refactoring in nm-auth-utils.cThomas Haller2015-09-021-44/+63
| | | | | | | | | | | | - move nm_auth_chain_check_done() and nm_auth_chain_remove_call() into the only caller auth_call_complete(). - take a ref of the "context" argument. - in nm_auth_chain_add_call(), assert that we didn't yet invoke the done-callback. The auth-chain should not be reusued. - use slice allocator for ChainData, AuthCall and NMAuthChain
* fixup! core: separate active and applied connectionThomas Haller2015-09-026-14/+30
|
* fixup! core: separate active and applied connectionThomas Haller2015-09-022-22/+20
| | | | TRIVIAL: only renaming
* fixup! core: separate active and applied connectionThomas Haller2015-09-022-4/+4
|
* fixup! core: separate active and applied connectionThomas Haller2015-09-026-40/+82
| | | | For dispatcher, pass both applied and settings connection.
* fixup! core: separate active and applied connectionThomas Haller2015-09-027-67/+67
| | | | Drop initial_connection and inject the argument somehow differently.
* fixup! core: separate active and applied connectionThomas Haller2015-09-024-4/+9
| | | | | | | For logging, fallback to initial_connection if settings_connection is yet unset. This commit will be dropped (if we accept the following fixup).
* squash! core: separate active and applied connectionThomas Haller2015-09-029-217/+316
| | | | | | | | | | | | | | | | | | | | | | | TODO: reword commit message - split nm_active_connection_get_connection() into nm_active_connection_get_initial_connection() and nm_active_connection_get_settings_connection(). settings_connection is now of NMSettingsConnection type. - Also for NMVpnConnection it does not hold that the settings-connection is known from the beginning. Also for vpns we do add-and-activate. - get rid of nm_active_connection_get_connection_type() and nm_active_connection_get_connection_uuid(). From the name it is unclear whether this returns the settings or applied connection. The (very few) callers, should figure that out themselfes. - rename nm_active_connection_get_id() to nm_active_connection_get_settings_connection_id(). This function is only used internally for logging.
* fixup! core: separate active and applied connectionLubomir Rintel2015-09-027-103/+179
| | | | | | | [[was:]] activation-request: cease using the secrets if the original connection changed I will squash this branch into the previous one. They cannot easily be treated separately.
* core: separate active and applied connectionLubomir Rintel2015-09-0233-360/+426
| | | | | | | | Clone the connection upon activation. This makes it safe for the user to modify the original connection while the settings are being applied. This makes it possible to determine the differencies between the connection that was applied and current version of the connection.
* libnm: don't assert in nm_connection_get_*() for verified connectionThomas Haller2015-09-021-2/+4
| | | | | | | | | | Those getters are convenience methods to retrieve the id/type from the NMSettingConnection. If the NMSettingConnection was missing (and thus the connection invalid) we would raise an assertion. Don't be so strict and just silently return NULL. Otherwise, the caller cannot use the functions on unverified connections.
* audit-manager: don't log connection whose addition failsLubomir Rintel2015-09-022-4/+3
| | | | | In AddAndActivate the uuid and id make no sense until authorization succeeds and the connection is saved.
* vpn-connection: use logging macros _LOG*()Thomas Haller2015-09-021-120/+92
| | | | | | | | | | This now gives every logging line of a NMVpnConnection a fully descriptive prefix. Especially for non-debug logging, this looks a bit verbose and repetitive, so we could suppress the prefix in that case. I still add it because I think the verbose information does help during debugging.
* vpn-connection: add logging macros _LOG*()Thomas Haller2015-09-021-0/+55
|
* vpn-connection/trivial: consistently rename @connection argument to @selfThomas Haller2015-09-022-120/+120
|
* core/manager: use active_connection_get_by_path() in ↵Thomas Haller2015-09-021-9/+4
| | | | impl_manager_deactivate_connection()
* nm-glib: add compatibility for G_IO_ERROR_NOT_CONNECTEDLubomir Rintel2015-09-021-0/+5
|
* libnm-core: fix a crash in priority_strv_to_maplist()Jiří Klimeš2015-09-011-1/+1
| | | | | | | strv can be NULL. Reproducer: $ nmcli con mod my-vlan vlan.ingress 1:5
* Split out the bits which determine ID_NET_DRIVER or DRIVERS into separate ↵Michael Biebl2015-08-313-7/+15
| | | | | | | | | udev rules file Those are not required with systemd-udevd v210 or newer. This way distros which have a new enough version of udev can skip installing 84-nm-drivers.rules. While at it, don't use absolute paths for sed and ethtool.
* ppp: remove unused vestige of dbus-glibDan Williams2015-08-311-2/+0
|
* introspection: add AUDIT domain to available list in SetLogging() descriptionJiří Klimeš2015-08-311-1/+1
| | | | Fixes: 41e7051165166839c7e44f644dc750169d233e96
* doc: fix the names of [in|e]gress-priority-map properties in ifcfg-rh man pageJiří Klimeš2015-08-311-2/+2
|
* platform: assert to successfully dlopen libnl3Thomas Haller2015-08-271-0/+3
|
* platform: remove bogus assertsLubomir Rintel2015-08-271-6/+0
| | | | | You can't really compare a symbol resolved by ld.so to dlsym()'d one. The former one is likely just an address of trampoline in PLT.
* dbus: allow talking to more plugins in DBus policyLubomir Rintel2015-08-271-0/+2
| | | | | These two has been seen in the wild. Libreswan is the RHEL's openswan fork.
* merge: allow overriding MTU for team devices (rh #1255927)Jiří Klimeš2015-08-272-27/+62
|\ | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1255927
| * ifcfg-rh: save wired properties also for bond/team (rh #1255927)Jiří Klimeš2015-08-271-27/+41
| | | | | | | | | | | | | | Without that MTU is not saved to ifcfg file for bond and team and thus it is lost over NetworkManager restart. https://bugzilla.redhat.com/show_bug.cgi?id=1255927
| * team: allow overriding the MTU for team device (rh #1255927)Jiří Klimeš2015-08-271-0/+21
|/ | | | | | | | | Set the MTU if 802-3-ethernet.mtu is present and non-zero. The ifcfg-rh writer sets it if there's a MTU key. The same change as for bond in commit a169a79a7df1dbb8d966937c9cb887ffc6a63695. https://bugzilla.redhat.com/show_bug.cgi?id=1255927
* device: fix clearing of dhcp6_restart_id in dhcp6_cleanup()Beniamino Galvani2015-08-261-1/+1
| | | | Fixes: abc96ecdfd1162bf59048d10ff13cbe11a0c8da7
* test: fix a format-security errorLubomir Rintel2015-08-261-1/+1
| | | | | test-dispatcher-envp.c: In function 'test_generic': test-dispatcher-envp.c:507:3: error: format not a string literal and no format arguments [-Werror=format-security]
* device: don't disconnect after DHCP failure when there are static IPsBeniamino Galvani2015-08-261-0/+68
| | | | | | | | Don't disconnect the device when the DHCP renewal fails and there are already configured static IP addresses on the device. Instead, keep the device up and try DHCP again after some time. https://bugzilla.redhat.com/show_bug.cgi?id=1168388
* core: don't set "startup complete" until devices have been added (rh #1256772)Jiří Klimeš2015-08-261-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | check_if_startup_complete() could be invoked from nm_settings_start() before devices had chance to be added, which results in premature "startup complete" and NM would quit when configure-and-quit=yes is set up. Postpone actual check_if_startup_complete() resolution until we add all devices and they are processed. (gdb) bt #0 0x00005555556401f3 in check_if_startup_complete (self=0x5555559f91d0) at nm-manager.c:719 #1 0x00007ffff4d69de8 in g_closure_invoke () at /lib64/libgobject-2.0.so.0 #2 0x00007ffff4d7b70d in signal_emit_unlocked_R () at /lib64/libgobject-2.0.so.0 #3 0x00007ffff4d83471 in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #4 0x00007ffff4d8372f in g_signal_emit () at /lib64/libgobject-2.0.so.0 #5 0x00007ffff4d6e4b5 in g_object_dispatch_properties_changed () at /lib64/libgobject-2.0.so.0 #6 0x00007ffff4d709d9 in g_object_notify () at /lib64/libgobject-2.0.so.0 #7 0x00005555556e232c in check_startup_complete (self=self@entry=0x555555a0e130) at settings/nm-settings.c:204 #8 0x00005555556e5203 in nm_settings_start (self=0x555555a0e130, error=error@entry=0x7fffffffe658) at settings/nm-settings.c:2122 #9 0x0000555555646d06 in nm_manager_start (self=0x5555559f91d0, error=0x7fffffffe658) at nm-manager.c:4153 #10 0x00005555555add43 in main (argc=1, argv=0x7fffffffe7c8) at main.c:428 (gdb) Fixes:Beaker:NetworkManager_Test37_run_once_new_connection https://bugzilla.redhat.com/show_bug.cgi?id=1256772
* platform: merge branch 'th/platform-parent-other-netns-bgo753726'Thomas Haller2015-08-256-34/+98
|\ | | | | | | | | | | | | | | | | | | Add support for IFLA_LINK_NETNSID to properly handle linked parent interfaces that reside in another netns. This requires support of the IFLA_LINK_NETNSID from both the kernel and libnl3. https://bugzilla.gnome.org/show_bug.cgi?id=753726
| * platform: handle parent interfaces in other netnsThomas Haller2015-08-256-26/+92
| | | | | | | | | | | | | | | | | | | | | | The parent of a link (IFLA_LINK) can be in another network namespace and thus invisible to NM. This requires the netlink attribute IFLA_LINK_NETNSID which is supported by recent versions of kernel and libnl. In this case, set the parent field to NM_PLATFORM_LINK_OTHER_NETNS and properly handle this special case.
| * platform: minor refactoring in _nl_get_vtable()Thomas Haller2015-08-251-8/+5
| |
| * platform: minor fix in nm_platform_link_to_string()Thomas Haller2015-08-251-1/+1
| | | | | | | | | | This had not real consequences, because @master and @parent are of the same size.
| * platform: return const argument from _nl_get_vtable()Thomas Haller2015-08-251-1/+1
| |
| * platform: assert we loaded the right libnl libraryThomas Haller2015-08-251-1/+2
|/
* libnm: properly handle floating references in ↵Thomas Haller2015-08-252-0/+8
| | | | nm_vpn_service_plugin_set_ip6_config()
* agent-manager: fix wrong unref in request_remove_agent()Thomas Haller2015-08-251-1/+1
| | | | Fixes: 13386f760ac46564c363ea690d517d941fd1686e
* libnm: export nm_vpn_service_plugin_set_{ip6_,}configLubomir Rintel2015-08-251-0/+2
| | | | Seems to be forgotten.
* settings: merge branch 'th/secret-agent-rh1253407'Thomas Haller2015-08-257-229/+554
|\ | | | | | | | | | | Several fixes and refactoring for NMSecretAgent and NMAgentManager. https://bugzilla.redhat.com/show_bug.cgi?id=1253407
| * agent-manager: fix leak of secret-agentThomas Haller2015-08-251-2/+9
| |
| * secret-agent: fix detection of disapearing secret-agentThomas Haller2015-08-253-28/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The signal "notify:g-name-owner" is only emitted for well-known names, but not for unique connection names (":1.x") such as the secret agent's connection. Also, it will not be emited for private connections. That meant that when the client disconnected without explicitly unregistering, the NMSecretAgent was not cleaned up and leaked indefinitely. As only one instance of secret agent with a certain 'identifier/uid' pair can register, this bug also prevented the client from registering until restart of NetworkManager. Fixes: df6706813a698e7a697739b0940bd8f528713aab
| * agent-manager: refactor logging in agent-managerThomas Haller2015-08-251-82/+144
| |
| * secret-agent: add trace logging to secret agentThomas Haller2015-08-251-12/+68
| |
| * agent-manager: remove @asked field from requestThomas Haller2015-08-253-26/+0
| | | | | | | | | | | | | | | | | | | | This code was unused, because we never enqueued any hashes to the @asked list. Note that hashing also might give wrong hash collisions, so this was buggy anyway. Also, note that impl_agent_manager_register_with_capabilities() already ensures that duplicate agents are not registered in the first place (find_agent_by_identifier_and_uid()).
| * secret-agent: don't assert against existing getpwuid() entryThomas Haller2015-08-251-3/+4
| | | | | | | | | | There is a race and there is no guarantee that getpwuid() can lookup a uid that (previously) existed. Just accept %NULL as @owner_username.
View Lorry Controller Status