summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* buiuld: regenerate config-extra.h if configure was re-run with different ↵lr/config-extraLubomir Rintel2019-09-251-1/+1
| | | | arguments
* shared/trivial: rename _nm_g_slice_free_fcn1() macro to nm_g_slice_free_fcn1()Thomas Haller2019-09-231-4/+4
| | | | | | | The leading underscore has the notion that this would be a private function. It really isn't, and it would be fine for the user to call it directly. Just like we have g_slice_free() and g_slice_free1().
* contrib/rpm: "Suggest" wpa_supplicant for NetworkManager-wifi packageThomas Haller2019-09-231-0/+1
| | | | | | | | | | | | | | "NetworkManager-wifi" package requires either wpa_supplicant or iwd. When installing the package without explicitly installing supplicant or iwd (and not having it installed yet), then we want to drag in wpa_supplicant by default. That is accomplished by suggesting wpa_supplicant package. Otherwise, the user installing NetworkManager-wifi might get iwd, which is only functioning if the user explicitly enables the backend in "NetworkManager.conf". https://bugzilla.redhat.com/show_bug.cgi?id=1743585
* wifi/p2p: fix crash due to invalid signal handler ↵Thomas Haller2019-09-231-0/+1
| | | | | | | | | | supplicant_group_iface_group_finished_cb() Fixes: 00e64d13320f ('core/devices: Add P2P Wifi device and peer tracking') https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/249 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/284
* core: merge branch 'th/check-have-connection-for-auto-default'Thomas Haller2019-09-231-36/+4
|\ | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1727909 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/232
| * settings: drop redundant check from have_connection_for_device()Thomas Haller2019-09-231-6/+0
| | | | | | | | | | | | have_connection_for_device() really should just call nm_device_check_connection_compatible(). Note that nm_device_check_connection_compatible() of course checks the connection type already, so this is redundant.
| * settings: shortcut check for whether to create auto-default wired connectionThomas Haller2019-09-231-1/+2
| | | | | | | | | | | | This check is only useful for devices that implement new_default_connection. We can shortcut the possibly expensive checks like have_connection_for_device(), which need to iterate all profiles.
| * core: fix wrongly generating "Wired connection 1" (auto-default) for ↵Thomas Haller2019-09-231-30/+3
|/ | | | | | | | | | | | | | | | | | | | | | | ethernet with MAC If a profile has only "ethernet.mac-address" set, but "connection.interface-name" not, then the previous check iface = nm_setting_connection_get_interface_name (s_con); if (!nm_streq0 (iface, nm_device_get_iface (device))) continue; would wrongly consider the profile not matching for the device. As a result, we would wrongly create a auto-default connection. Fix that. We already call nm_device_check_connection_compatible() above. That is fully suitable to compare the interface name and the MAC address. We don't need to duplicate this check (wrongly). See also commit 77d01c909470 ('settings: ignore incompatible connections when looking for existing ones') for how this code changed. https://bugzilla.redhat.com/show_bug.cgi?id=1727909
* bluez: merge branch 'th/bluez-rework-2'Thomas Haller2019-09-2354-2889/+4911
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/251
| * bluetooth: refactor BlueZ handling and let NMBluezManager cache ↵Thomas Haller2019-09-2326-2813/+4296
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ObjectManager data This is a complete refactoring of the bluetooth code. Now that BlueZ 4 support was dropped, the separation of NMBluezManager and NMBluez5Manager makes no sense. They should be merged. At that point, notice that BlueZ 5's D-Bus API is fully centered around D-Bus's ObjectManager interface. Using that interface, we basically only call GetManagedObjects() once and register to InterfacesAdded, InterfacesRemoved and PropertiesChanged signals. There is no need to fetch individual properties ever. Note how NMBluezDevice used to query the D-Bus properties itself by creating a GDBusProxy. This is redundant, because when using the ObjectManager interfaces, we have all information already. Instead, let NMBluezManager basically become the client-side cache of all of BlueZ's ObjectManager interface. NMBluezDevice was mostly concerned about caching the D-Bus interface's state, tracking suitable profiles (pan_connection), and moderate between bluez and NMDeviceBt. These tasks don't get simpler by moving them to a seprate file. Let them also be handled by NMBluezManager. I mean, just look how it was previously: NMBluez5Manager registers to ObjectManager interface and sees a device appearing. It creates a NMBluezDevice object and registers to its "initialized" and "notify:usable" signal. In the meantime, NMBluezDevice fetches the relevant information from D-Bus (although it was already present in the data provided by the ObjectManager) and eventually emits these usable and initialized signals. Then, NMBlue5Manager emits a "bdaddr-added" signal, for which NMBluezManager creates the NMDeviceBt instance. NMBluezManager, NMBluez5Manager and NMBluezDevice are strongly cooperating to the point that it is simpler to merge them. This is not mere refactoring. This patch aims to make everything asynchronously and always cancellable. Also, it aims to fix races and inconsistencies of the state. - Registering to a NAP server now waits for the response and delays activation of the NMDeviceBridge accordingly. - For NAP connections we now watch the bnep0 interface in platform, and tear down the device when it goes away. Bluez doesn't send us a notification on D-Bus in that case. - Rework establishing a DUN connection. It no longer uses blocking connect() and does not block until rfcomm device appears. It's all async now. It also watches the rfcomm file descriptor for POLLERR/POLLHUP to notice disconnect. - drop nm_device_factory_emit_component_added() and instead let NMDeviceBt directly register to the WWan factory's "added" signal.
| * bluetooth/tests: add "nm-bt-test helper" program for manual testing of ↵Thomas Haller2019-09-223-13/+88
| | | | | | | | | | | | | | bluetooth code Just add a stub implementation and let it build. More will be added later.
| * man: add examples how to configure bluetooth devices to `man nmcli-examples`.Thomas Haller2019-09-221-0/+22
| |
| * wwan: simplify API of nm_modem_act_stage2_config() to never failThomas Haller2019-09-224-32/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous function arguments of nm_modem_act_stage2_config() act as if the function could fail or even postpone the action. It never did. We cannot treat this generic. A caller needs to know whether nm_modem_act_stage2_config() can postpone the action, and when it does, which signal is emitted upon completion. That is, the caller needs to know how to proceed after postponing. In other words, since this function currently cannot fail or postpone the stage, so must all callers already rely on that. At this point it makes no sense to pretend that the function could be any different, if all callers assume it is not. Simplify the API.
| * wwan: add nm_modem_manager_get_modems() to iterate over modemsThomas Haller2019-09-223-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we cannot ask which modems exist. NMDeviceBt may claim it via nm_device_factory_emit_component_added(), and NMWWanFactory may take it by listening to NM_MODEM_MANAGER_MODEM_ADDED. But that's it. We will drop nm_device_factory_emit_component_added() because it's only used for passing modems to NMDeviceBt. Instead, NMDeviceBt can directly subscribe to NM_MODEM_MANAGER_MODEM_ADDED. It already has a reference to NMModemManager. Anyway, the NM_MODEM_MANAGER_MODEM_ADDED signal is no enough, because sometimes when the mode appears, NMDeviceBt might not yet know whether it should take it (because the DUN connect call is not yet complete). Currently that never happens because dun_connect() blocks waiting for the device. That must be fixed, by not waiting. But this opens up a race, and NMDeviceBt might after NM_MODEM_MANAGER_MODEM_ADDED need to search for the suitable modem: by iterating the list of all modems.
| * wwan: mark modems that are taken by a NMDevice as "claimed"Thomas Haller2019-09-226-12/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | NMModem-s are either used by NMDeviceModem or by NMDeviceBt. The mechanism how that is coordinated it odd: - the factory emits component-added, and then NMDeviceBt might take the device (and claim it). In that case, component-added would return TRUE to indicate that the modem should not be also used by NMDeviceModem. - next, if the modem has a driver that looks like bluetooth, NMDeviceModem ignores it too. - finally, NMDeviceModem claims the modem (which is now considered to be non-bluetooth). I think the first problem is that the device factory tries to have this generic mechanism of "component-added". It's literally only used to cover this special case. Note that NMDeviceBt is aware of modems. So, abstracting this just adds lots of code that could be solved better by handling the case (of giving the modem to either NMDeviceBt or NMDeviceModem) specifically. NMWWanFactory itself registers to the NM_MODEM_MANAGER_MODEM_ADDED signal and emits nm_device_factory_emit_component_added(). We could just have NMWWanFactory and NMDeviceBt both register to that signal. Signals even support priorities, so we could have NMDeviceBt be called first to claim the device. Anyway, as the modem can only have one owner, the modem should have a flag that indicates whether it's claimed or not. That will allow multiple components all look at the same modem and moderate who is going to take ownership.
| * core: extend nm_shutdown_wait_obj_*() to support notification via a GCancellableThomas Haller2019-09-225-12/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now nm_shutdown_wait_obj_*() supports two styles: - NM_SHUTDOWN_WAIT_TYPE_OBJECT: this just registers a weak pointer on a source GObject. As long as the object is not destroyed (and the object is not unregistered), the shutdown gets blocked. - now new is NM_SHUTDOWN_WAIT_TYPE_CANCELLABLE: this source object is a GCancellable, and during shutdown, the system will cancel the instances to notify about the shutdown. That aside, the GCancellable is tracked exactly like a regular NM_SHUTDOWN_WAIT_TYPE_OBJECT (meaning: a weak pointer is registered and shutdown gets delayed as long as the instance lives). As the rest of the shutdown, it's not yet implemented on the shutdown-side. What is now possible is to register such cancellables, so that users can make use of this API before we fix shutdown. We cannot fix it all at the same time, so first users must be ready for this approach.
| * core: add and use NM_MANAGER_GET macroThomas Haller2019-09-2210-16/+17
| | | | | | | | | | | | | | For our singleton getters we usually have such a macro. See NM_PLATFORM_GET and NM_SETTINGS_GET. Add such a macro for NMManager and use it.
| * shared: add more nm_dbus_connection_call_*() and ↵Thomas Haller2019-09-222-5/+287
| | | | | | | | nm_dbus_connection_signal_subscribe_*() helpers
| * shared,all: add and use DBUS_INTERFACE_OBJECT_MANAGER defineThomas Haller2019-09-224-3/+5
| |
| * shared: add nm_utils_hash_values_to_array() helperThomas Haller2019-09-222-0/+43
| |
| * shared: add nm_auto_remove_source cleanup macroThomas Haller2019-09-221-0/+3
| |
| * shared: add nm_auto_unref_io_channel cleanup macroThomas Haller2019-09-221-0/+3
| |
| * shared: support nm_g_slice_free_fcn() for sizes of 32 bytesThomas Haller2019-09-221-1/+4
|/
* libnm/test: add unit test with consistency checks about NMSetting type infoThomas Haller2019-09-213-0/+166
| | | | | | | | | | | | | | | | | | | | | Add test for checking the meta data for expected consistency. This is also useful if you want to check something about the meta data programatically. For example, if you have the question which (if any) properties are GObject based but also implement a to_dbus_fcn() function. Then you can extend this code with some simple printf debugging to get a list of those. Or, if you want to find how many NMSettInfoProperty instances are in static data (e.g. to determine how much memory is used). You can easily modify this code to count them (and find 447 properties). Out of these, 326 are plain GObject based properties. Meaning, we could refactor the code to create smaller NMSettInfoProperty instances for those, saving thus (326 * 4 * sizeof (gpointer)) bytes (10K). Such questions are interesting when refactoring the code.
* libnm: merge branch 'th/libnm-dbus-rework-1'Thomas Haller2019-09-2110-116/+275
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/258
| * libnm: drop unused property setter NM_DEVICE_MANAGEDThomas Haller2019-09-211-5/+0
| | | | | | | | | | | | | | | | | | | | | | NM_DEVICE_MANAGED was intended to work like NM_DEVICE_AUTOCONNECT: namely it would call the D-Bus property setter synchronously. But such behavior is horrendous, we certainly don't want blocking calls during a property getter. Luckily this one instance was unused and never worked as the property was marked as G_PARAM_READABLE. Just drop the setter.
| * libnm: inline NMManager's get_permissions_sync()Thomas Haller2019-09-211-24/+10
| | | | | | | | | | | | | | | | | | Synchrnous initialization is problmatic and needs cleanup. get_permissions_sync() is an internal function, that has only one caller. We need to keep track of functions that make synchronous D-Bus calls. Move the synchronous call into the caller, so that it's clearer who calls such API.
| * libnm: drop _nm_dbus_is_connection_private()Thomas Haller2019-09-213-24/+3
| | | | | | | | | | Currently, we don't use private sockets. We are always connected to D-Bus.
| * libnm: drop nm_dbus_new_connection() helper APIThomas Haller2019-09-213-63/+6
| | | | | | | | | | | | | | | | | | | | We don't need a wrapper around g_bus_get*(). Just use it directly. I guess in the past this had some use when we were using a private socket too. Those days are gone. If we are going to re-introduce private socket support, then we probably should come up with a better solution.
| * shared: add NMRefStringThomas Haller2019-09-214-0/+242
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'd like to refactor libnm's caching. Note that cached D-Bus objects have repeated strings all over the place. For example every object will have a set of D-Bus interfaces (strings) and properties (strings) and an object path (which is referenced by other objects). We can save a lot of redundant strings by deduplicating/interning them. Also, by interning them, we can compare them using pointer equality. Add a NMRefString implementation for this. Maybe an alternative name would be NMInternedString or NMDedupString, because this string gets always interned. There is no way to create a NMRefString that is not interned. Still, NMRefString name sounds better. It is ref-counted after all. Notes: - glib has GQuark and g_intern_string(). However, such strings cannot be unrefered and are leaked indefinitely. It is thus unsuited for anything but a fixed set of well-known strings. - glib 2.58 adds GRefString, but we cannot use that because we currently still use glib 2.40. There are some differences: - GRefString is just a typedef to char. That means, the glib API exposes GRefString like regular character strings. NMRefString intentionally does that not. This makes it slightly less convenient to pass it to API that expects "const char *". But it makes it clear to the reader, that an instance is in fact a NMRefString, which means it indicates that the string is interned and can be referenced without additional copy. - GRefString can be optionally interned. That means you can only use pointer equality for comparing values if you know that the GRefString was created with g_ref_string_new_intern(). So, GRefString looks like a "const char *" pointer and even if you know it's a GRefString, you might not know whether it is interned. NMRefString is always interned, and you can always compare it using pointer equality. - In the past I already proposed a different implementation for a ref-string. That made different choices. For example NMRefString then was a typedef to "const char *", it did not support interning but deduplication (without a global cache), ref/unref was not thread safe (but then there was no global cache so that two threads could still use the API independently). The point is, there are various choices to make. GRefString, the previous NMRefString implementation and the one here, all have pros and cons. I think for the purpose where I intend NMRefString (dedup and efficient comparison), it is a preferable implementation. Ah, and of course NMRefString is an immutable string, which is a nice property.
| * shared: add nm_auto_unlock_g_mutex and NM_G_MUTEX_LOCKED() helper macrosThomas Haller2019-09-211-0/+14
|/
* wifi: fix the supplicant config testLubomir Rintel2019-09-201-2/+2
| | | | | | | Oopsie, forgot to adjust the test for change in roaming signal strength threshold. Fixes: 24bbceed9bad ('wifi: roam more aggressively'):
* tui: wifi: support WPA3-Personal (SAE)Beniamino Galvani2019-09-202-0/+11
|
* libnm-core: support SAE when determining AP compatibilityBeniamino Galvani2019-09-201-1/+6
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/172
* wifi: roam more aggressivelyKristian Klausen2019-09-201-1/+1
| | | | | | | | | | | | | | | | -80dBm is a very weak signal and we should roam sooner. iwd[1] and iOS[2] default to -70dBm, Android[3] default to -73dBm. So lets change the roaming threshold to -70dBm. [1] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=45a51613c4c24067fe0e35b4c084a50124282b36 [2] https://support.apple.com/en-us/HT203068 [3] https://android.googlesource.com/platform/frameworks/base/+/68a4599a37e07745cbe0d441e29152da388b5baa/core/res/res/values/config.xml#609 https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#218 https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/dacacbf69da8844232d938437b3b38471a3d2827/service/java/com/android/server/wifi/ScoringParams.java#325 https://android.googlesource.com/platform/frameworks/opt/net/wifi/+/ee0920fb68d2f4447936301ce3192c345224e8e7/service/java/com/android/server/wifi/WifiNetworkSelector.java#149 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/201 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/278
* introspection: fix documentation for Wimax(Hardware)?EnabledLubomir Rintel2019-09-201-3/+4
| | | | | | | These properties don't do anything. They just exist for compatibility reasons. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/274
* cli: add kill switch indication to "nmcli" outputLubomir Rintel2019-09-204-0/+45
| | | | | | | | There is some guess work done on the client side. Perhaps the o.fd.NM.Device could be extended to indicate which kill switch is the device disabled by. This could be good enough for now though. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/271/commits
* Merge branch 'bg/dhcp-keep'Beniamino Galvani2019-09-182-11/+31
|\ | | | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/243 https://bugzilla.redhat.com/show_bug.cgi?id=1688329
| * device: keep client running after activation failureBeniamino Galvani2019-09-181-8/+16
| | | | | | | | | | | | | | | | | | If DHCPv4 fails but IPv6 succeeds it makes sense to continue trying DHCP so that we will eventually be able to get an address if the DHCP server comes back. Always keep the client running; it will be only terminated when the connection is brought down. https://bugzilla.redhat.com/show_bug.cgi?id=1688329
| * device: accept lease only after addresses are configuredBeniamino Galvani2019-09-181-2/+14
| | | | | | | | | | | | | | | | | | | | In the accept() callback, the nettools client creates a UDP socket with the received address as source, so the address must be already configured on the interface. Also, handle errors returned by nm_dhcp_client_accept(). Fixes: 401fee7c2040 ('dhcp: support notifying the client of the result of DAD')
| * n-dhcp4: arm timers in bound stateBeniamino Galvani2019-09-181-1/+1
|/ | | | | | | Arm timers when the bound state is reached, otherwise the lease is never renewed. https://github.com/nettools/n-dhcp4/pull/4
* merge: branch 'bg/cli-general-reload'Beniamino Galvani2019-09-1714-29/+359
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/265
| * cli: add 'general reload' commandBeniamino Galvani2019-09-171-0/+97
| | | | | | | | | | Add 'nmcli general reload [flags]' command to reload NM configuration and perform other updates.
| * cli: don't create a NMClient for the 'connection reload' commandBeniamino Galvani2019-09-173-4/+65
| | | | | | | | | | | | | | | | It is a waste of resources instantiating a NMClient, filling the object cache and then throwing everything away without using it. This can take seconds on slow systems with many objects. Since the ReloadConnections doesn't need anything from the cache, just execute the D-Bus method call directly.
| * libnm: add nm_client_reload()Beniamino Galvani2019-09-175-0/+162
| | | | | | | | | | Introduce libnm API to reload NM configuration through the Reload() D-Bus method.
| * libnm: export reload flagsBeniamino Galvani2019-09-175-24/+34
| | | | | | | | | | Flags to the manager Reload() method are stable API but not exposed in a public header. Export them.
| * systemd: use busctl instead of dbus-sendBeniamino Galvani2019-09-171-1/+1
|/ | | | | While dbus-send may not be installed, busctl is shipped with systemd and so it should be always available.
* supplicant: add FT-SAE key-mgmt to verification listBeniamino Galvani2019-09-161-1/+1
| | | | | | | | FT-SAE is missing in the supplicant configuration verification list, causing an activation failure when using SAE and the supplicant supports FT. Fixes: d17a0a090555 ('supplicant: allow fast transition for WPA-PSK and WPA-EAP')
* merge: branch 'fg/nettools_dhcp_options_II'Francesco Giudici2019-09-134-162/+135
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/213
| * dhcp: nettools: drop useless "options" GHashTable checksFrancesco Giudici2019-09-131-8/+5
| |
View Lorry Controller Status