| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Previously, the daemon would just use syslog with LOG_PERROR when run with
--debug option, even when actually configured to log into the journal.
Let's respect the configuration, but preserve the logging to stderr.
|
|
|
|
|
|
|
| |
Suppress warnings and avoid assertions in
nm_access_point_connection_valid().
https://bugzilla.gnome.org/show_bug.cgi?id=773675
|
|
|
|
|
|
| |
Works by dumb luck for in-tree build, because the .deps files that are
meant for the distribution happen to be the builddir. The out-of-tree
builds would generate an empty file.
|
| |
|
|
|
|
|
|
| |
nm_utils_exp10() is a better name, because it reminds of the function
exp10() from <math.h> which has a similar purpose (but whose argument
is double, not gint16).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"build_clean.sh" is used to generate a distribution tarball. The tarball
contains pregenerated man pages with default values for paths, which in
turn depend on the configure options when creating the tarball.
Previously, the man page would have paths like "usr/local/etc/NetworkManager/...",
which doesn't seem the best choice for a default man page.
Explicitly set the installation paths.
Also, --disable-dependency-tracking in this mode. It may speed up the
build.
|
|
|
|
|
|
|
|
| |
We also dist libnm/nm-property-docs.xml, so depending on
whether we build from git or source tarball, the file
is in $(srcdir) or $(builddir).
Fixes: d7ad13591be6bc29188ed6e421abb8dad07305f0
|
|
|
|
|
| |
Fixes: 530af7009ecca099372fd50a9b2b130c875a6524
Fixes: 90683fcb3a4a60d2902ebb7e4a47419d76acb1d8
|
|
|
|
| |
Fixes: d7ad13591be6bc29188ed6e421abb8dad07305f0
|
|
|
|
| |
Fixes: d7ad13591be6bc29188ed6e421abb8dad07305f0
|
|
|
|
| |
Fixes: d7ad13591be6bc29188ed6e421abb8dad07305f0
|
|
|
|
|
|
|
|
|
| |
There are very few places where we actually use floating point
or #include <math.h>.
Drop that library, although we very likely still get it as indirect
dependency (e.g. on my system it is still dragged in by libsystemd.so,
libudev.so and libnl-3.so).
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
from nmcli
One day, I wish we would have more setting metadata in shared via
"shared/nm-setting-metadata.h", ready for nmcli and nmtui to use
(by statically linking against the internal API).
Anyway, it is still unused, so drop the files from the SOURCES of
nmcli.
|
|
|
|
|
|
|
|
| |
"$(srcdir)/clients/cli/settings.c" includes "$(builddir)/clients/cli/settings-docs.c",
hence, we need "-I$(builddir)/clients/cli".
This basically reverts commit bbce089840e9b85808e01a5e0c265d3fa3186e61,
but adds dependencies so that the build directory exists.
|
|
|
|
|
| |
NM_FLAGS_HAS() should reject negative flag values. So check for > 0.
Also change parentheses and line wrap.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The sources should reach files in the $builddir using #include "".
Besides, it is not guarranteed to be around:
CC shared/clients_cli_nmcli-nm-setting-metadata.o
cc1: error: ./clients/cli: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
Makefile:12971: recipe for target 'shared/clients_cli_nmcli-nm-setting-metadata.o' failed
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not sufficient to make nm-core-enum-types.[ch] depend on the
dirstamp, because they also depend on their own stamps that are to be
placed in libnm-core.
$ make libnm-core/nm-core-enum-types.h.stamp
GEN libnm-core/nm-core-enum-types.h
/bin/sh: libnm-core/nm-core-enum-types.h.tmp: No such file or directory
../../Makefile.glib:107: recipe for target 'libnm-core/nm-core-enum-types.h.stamp' failed
make: *** [libnm-core/nm-core-enum-types.h.stamp] Error 1
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When rc-manager=file other services may overwrite resolv.conf at any
time. We don't support merging configurations in resolv.conf but we can
be more tolerant avoiding updating resolv.conf when not strictly needed.
In this case, if the last write of resolv.conf had no nameservers (nor
options), reset the "dns_touched" flag in order to avoid resetting
resolv.conf when quitting (so, potentially overwriting some other
service configuration there).
https://bugzilla.redhat.com/show_bug.cgi?id=1426748
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GLib 2.52 added a G_GNUC_PRINTF attribute to
g_dbus_message_new_method_error(). This triggered warning in
NetworkManager when built with -Wformat, which is an error when built
with -Werror=format-security. It seems that gcc isn't smart enough to
see that (foo = "bar") should be treated as a literal.
Fortunately there is a g_dbus_message_new_method_error_literal()
function which does not take printf-style arguments, and we don't need
them, so we can use that.
This patch was originally by Rico Tzschichholz <ricotz@ubuntu.com>, and
was submitted to Launchpad at
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1650972
https://bugzilla.gnome.org/show_bug.cgi?id=780444
|
| |
|
| |
|
|
|
|
| |
Fixes: 7307dea9c4da6cdc53e4c23c4ce07cf51bd0c4b7
|
|
|
|
|
|
| |
CURLOPT_CONNECTTIMEOUT or CURLOPT_TIMEOUT only make sense if libcurl is
handling the I/O loop (the "easy" interface); we need to implement our
own timeout.
|
|
|
|
| |
No need to read the full response into memory.
|
|
|
|
| |
No need to read the rest of the reponse.
|
|
|
|
|
|
|
|
| |
Factor out the conclusion of the connectivity check. This will allow us
to finish the connectivity check on other occassions than a successful
connection end. Most importantly on timeouts; but it will also allow us
to short-circuit the check when we conclude it without reading the full
response.
|
| |
|
| |
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=780308
|
| |
| |
| |
| | |
DRY.
|
| |
| |
| |
| |
| |
| | |
No need to create a separate NMUdevClient instance for all devices.
Instead, have one "struct udev" instance in NMClient and pass
it down during object construction.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
GUdevClient always creates a monitor instance, even if there are no subsystems
or handlers defined. Hence the first iteration of NMUdevClient did that as
well.
I think that can be avoided however. We only need a monitor when there is
a event handler subscribed. Contrary to GUdevClient, we know that from the
very beginning.
|
|/
|
|
|
|
| |
libgudev is just a wrapper around libudev. We can
use libudev directly and drop the dependency for
libgudev.
|