| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
XXX needs more work
|
| |
|
| |
|
| |
|
|
|
|
| |
No properties or methods here yet either.
|
|
|
|
| |
No properties there yet.
|
|
|
|
| |
No properties there yet.
|
|
|
|
|
|
| |
That one is special. All interfaces that are attached to OpenVSwitch
ports appear as slaves to that one even for our purposes we like to
pretend they're slaves to the actual OpenVSwitch bridges.
|
|
|
|
|
| |
Will be useful with OpenVSwitch where we want to be able to enslave
"ovs-port" slaves, but also "ovs-bridge" slaves as a shorthand.
|
|
|
|
|
|
|
|
|
|
|
| |
For some software devices, the platform link appears only after they've been
realized. Update their properties and let them know that the link has changed
so they can eventually proceed with activation.
Also, reset the properties (udi, iface, driver) that are set from the platform
link when the link goes away. At that point they don't reflect reality anymore.
Removes some code duplication too.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In many cases we want to treat IPv4 and IPv6 generically. That looks nicer
if we distingish by an @addr_family integer, instead of a boolean.
Replace the @is_ipv6 boolean with an @addr_family paramter. The @is_ipv6
boolean is inconsistent with other places where we use @is_ipv4 to
indicate the opposite. Eventually, we should use @addr_family
everywhere.
Also, at the call site it's not immediately clear what TRUE/FALSE means,
here AF_INET/AF_INET6 is better.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- cleanup data type and use guint32 consistently. We might want to
introduce a new "infinity" value. But since libnm's
NM_SETTING_IP_CONFIG_DHCP_TIMEOUT asserts against the range
0 - G_MAXINT32, we cannot express it as -1 anyway. So, infinity
will have the numerical value G_MAXINT32, hence guint32 is just
fine.
- make use of existing ipv6.dhcp-timeout setting and add global
default configuration in NetworkManager.conf
- instead of having subclasses call nm_device_set_dhcp_timeout(),
add a virtual function get_dhcp_timeout().
|
|
|
|
|
|
|
|
| |
A typo in the new dhcp-timeout option caused the dhclient daemon to exit
with error when the dhcp-timeout option was specified.
This prevents dhcp connection to be upped.
Fixes: 82ef497cc9e2728e73cb0426efbae85c83bec3fe
|
|
|
|
|
|
|
|
|
| |
A newer compiler version might emit some warnings and break the build
of the RPM. Of course, such warnings must be fixed. But it is still very
inconvenient to break the build of an old RPM version without easy workaround.
When building without "test" (which is on by default), don't use fatal warnings
for compilation.
|
|
|
|
|
| |
When sourcing the file, using exec inside NM-show-journal is a bad idea,
because it replaces the calling shell.
|
|
|
|
|
|
|
|
| |
Previously when the interface created by pppd was already the one we
expected, we would rename it to itself and remove the device from the
manager. Don't do it.
Fixes: 6c3195931e94cab70208ce97f3b834f5d9f5ff62
|
|\
| |
| |
| |
| |
| | |
Drop NMDefaultRouteManager.
https://github.com/NetworkManager/NetworkManager/pull/26
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove NMDefaultRouteManager. Instead, add the default-route to the
NMIP4Config/NMIP6Config instance.
This basically reverts commit e8824f6a5205ffcf761abd3e0897a22b254c7797.
We added NMDefaultRouteManager because we used the corresponding to `ip
route replace` when configuring routes. That would replace default-routes
on other interfaces so we needed a central manager to coordinate routes.
Now, we use the corresponding of `ip route append` to configure routes,
and each interface can configure routes indepdentently.
In NMDevice, when creating the default-route, ignore @auto_method for
external devices. We shall not touch these devices.
Especially the code in NMPolicy regarding selection of the best-device
seems wrong. It probably needs further adjustments in the future.
Especially get_best_ip_config() should be replaced, because this
distinction VPN vs. devices seems wrong to me.
Thereby, remove the @ignore_never_default argument. It was added by
commit bb750260045239ab85574366bae8102eff8058cc, I don't think it's
needed anymore.
This brings another change. Now that we track default-routes in
NMIP4Config/NMIP6Config, they are also exposed on D-Bus like regular
routes. I think that makes sense, but it is a change in behavior, as
previously such routes were not exposed there.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Default-routes are for the most part like regular routes. Add support to
track them like regular routes in NMIP4Config/NMIP6Config.
One thing is, sometimes we need to figure out whether an ip-config
instance has a default-route. For that, keep track of the best
default-route (there might be multiple) and expose it. That is
the most complicated part of this patch, because there are so many
places where the list of routes gets modified (replace, intersect,
subtract, merge, add), and they all need to take care of updating
the best default-route.
In a next patch, NMDefaultRouteManager will be dropped and default-routes
will be tracked by NMIP4Config/NMIP6Config.
|
|\
| |
| |
| |
| |
| |
| | |
Several patches with cleanup and in prepration for dropping
NMDefaultRouteManager.
https://github.com/NetworkManager/NetworkManager/pull/26
|
| |
| |
| |
| |
| | |
Later we will need the exact instance that we just added (or the previously
existing one, if the new route is already tracked).
|
| |
| |
| |
| | |
_nmtst_ip*_config_*()
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, we would first delete routes that are not to be added,
before adding the new ones.
This has the advantage, that even if delete removes the wrong route,
add would restore the expected state. This tries to workaround the fact
that RTM_DELROUTE allows for wild-card fields, and might delete the
wrong route.
However, for example when bumping the route metric after connectivty
check (removing the default-route with metric 20100 and adding the one
with metric 100), there is a short moment when there is no
default-route.
To avoid that, don't do delete-then-add, but add-then-delete.
|
| |
| |
| |
| | |
and nm_ip6_config_capture().
|
| |
| |
| |
| | |
and nm_ip6_config_capture().
|
| |
| |
| |
| | |
Taken from "src/nm-default-route-manager.c".
|
| |
| |
| |
| | |
Will be used later.
|
| |
| |
| |
| |
| | |
Functions that take and addr_family argument are just nicer
to use at places where we treat IPv4 and IPv6 generically.
|
| | |
|
| |
| |
| |
| | |
Will be used later.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Avoid calling nm_dedup_multi_index_add() directly, like we do for all other places.
Instead, call the wrapper _nm_ip_config_add_obj() which does some pre-precessing.
In practice, the result is exactly the same (at the moment). But there should by
only one way to add the route.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Don't rely on manager keeping them alive long enough. E.g.
get-best-device() is used when resetting the best device,
however, it accesses the current device (hence, it relies
on manager removing the device from the list, but keeping
it alive long enough).
|
| |
| |
| |
| |
| | |
- _LOGt() whenever the properties change.
- some minor refactoring
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We already track the best device as priv->default_device4 / priv->default_device6.
Don't try to look it up again. If the cached values from @priv are invalid/outdated,
that should be fixed instead.
This was already introduced by commit 773c006a4c9d3162e9b371762dc59fd5948e4b43.
But I don't think it should be done.
|
| |
| |
| |
| |
| | |
There is no reason for if-else-if. If DHCPv4 doesn't provide a hostname (but we
are doing DHCP), just check for DHCPv6.
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- nm_clear_g_object() is like g_clear_object() but:
- it returns a boolean value, indicating that something was cleared.
- it includes an nm_assert() to check that the pointer is still
valid.
- it uses typeof() instead of blindly casting the argument.
- nm_g_object_ref_set() combines nm_clear_g_object() and resetting
the pointer to a new object, including taking a reference.
- also returns a boolean, indicating whether something changed.
- it gets the order of operations right: first it increses the
ref-count, before unrefing the old object.
- like nm_clear_g_object() and nm_clear_g_free() it first sets
the destination to NULL, instead of leaving a dangling pointer
for the duraction of the unref/free call.
- fix nm_clear_g_free() not to use a possibly dangling pointer.
Striclty speaking, that is undefined behavior.
|
|
|
|
|
|
| |
And relax the type for nm_auto_unref_gtypeclass macro. Like
g_type_class_unref() itself, you usually don't use it with a GTypeClass
base class, but some subtype like GObjectClass.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=787378
|
|
|
|
|
| |
There are many places where the function can fail without returning an
error, leading to a crash. Fix this.
|
|
|
|
|
| |
I find it annoying when ^C exits less and it prompts me to often
do `NM-log | less -R` instead.
|
|
|
|
|
| |
Must not colorize the trailing space, otherwise the following
" device" will no longer match.
|
|
|
|
|
|
|
|
| |
- remove "\r\n" line endings
- colorize <warn> and <error> in red
- extend matching the info levels to include the timestamp. This
(intentionally) will no longer highlight messages from ModemManager,
which don't include a timestamp.
|
|
|
|
|
|
|
|
|
|
| |
- use "grep -a" so that grep doesn't refuse to work in binary input.
- make the script source-able to only define the NM-colorize and
NM-show-journal
- In case the script is sourced, it also defines a NM-log function,
which does the same as the script itself.
- rename internal functions so that they have names starting with "NM"
in case of sourcing.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=787382
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=787380
|
|\
| |
| |
| |
| |
| | |
Fix and improve determining the route to the external VPN gateway.
https://bugzilla.gnome.org/show_bug.cgi?id=787370
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Until recently, we would only consier the IP config of the parent device
to determine the route to the external VPN gateway. We changed that, to
additionally improve the guess by letting kernel resolve the route.
Now, drop checking the parent's config entirely. The only thing that
matters is the here and now runtime configuraion on the parent device.
And for that we ask kernel to resolve the route.
|