| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
If modprobe fails, it prints a message to stderr. Capture it and log it.
|
|
|
|
|
| |
Rename the function is_root() to unshare_user().
Also, interpret NMTST_FORCE_REAL_ROOT environment variable.
|
| |
|
|
|
|
| |
This fixes the test run in a container/our NETNS/NEWUSER test jail.
|
|
|
|
| |
Just check they're from kernel.
|
|
|
|
|
|
|
|
| |
A utility function OTOH should not unconditionally log error messages.
Especially we don't want error logging for nm_platform_link_add() which
tries to load the bonding module. Later we will run tests as non-root,
so modprobe would fail and the error logging would break the tests.
|
|
|
|
|
|
|
|
|
|
| |
nm_device_factory_manager_find_factory_for_link_type()
easily can see a link-type NM_LINK_TYPE_UNKNOWN because
there are many link types that NetworkManager cannot detect.
Just return NULL early.
Fixes: 71bde20c302ba321688f203a8c5cd1e2d296f0d1
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=749503
|
|
|
|
|
| |
'ifcfg-test-dns-options' was not included in the archive for
distribution and 'make distcheck' failed. Add it.
|
|\
| |
| |
| | |
https://bugzilla.redhat.com/show_bug.cgi?id=1200131
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| | |
Merge a first part of th/platform_refact_caching-bgo747981
https://bugzilla.gnome.org/show_bug.cgi?id=747981
|
| |
| |
| |
| |
| | |
Hard to debug failures, if we don't print where the failure
happens.
|
| |
| |
| |
| |
| |
| |
| | |
Support accepting more then one signal at a time.
It is to be expected, that one change in platform raises
several signals. Extend the assertion helpers to express
that.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Up to now, this code was correct. Later we will add another field
to NMPlatformIP4Route which causes the test to operate on
uninitialized data.
Instead of explicitly initializing the field, just clear the whole
struct.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
And nmtst_platform_ip6_routes_equal().
As already indicated by the comment, using memcmp() doesn't really work
here. It worked up to now, because the NMPlatformIP4Route structure has no
padding at the end.
If we would have a last 'guint8' member (as we will add later),
initializing an arry of routes on the stack would not clear the bytes
from the padding and the comparison using memcmp() would fail.
|
| | |
|
| |
| |
| |
| |
| | |
Not sure why (and whether!) this is really needed. Disable
it for now, resurrect it later if need be.
|
| |
| |
| |
| | |
Turns out, the valgrind suppression was hiding a memleak
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add a comment about the upstream bug that fixes
the suppressed memleak in libnl.
Also, add a different backtrace for the same bug.
It currently doesn't hit easily, because we don't
call nl_msg_parse() often. In the future we will
though.
|
|/ |
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=742939
|
| |
| |
| |
| |
| |
| | |
Try to set the MTU of the parent Ethernet interface to match the
requested PPP MTU and MRU. This allows the negotiation of a PPP MTU
and MRU greater than 1492.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We switched to user-mode PPPoE client to work around a bug in kernel
PPPoE code that caused pppd not to be notified when the connection was
terminated with a PADT before the LCP Termination Request.
The kernel bug has now been fixed upstream with commit 287f3a943fef
"pppoe: Use workqueue to die properly when a PADT is received", queued
for v4.1.
Since the issue affected only very particular scenarios and could
somehow be solved with the right configuration (see bugzilla entry),
we can safely revert the patch and restore the use of kernel mode
PPPoE.
This reverts commit 7955806a02db64b20079267743056d7d9d45af3b.
https://bugzilla.gnome.org/show_bug.cgi?id=742939
|
|/
|
|
| |
Fixes: 7ba2a058f201ac237e2c5ddf6f513f8c306f314d
|
|
|
|
| |
Fixes: 72baf9fa2498d54dd9f545af0054dd6de7d5ff2e
|
|
|
|
|
|
| |
activatable
https://bugzilla.redhat.com/show_bug.cgi?id=1174164
|
|
|
|
|
| |
A while ago (f4f3f4d69b6ff89b5ec7cb9b2ca3758c149f15f5) we added an
enum to represent the logging domain. Use it.
|
|
|
|
| |
so that it is displayed in nm-settings-ifcfg-rh manual page.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==21573== Syscall param mount(type) points to unaddressable byte(s)
==21573== at 0x854B9BA: mount (syscall-template.S:81)
==21573== by 0x158922: main (test-common.c:295)
==21573== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==21573==
{
<insert_a_suppression_name_here>
Memcheck:Param
mount(type)
fun:mount
fun:main
}
Fixes: d6aef9c188468224d6e1dd670844c3f0e7482c35
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=749164
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a connection had static IP addresses, an early event
from plaform would clear them from priv->con_ip4_config.
Fix that, by don't initializing priv->con_ip4_config
before we commit the first time.
https://bugzilla.gnome.org/show_bug.cgi?id=749052
Fixes: 557667df12fc05b76326d6406553985effeeb2ac
|
|
|
|
|
|
| |
We'd be able to do so for already existing devices, but not for devices that
are added afterwards, since gudev is hardwired not to listen for events from
kernel.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the system
Mount a private sysfs instance. Otherwise gudev sees the devices from the
parent netns as opposed to our netns.
We do, however need a writable /sys/devices subtree for testing the bridge
code. There doesn't seem to be any other way to get a writable subtree of a
read-only filesystem than remounting it with no parameters after the initial
mount. We use this to get a writable sysfs instance and then bindmount it so
that it fits properly in the sysfs hierarchy.
Co-Authored-By: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=747463
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Don't terminate the entire connection if IPv4LL configuration fails
but instead call nm_device_check_ip_failed() to check the result of
IPv6 as well.
|