summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* contrib/rpm: Run make checklr/rpm-make-checkLubomir Rintel2014-10-301-0/+7
|
* tests: Fix /general/nm_utils_kill_child raceLubomir Rintel2014-10-301-0/+1
| | | | | | | | | | /general/nm_utils_kill_child: ** GLib:ERROR:test-general-with-expect.c:105:test_nm_utils_kill_child_sync_do: Did not see expected message NetworkManager-DEBUG: *kill child process 'test-s-1-1' (*): waiting up to 500 milliseconds for process to terminate normally after sending SIGTERM (15)... Aborted The first test case assumes the child does not go away immediately after being delivered a TERM signal. Add some delay to its teardown code path, so that NM will set up the timeout the test expects.
* libnm/tests: Properly wait for devices in /libnm/activate-virtualLubomir Rintel2014-10-301-0/+2
| | | | | Ignore the signal if we're signalled before the second device is available and wait for another one.
* libnm: Ignore NoReply errors when NM has vanished from the busLubomir Rintel2014-10-241-0/+6
| | | | | | | | | | | | | | | This fixes the /libnm/client-nm-running test failure when a race condition is hit: test-nm-client:10350): libnm-WARNING **: updated_properties: error reading NMRemoteSettings properties: GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) What actually happens is that nm_running_changed_cb() calls GetAll() for a NMRemoteSettings object when NM appears on the bus. If it disappears shortly afterwards, another nm_running_changed_cb() is called which suppresses further object updates, but the original GetAll() might not have finished yet and DBus will generate a NoReply() response for it. We ought to ignore it.
* core: Fall back to CLOCK_MONOTONIC if CLOCK_BOOTTIME unsupportedLubomir Rintel2014-10-241-8/+29
| | | | | It was added fairly recently (2.6.39), this breaks run (and test run in mock) on RHEL-6 with 2.6.32.
* tests: Don't run session-long dbus daemons for testsLubomir Rintel2014-10-242-6/+10
| | | | | | They require a tty or X11 displays, thus are not suitable for headless runs (such as in mock). Furthermore, they die with the tty or X11 session, which is somehow late -- a lot of them may accumulate. Let's kill them right away.
* build: Don't conditionally omit files from distributionLubomir Rintel2014-10-204-8/+8
|
* rdisc: merge branch 'lkundrak/lr-rdisc-mtu' (bgo#738104)Thomas Haller2014-10-2027-210/+246
|\ | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=738104 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * rdisc,device: set MTU if an appropriate option is present in a RALubomir Rintel2014-10-203-0/+24
| | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=738104 Reported-by: Charles R. Anderson <cra@wpi.edu>
| * core: track origin of MTULubomir Rintel2014-10-2010-16/+31
| | | | | | | | | | Only override MTU if it came from a source of higher priority or is of equal priority but of lower value.
| * core: Move NMPlatformSource to nm-types.hLubomir Rintel2014-10-2020-194/+191
|/ | | | | ...and rename it while at it. It's going to be useful outside nm-platform, to weight MTU options from various sources.
* build: merge branch 'lkundrak/lr-rpm-build' (bgo#738507)Thomas Haller2014-10-203-19/+10
|\ | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=738507 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * contrib/rpm: Count all predecessors in revision numberLubomir Rintel2014-10-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The revision number of the RPM (as build by contrib/rpm) should be increasing so that newer packages can be installed using `yum install` and older packages can be downgraded using `yum downgrade`. By counting only --first-parent, the following example turns out wrong. Note the duplicate revision numbers. -- A(100)----------------------------F(101)----G(102) \ / B(101)----C(102)----D(103)----E(104) Just count *all* parent commits
| * contrib/rpm: Fix Fedora 19 buildLubomir Rintel2014-10-201-1/+7
| | | | | | | | Too old to have recent enough ModemManager.
| * contrib/rpm: Don't exclude files that are not builtLubomir Rintel2014-10-201-11/+0
| | | | | | | | RPM still insist that they need to exist in order to be excluded.
| * build: Don't leak generated files into distributionLubomir Rintel2014-10-201-6/+2
|/ | | | gdbus-codegen will generate code that will need a too recent version of glib.
* cli: fix getting/setting hostname (bgo #738796)Lubomir Rintel2014-10-201-0/+2
| | | | | | | | | Create a client instance before it's used. $ nmcli g hostname (process:13615): GLib-GObject-CRITICAL **: g_object_get: assertion 'G_IS_OBJECT (object)' failed https://bugzilla.gnome.org/show_bug.cgi?id=738796
* Merge: nmcli fixes for private connections (bgo #738643)Jiří Klimeš2014-10-202-56/+119
|\ | | | | | | | | | | | | When a user activates a private connection, other users will see the active connection, but they won't see the backing connection profile. https://bugzilla.gnome.org/show_bug.cgi?id=738643
| * cli: get connection ID straight from the active connectionJiří Klimeš2014-10-201-13/+1
| | | | | | | | | | Static connection profile may not be available and using active conection is easier anyway.
| * cli: show active connection even if the connection profile is not visibleJiří Klimeš2014-10-201-0/+65
| | | | | | | | $ nmcli con show
| * cli: show details for active connection even if the profile is not visibleJiří Klimeš2014-10-201-37/+47
| | | | | | | | $ nmcli con show other_user_con
| * cli: fix errors and crash for invisible connectionsJiří Klimeš2014-10-201-6/+6
|/ | | | | | | | | | | | | * two users are logged in: user_a and user_b * user_b creates a connection visible only to him 'user_b_private' (permissions: user:user_b) * user_b activates the connection user_b_private * user_a does not see the connection profile, but he does see the active connection * user_a calls nmcli con nmcli con show user_b_private
* libnm, core: fix problems with device activation (bgo 737993)Dan Winship2014-10-1915-293/+747
|\
| * libnm: add an object-creation-failed testDan Winship2014-10-192-2/+58
| |
| * libnm: add a virtual device creation-and-activation testDan Winship2014-10-191-1/+135
| | | | | | | | | | Add a test of creating a (virtual) device and activating a connection on it at the same time.
| * tools: add a bit of support for VLANs to test-networkmanager-service.pyDan Winship2014-10-191-6/+40
| |
| * libnm: add an active-connection test to test-nm-clientDan Winship2014-10-191-0/+146
| | | | | | | | | | | | | | Test NMClient's handling of active connections, and in particular test that we can correctly resolve the circular reference between an NMDevice and an NMActiveConnection, both synchronously and asynchronously.
| * tools: add a bit more activation support to test-networkmanager-service.pyDan Winship2014-10-192-10/+91
| | | | | | | | | | Now test-networkmanager-service.py can create ActiveConnections, though they don't actually finish activating.
| * libnm: abstract out duplicated device-creating code in testsDan Winship2014-10-194-200/+103
| |
| * core: lie about NMActiveConnection:state in new connectionsDan Winship2014-10-191-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | NMActiveConnections start out in state "unknown", but then quickly switch to "activating". Unfortunately, it's sometimes possible for this to be externally visible. Fix this by lying and saying that state is "activating" during the initial "unknown" stage (though not if the state changes to "unknown" later on). (Actually changing the initial state to "activating" breaks things because some code depends on there being a transition into the "activating" state.)
| * libnm: postpone activation callback until all objects are readyDan Winship2014-10-191-48/+103
| | | | | | | | | | | | | | In some cases, the nm_client_activate_connection() callback could be invoked when either the NMActiveConnection or the NMDevice had not been initialized yet. Fix it to wait for both of them to be fully initialized before invoking the callback.
| * libnm: add -added and -removed signals for ACs to NMManagerDan Winship2014-10-192-1/+22
| |
| * libnm: fix async property circular reference handlingDan Winship2014-10-191-15/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3e5b3833 changed various libnm methods to return 0-length arrays rather than NULL, and changed various other places to assume this behavior. The guarantee that they didn't return NULL relied on the assumption that all D-Bus properties would get initialized by NMObject code before anyone could call their get methods. However, this assumption was violated in the case where two objects circularly referenced each other (eg, NMDevice and NMActiveConnection). f9f9d297 attempted to fix this by slightly changing the ordering of NMObjectCache operations, but it actually ended up breaking things and causing infinite loops of object creation in some cases. There's no way to guarantee we never return partially-initialized objects without heavily rewriting the object-creation code, so this reverts most of f9f9d297 (leaving only the new comment in _nm_object_create()). The crashes introduced by 3e5b3833 will no longer happen because we've now fixed the classes to have initialized their object arrays to non-NULL values even before they get the real values.
| * libnm: further NULL-vs-empty-array fixesDan Winship2014-10-197-11/+28
|/ | | | | | | | | | | | In some cases, code may look at the value of an array-valued property during object initialization, before NMObject has set it to its actual initial value. So ensure that we initialize all such properties to an empty array, rather than leaving them NULL. Also fix another bug in NMClient that could result in priv->active_connections being NULL during certain signal emissions, and fix nm_client_get_active_connections() to not return NULL when NM was not running.
* cli: fix 'nmcli connection up bond0' being stuckJiří Klimeš2014-10-191-0/+1
| | | | | It can happen on activating a master without slaves. Active connection will not move past activating state.
* tui: clarify the "Device" widget with PPPoE connections (rh #1105753)Dan Winship2014-10-191-1/+10
| | | | | | PPPoE connections involve two different network connections, making it ambiguous what the "Device" field refers to. Clarify that it refers to the Ethernet device, not the PPP device.
* core: ensure interface is up before applying IP configuration (bgo #738479)Dan Williams2014-10-171-5/+16
| | | | | | | | Routing configuration fails to apply if the device is not IFF_UP, so if we're going to apply IP configuration to the device, make sure it's IFF_UP first. https://bugzilla.gnome.org/show_bug.cgi?id=738479
* core: remove child devices without deconfiguring them (bgo #738479)Dan Williams2014-10-171-8/+10
| | | | | | | | | | When a child device is found and an IP configuration already exists for it even though it is under NM control (like when pppd applies IP config to a WWAN device before NM gets the IP details from the pppd plugin), don't deconfigure the child device when removing it from the device list, because this breaks the device's configuration. https://bugzilla.gnome.org/show_bug.cgi?id=738479
* core: don't override external route metrics (bgo #738268)Dan Williams2014-10-171-4/+12
| | | | | | | | | | | | | | | A generated connection contains a copy of the device's existing configuration, so it's entirely redundant to merge the connection back into the device's IP config. But even though that should result in no changes to the IP config, NMSettingIPxConfig treats a route metric of '0' as the device priority, while NMIPxConfig allows 0 as a valid route metric. Since the setting values are preferred (they are supposed to be user-supplied and thus override anythign else, but in this case they are generated and thus not user-supplied) external routes with a metric of 0 are overwritten with the device priority metric. https://bugzilla.gnome.org/show_bug.cgi?id=738268
* remote-settings: Mark service as running when using private busFlorian Müllner2014-10-171-2/+3
| | | | | | | | When using a private bus connection, the service is never marked as running when settings are initialized asynchronously. Successfully opening a socket in NM's runtime directory should already imply a running service, so just mark it as such (as we already do in the synchronous path).
* trivial: add missing breakDan Williams2014-10-161-0/+1
|
* keyfile: fix handling of enum/flags properties after fcfb4b40 (bgo #738585)Dan Williams2014-10-168-2/+232
| | | | | | | When some properties got converted to G_TYPE_ENUM and G_TYPE_FLAGS the keyfile plugin was not updated to handle these types. https://bugzilla.gnome.org/show_bug.cgi?id=738585
* build: ensure rl_echo_signal_char() exists in the readline libraryDan Williams2014-10-141-0/+13
|
* bluez: fix compiler error due to redefinition of typedefThomas Haller2014-10-141-2/+2
| | | | | | | | | | | | | | | clang warns: make[5]: Entering directory `./NetworkManager/src/devices/bluetooth' CC nm-bluez5-dun.lo nm-bluez5-dun.c:50:3: error: redefinition of typedef 'NMBluez5DunContext' is a C11 feature [-Werror,-Wtypedef-redefinition] } NMBluez5DunContext; ^ ./nm-bluez5-dun.h:27:36: note: previous definition is here typedef struct _NMBluez5DunContext NMBluez5DunContext; ^ Fixes: f1c9595311f52d8b79e8d2032e006005613a8fb1 Signed-off-by: Thomas Haller <thaller@redhat.com>
* policy: allow non-local admin sessions to control the network (rh #1145646)Marius Vollmer2014-10-131-0/+1
|
* bluez: merge branch 'lr-bluez5-dun' (rh #1055628)Thomas Haller2014-10-1313-67/+678
|\ | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1055628 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * bluez: re-add DUN support for Bluez5Lubomir Rintel2014-10-136-43/+573
| | | | | | | | | | | | | | | | This adds service discovery via SDP and RFCOMM tty management to NetworkManager, as it was dropped from Bluez. Based on work by Dan Williams <dcbw@redhat.com>. The SDP discovery is based on code from Bluez project.
| * bluez: track adapter address in NMBluezDeviceDan Williams2014-10-134-6/+32
| | | | | | | | | | | | | | | | We'll need it for bluez5 DUN support. [lkundrak@v3.sk: Turn the addresses to strings from guint8[ETH_ALEN], as that is what rest of NetworkManager uses for MAC addresses and what Bluez utility functions expect as well.]
| * bluez: split out errorsDan Williams2014-10-135-18/+73
|/ | | | We'll use them from more places than nm nm-bt-device.c in the future.
* merge branch 'th/bgo737380_log_connection_diff'Thomas Haller2014-10-1220-103/+645
|\ | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=737380 Signed-off-by: Thomas Haller <thaller@redhat.com>
View Lorry Controller Status