summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* device: track used shared-ips via NMNetnsth/device-track-shared-ipsThomas Haller2020-09-141-37/+13
| | | | | | | | | | | | | | | Note that when NetworkManager tries to allocate more than 256 networks, then previously the allocation would fail. We no longer fail, but log an error and reuse the last address (10.42.255.1/24). It's simpler to have code that cannot fail, because it's often hard to handle failure properly. Also, if the user would configure two shared profiles that explicitly use the same subnet, we also wouldn't fail. Why not? Is that not a problem as well? If it is not, there is no need to fail in this case. If it is a problem, then it would be much more important to handle this case otherwise -- since it's more likely to activate two profiles that accidentally use the same subnet than activating 257+ shared profiles.
* core: add nm_netns_shared_ip_reserve() APIThomas Haller2020-09-142-0/+120
| | | | | | | | Add a better way of tracking the shared IP addresses that are in use. This will replace NMDevice's usage of a global hash table. For one, the API is more formalized with reserve() and release() functions. Also, it ties the used IP addresses to the netns, which would be more correct (in the future when we may support more netns).
* contrib/build: reword howto for "release.sh" scriptThomas Haller2020-09-141-3/+4
|
* release: bump version to 1.27.3 (development)1.27.3-devBeniamino Galvani2020-09-142-2/+2
|
* libnm/doc: improve description for ipv[46].dns-priority and ↵Thomas Haller2020-09-142-28/+50
| | | | ipv[46].dns-search regarding DNS leaks
* l3cfg: merge branch 'th/l3cfg-8'Thomas Haller2020-09-1121-1299/+1915
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/623
| * device/trivial: move code aroundThomas Haller2020-09-111-1074/+1070
| |
| * platform: add nm_platform_iter_obj_for_each() macroThomas Haller2020-09-111-0/+5
| |
| * core: use nm_platform_ip6_address_match() in nm_ip6_config_find_first_address()Thomas Haller2020-09-111-23/+2
| |
| * platform: add nm_platform_ip6_address_match()Thomas Haller2020-09-112-0/+37
| |
| * dhcp: drop "event_id" parameter from NM_DHCP_CLIENT_SIGNAL_STATE_CHANGED signalThomas Haller2020-09-116-23/+42
| | | | | | | | | | | | It is solely computed from the lease information (the GHashTable). No need to pass it along as separate argument in NM_DHCP_CLIENT_SIGNAL_STATE_CHANGED, especially since it only applies to IPv6.
| * device: mark NMDevicePrivate.sys_iface_state as constThomas Haller2020-09-112-5/+8
| | | | | | | | | | | | It's important to find place in code where are field (state) gets mutated. Make sys_iface_state field const, but add a mutable alias via a union. You can now grep for places that change the field.
| * device/trivial: unify (rename) functions in "nm-device.c"Thomas Haller2020-09-111-71/+71
| |
| * core: move nm_utils_generate_duid_from_machine_id() to "nm-core-utils.c"Thomas Haller2020-09-113-116/+138
| |
| * l3cfg: add nm_l3cfg_get_combined_l3cd() functionThomas Haller2020-09-112-0/+10
| |
| * l3cfg: gracefully accept %NULL argument in nm_l3_config_data_lookup_objs()Thomas Haller2020-09-111-0/+2
| | | | | | | | | | | | This way we can safely iterate over a %NULL instance with nm_l3_config_data_iter_obj_for_each(). This avoids a NULL check, which in this case seems more annoying than helpful.
| * l3cfg: add nm_l3cfg_get_best_default_route() functionThomas Haller2020-09-112-0/+25
| | | | | | | | | | | | This is the best default route that we commited the last time (if any). It may not reflect what is currently configured (in NMPlatform) and it may not reflect the latest changes since nm_l3cfg_add_config().
| * l3cfg: add nm_l3cfg_get_pllink() helperThomas Haller2020-09-111-0/+22
| | | | | | | | | | | | NML3Cfg already keeps track of the current NMPlatformLink object. Allow accessing it directly from an NML3Cfg instance, which saves a cache lookup from NMPlatform.
| * l3cfg: support tracking the DHCP lease in NML3ConfigDataThomas Haller2020-09-113-3/+90
| |
| * core: add NMDhcpLease typedef and simple accessor functionsThomas Haller2020-09-111-0/+61
| |
| * shared: add nm_utils_hashtable_{equal,cmp}() helper functionThomas Haller2020-09-113-18/+371
| |
| * shared: fix out of bounds for nm_g_array_append_new() macroThomas Haller2020-09-111-6/+6
| | | | | | | | Fixes: fb6e9795b7cf ('shared: add nm_g_array_append_new() helper')
| * device: remove unused dhcp4.root_path fieldThomas Haller2020-09-111-5/+0
|/
* bond: merge branch 'th/bond-options-reapply-fix'Thomas Haller2020-09-105-176/+178
|\ | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1856640 https://bugzilla.redhat.com/show_bug.cgi?id=1876577 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/622
| * tui: always unset "active-slave" bond option in nmtuiThomas Haller2020-09-101-0/+1
| | | | | | | | | | | | "active_slave" option is a deprecated alias for "primary". nmtui can configure the "primary" option, so whenever it configures a profile the "active_slave" option should be unset.
| * cli: normalize profile when setting bond options "active_slave" or "primary"Thomas Haller2020-09-101-4/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "active_slave" is by now deprecated and became an alias for "primary". If a profile specifies both properties, only "primary" is honored, without failing validation (to not break existing behavior). Maybe we should introduce a normalization for such cases. But normalize might not do the right thing, if a profile currently has "primary" set, and the user modifies it to set "active_slave" to a different value, normalize would not know which setting was set first and remove "active_slave" again. In the past, nm_setting_bond_add_option() performed some simple normalization, but this was dropped, because (such incompatible) settings can also be created via the GObject property. Our C accessor function should not be less flexible than other ways of creating a profile. In the end, whenever a user (or a tool) creates a profile, the tool must be aware of the semantics. E.g. setting an IP route without a suitable IP address is unlike to make sense, the tool must understand what it's doing. The same is true for the bond options. When a tool (or user) sets the "active_slave" property, then it must clear out the redundant information from the "primary" setting. There is no alternative to this problem than having tools smart enough to understand what they are doing.
| * libnm,core: deprecate "active_slave" and alias it for "primary"Thomas Haller2020-09-102-65/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting "active_slave" fails unless the slave is currently present and IFF_UP. That complicates the code, because we cannot set the property at any time, but only under the right circumstances. But really, "active_slave" option is something for debugging. It's not an option which should be set by NetworkManager. The right option instead is "primary", which will tell kernel to make the slave active, when it is ready. Deprecate the "active_slave" option and make it an alias for "primary". https://bugzilla.redhat.com/show_bug.cgi?id=1856640
| * device: cleanup code in NMDeviceBond's update_connection()Thomas Haller2020-09-101-10/+13
| |
| * tui: allow configuring "primary" bond option with "balance-{alb,tlb}"Thomas Haller2020-09-101-2/+5
| |
| * libnm: allow setting "primary" option with modes "tlb" and "alb"Thomas Haller2020-09-101-1/+3
| |
| * device: inline check_changed_options() in can_reapply_change()Thomas Haller2020-09-101-30/+26
| | | | | | | | | | | | | | | | | | Code doesn't get simpler by having more functions -- if these functions are only called once. What actually is a problem is repeated, redundant code. Like the list of bond options that can be reapplied. But the function didn't help to avoid repeating the list.
| * device: unify setting of bond optionsThomas Haller2020-09-101-27/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a macro for the list of bond options we are going to set. By seeing them side-by-side, it is hopefully simpler to see that all options are specified correctly. We see that: - the *_SUBSET defines don't include the options that we are explicitly setting, that is "mode", "active_slave" and "arp_ip_target". - OPTIONS_REAPPLY_SUBSET contains 4 options less than OPTIONS_APPLY_SUBSET: "ad_select", "ad_user_port_key", "lacp_rate" and "tlb_dynamic_lb". These are the options that are marked as BOND_OPTFLAG_IFDOWN in kernel.
| * device: remove duplicate option "primary" from list to reapplyThomas Haller2020-09-101-1/+0
| |
| * device: allow "active_slave" and "arp_ip_target" bond option for reapplyThomas Haller2020-09-101-41/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I guess the idea was to only accept options that can be changed without taking the interface !IFF_UP. "active_slave" is wrongly omitted from that list. Also, "active_slave" option doesn't really make sense for NetworkManager to configure. Instead "primary" should be used. In the future, we should re-map the properties and deprecate "active_slave" for "primary" ([1]). Fixes: 746dc119a6bc ('bond: let 'reapply()' reapply all supported options') [1] https://bugzilla.redhat.com/show_bug.cgi?id=1856640#c19 https://bugzilla.redhat.com/show_bug.cgi?id=1876577
| * shared: extend NM_IN_SET()/NM_IN_STRSET() macros to support up to 30 argumentsThomas Haller2020-09-101-0/+20
|/
* clients: set "ipv[46].dns-priority=-50" during import of WireGuard profilesThomas Haller2020-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | WireGuard's wg-quick primarily wants to avoid DNS leaks, and thus also our import code should generate profiles that configure exclusive DNS servers. This is done by setting "ipv[46].dns-priority" to a negative value. Note that if a profile leaves the DNS priority at zero (which in many regard is the default), then the zero translates to 50 (for VPN profiles) and 100 (for other profiles). Instead of setting the DNS priority to -10, set it to -50. This gives some more room so that the user can choose priorities that are worse than the WireGuard's one, but still negative (exclusive). Also, since the positive range defaults to 50 and 100, let's stretch the range a bit. Since this only affects import and creation of new profiles, such a change in behavior seems acceptable.
* device: fix wrongly considering ipv6.may-fail for ipv4Beniamino Galvani2020-09-091-1/+1
| | | | Fixes: 5e71f016057a ('device: merge stage3 and stage4 ip-config function for IPv4 and IPv6')
* build/meson: enable "more_asserts" only for devel buildsThomas Haller2020-09-082-1/+8
| | | | | | | | | | | | | more_asserts are our NetworkManager specific assertions, and the only point of having them at all (beside g_assert(), assert() and g_return*()), is that these assertions are disabled by default in production. meson always enabled them by default. That is definitely wrong. autotools enables more_asserts by default if we build a devel version from master. I think that is bad too, because (again) having these assertions disabled by default is the only point of having them. Anyway, mimic the behavior of autotools, to at least disable them in release builds.
* meson_options: fix suggested values for more_assertsJordan Petridis2020-09-081-1/+1
| | | | | | meson.build atm only handles, `no/all/int` https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/621
* build/docs: fix generated XML syntax in ↵Valentin David2020-09-081-2/+6
| | | | | | | | | | | tools/generate-docs-nm-settings-docs-gir.py Class description may contains double quotes which is not valid as XML attribute value. [thaller@redhat.com: adjust original patch to reformat code with python black] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/620
* tests: ignore valgrind warning about unhandled syscallsThomas Haller2020-09-071-3/+9
| | | | | | | | | | | | On Fedora rawhide (34), valgrind gives a lot of warnings like: ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- WARNING: unhandled amd64-linux syscall: 439 ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- You may be able to write your own handler. ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- Read the file README_MISSING_SYSCALL_OR_IOCTL. ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- Nevertheless we consider this a bug. Please report ./src/platform/tests/test-cleanup-linux.valgrind-log:--48279-- it at http://valgrind.org/support/bug_reports.html. Ignore them.
* build: fix test for valid po files (msgfmt -vc)Thomas Haller2020-09-071-3/+3
| | | | | | Otherwise, the test generates an "messages.mo" file. Fixes: 97c1bed37e46 ('build: add test for valid po files (msgfmt -vc)')
* device: enforce the absence of a master during activationbg/rh1869079Beniamino Galvani2020-09-071-9/+26
| | | | | | | | If the connection doesn't specify a master, ensure that the device is released from any master in platform. https://bugzilla.redhat.com/show_bug.cgi?id=1869079 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/616
* l3cfg: merge branch 'th/l3cfg-7'Thomas Haller2020-09-0710-137/+822
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/618
| * core: accept void pointer in nm_dbus_object_export() and relatedThomas Haller2020-09-072-28/+37
| | | | | | | | | | | | | | | | | | | | NMDBusObject is an abstract type which provides the glue code for exposing a GObject on D-Bus. We almost never use that type directly, so as it was before, we always had to use a C cast to convince the compiler that this is right. Being always required to cast is not very useful, nor more typesafe. Just use a void pointer instead.
| * l3cfg: add nm_l3cfg_commit_type*() API for tracking the level for committing ↵Thomas Haller2020-09-072-4/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | changes NML3Cfg manages one ifindex. In the future, we may want that multiple NMDevice and/or NMVpnConnection instances independently contribute their NML3ConfigData to the NML3Cfg instance. That means, at any time somebody may want to call nm_l3cfg_platform_commit() to apply the changes. Even ACD internally may do that, when configuration changes (e.g. an IP address passes ACD check). We thus need to know whether we are assuming, updating or reapplying the settings. Add API so users can register their "commit" preference.
| * l3cfg: add nm_l3_config_data_has_routes_with_type_local() helperThomas Haller2020-09-072-0/+60
| |
| * l3cfg: more integration of NMDevice with l3cfgThomas Haller2020-09-073-25/+338
| | | | | | | | | | Add more code that will be used later for glueing NMDevice with NML3Cfg and NML3ConfigData. The code is not yet really used.
| * l3cfg: remove changed flag from nm_l3cfg_add_config()/nm_l3cfg_remove_config()Thomas Haller2020-09-072-26/+33
| |
| * l3cfg: drop unused NM_L3_CONFIG_MERGE_FLAGS_EXTERNALThomas Haller2020-09-072-21/+0
| | | | | | | | | | | | The current approach also tracks external configuration in an NMIP[46]Config, and we need to special handle those. In the future, we only want to track what we actually want to configure. So this flag won't be used with NML3Cfg/NML3ConfigData.
View Lorry Controller Status