summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* examples: remove unused code from "examples/python/dbus/vpn.py"th/lgtm-com-fixes-1Thomas Haller2020-05-061-1/+0
| | | | | lgtm.com says "The value assigned to local variable all_connections is never used". Just drop the entire statement. It's not right there.
* examples: avoid "x == None" checks in python examplesThomas Haller2020-05-062-2/+2
| | | | lgmt.com says "Testing for None should use the is operator".
* examples: avoid "except" for BaseException in examplesThomas Haller2020-05-062-2/+2
| | | | lgtm.com flags this as "Except block directly handles BaseException".
* examples: avoid non-thread-safe localtime() function exampleThomas Haller2020-05-061-1/+6
| | | | Just to silence the warning on lgtm.com.
* examples: remove unused imports from python examplesThomas Haller2020-05-0612-13/+7
|
* examples: remove unused assignment in "examples/python/gi/wifi-p2p.py"Thomas Haller2020-05-061-1/+1
| | | | lgtm.com warns about this.
* libnm: remove unused import from "generate-setting-docs.py"Thomas Haller2020-05-061-1/+1
|
* libnm: fix redundant line constructing dbus_type_name_map in ↵Thomas Haller2020-05-061-1/+0
| | | | "generate-setting-docs.py"
* tests: add include guard to "nm-test-libnm-utils.h" headerThomas Haller2020-05-061-0/+5
| | | | It causes a warning on lgtm.com.
* config: avoid lgtm.com warning about int bitfield for ↵Thomas Haller2020-05-063-11/+15
| | | | | | | | | | | NMConfigDeviceStateData.nm_owned lgtm.com warns: int nm_owned:3; >> Bit field nm_owned of type int should have explicitly unsigned integral, explicitly signed integral, or enumeration type. So make it a NMTernary instead. It's nicer anyway.
* cli: avoid empty if block without a commentThomas Haller2020-05-063-0/+11
| | | | | | | | | lgtm.com flags this as "Empty block without comment". Avoid it. This code is of course ugly. Much work was already done to port such occurrences, and more is needed. I won't add a FIXME comment, because lgtm.com flags those too. :)
* cli: avoid redundant "if" check that is always TRUE in ↵Thomas Haller2020-05-061-1/+1
| | | | nmcli_editor_tab_completion()
* cli: avoid non-thread-safe localtime() function in nmcliThomas Haller2020-05-061-1/+3
| | | | | | | | Static analysis tools flag the use of localtime() because it is not thread safe. Of course, that was no problem here, but avoiding the warning is simple. Also, if we allocate 128 bytes, let strftime use it.
* ndisc: avoid static analysis complaining about overflow check in receive_ra()Thomas Haller2020-05-061-3/+3
| | | | | | | lgtm.com flags this. The check was there to be better safe than sorry. Also, it seems better to have code that shows what happens instead of a verbose code comment (or no comment at all). Anyway, avoid the false positive.
* acd: avoid alloca() inside an unbounded loopThomas Haller2020-05-061-2/+16
|
* libnm: fix gtk-doc annotations for nm_setting_match_get_interface_names()Thomas Haller2020-05-061-1/+2
| | | | | | Otherwise the function is not usable via generated bindings. Fixes: 9b9dce9486a8 ('all: add 'match' setting')
* device: avoid coverity warning about unused variableThomas Haller2020-05-062-7/+8
| | | | | | | | | | | | | | | | | This warning is from coverity against 1.18.6. But it applies in a similar manner here. 1. NetworkManager-1.18.6/src/devices/nm-device-macsec.c:811:25: warning: Value stored to 'priv' during its initialization is never read # NMDeviceMacsecPrivate *priv = NM_DEVICE_MACSEC_GET_PRIVATE (self); # ^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 4. NetworkManager-1.18.6/src/devices/nm-device-macsec.c:811:25: note: Value stored to 'priv' during its initialization is never read # NMDeviceMacsecPrivate *priv = NM_DEVICE_MACSEC_GET_PRIVATE (self); # ^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # 809| { # 810| NMDeviceMacsec *self = NM_DEVICE_MACSEC (object); # 811|-> NMDeviceMacsecPrivate *priv = NM_DEVICE_MACSEC_GET_PRIVATE (self); # 812| # 813| macsec_secrets_cancel (self);
* po: update Ukrainian (uk) translationYuri Chornoivan2020-05-061-542/+603
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/493
* initrd: merge branch 'bg/initrd-hostname'Beniamino Galvani2020-05-065-65/+197
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/419
| * man: initrd: describe differences from network-legacy moduleBeniamino Galvani2020-05-061-0/+28
| |
| * initrd: parse 'rd.net.timeout.dhcp' optionBeniamino Galvani2020-05-063-1/+14
| |
| * initrd: parse rd.peerdns earlyBeniamino Galvani2020-05-061-32/+18
| | | | | | | | | | | | Instead of generating connections and then apply the rd.peerdns to them, parse the option early and set it when each connection is created.
| * initrd: save hostname to a file in /runBeniamino Galvani2020-05-064-27/+108
| | | | | | | | | | | | | | Save the hostname read from command line to a file in /run so that it can be applied later by the NM dracut module. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/419
| * initrd: add command line option to specify initrd data directoryBeniamino Galvani2020-05-062-5/+29
|/
* device: fix scope of variable in commit_option()Thomas Haller2020-05-041-1/+1
|
* bridge: merge branch 'ac/bridge_options_2'Antonio Cardace2020-05-0410-127/+833
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/473
| * nm-setting-bridge: add 'multicast-startup-query-interval' bridge optionAntonio Cardace2020-05-048-0/+70
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-startup-query-count' bridge optionAntonio Cardace2020-05-048-0/+69
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-query-response-interval' bridge optionAntonio Cardace2020-05-048-145/+215
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-query-interval' bridge optionAntonio Cardace2020-05-048-0/+70
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-querier-interval' bridge optionAntonio Cardace2020-05-048-0/+70
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-membership-interval' bridge optionAntonio Cardace2020-05-048-0/+71
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-last-member-interval' bridge optionAntonio Cardace2020-05-048-110/+225
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-last-member-count' bridge optionAntonio Cardace2020-05-048-43/+115
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add 'multicast-hash-max' bridge optionAntonio Cardace2020-05-0410-0/+89
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
| * nm-setting-bridge: add missing 'Since: X.Y' comments to optionsAntonio Cardace2020-05-041-0/+10
|/ | | | https://bugzilla.redhat.com/show_bug.cgi?id=1755768
* po: update Ukrainian (uk) translationYuri Chornoivan2020-05-041-1193/+1272
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/489
* platform: fix test failure when /proc is mounted read-onlyBeniamino Galvani2020-05-041-24/+53
| | | | | Expect a failure when writing to /proc if the file system is mounted read-only.
* keyfile: merge branch 'th/keyfile-cleanup-accessors'Thomas Haller2020-05-043-119/+167
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/483
| * keyfile: implement nm_keyfile_plugin_kf_get_string_list() directly without macroThomas Haller2020-05-041-29/+26
| | | | | | | | There is only one user of the macro left. Drop it.
| * keyfile: add nm_keyfile_plugin_kf_get_integer_list_uint() to parse a list of ↵Thomas Haller2020-05-043-26/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | integers We had three callers of nm_keyfile_plugin_kf_get_integer_list(). Two only wanted to read values in range of guint8. One, wanted to read unsigned integers (for which nm_keyfile_plugin_kf_get_integer_list() was not suitable). Instead, implement a integer list reader ourself. One change is that g_key_file_get_integer_list() would accept list elements with a number followed by a white space and garbage ([1]). We don't do that, so there is a change in behavior here. That seems preferable, we don't want to accept garbage. The error reason text from the reader now also changes, and obviously we no longer fail for integer values larger than G_MAXINT. [1] https://gitlab.gnome.org/GNOME/glib/-/blob/c9bf247eb90805cc7a0020db20b8808ed42fe61c/glib/gkeyfile.c#L4445
| * keyfile: implement nm_keyfile_plugin_kf_set_string_list() directly without macroThomas Haller2020-05-041-14/+11
| | | | | | | | There is only one user of the macro left. Drop it.
| * keyfile: refactor writing of G_TYPE_ARRAY list of unsigned integersThomas Haller2020-05-043-17/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keyfile handles GObject properties of type G_TYPE_ARRAY as a GArray of unsigned ints. That is correct, because all our properties of this GType happen to be of this kind. However, then the function was using nm_keyfile_plugin_kf_set_integer_list(), which only can handle signed integers. There was thus an assertion that all integers were non-negative. Which, probably was also correct, because NMSettingDcb would validate that all values of such kind are in fact positive. Anyway, that is an unexpected limitation (if not a bug). Fix that by handling the array as unsigned list of integers. Also, since glib doesn't provide an API for storing lists of unsigend integers, we have to implement our own. but that is no loss. We probably do it better anyway.
| * keyfile: use NMStrBuf in nm_keyfile_plugin_kf_set_integer_list_uint8()Thomas Haller2020-05-042-15/+9
| | | | | | | | | | | | | | | | | | | | | | Previously, we were preallocating a string buffer of fixed size. For guint8 we reserved 3 characters per number, which is sufficient. However, it is not obviously sufficient. NMStrBuf would grow as needed. Next, I will add nm_keyfile_plugin_kf_set_integer_list_uint(), where it is more unclear how large the string can be at most. To avoid that question from the start, it will use NMStrBuf. To keep the implementations similar, use NMStrBuf also in this case.
| * keyfile: refactor defining keyfile list getter/setter functionsThomas Haller2020-05-041-21/+24
| |
| * keyfile: refactor defining keyfile getter/setter functionsThomas Haller2020-05-041-20/+24
|/ | | | | | | | | | | | | | Split the macros to define the setter and getter so that setters and getters are defined by separate macros. This will be used to define the boolean getter differently, but still using the macro to define the setter. Also, don't construct function names in the macro. Instead, pass the full names as argument to the macro. This helps with the problem where ctags/cscope is unable to locate the implementation of the function. Since we define the function with macro, the tools still don't recognize this as the location of the definition. But at least when showing all occurrences of the name, it can be found.
* libnm: avoid compiler warning about uninitalized variable in ↵Thomas Haller2020-05-031-3/+5
| | | | | | | | | | | | | | | | | | | | | | nm_setting_bridge_port_remove_vlan_by_vid() With LTO, compiler warns: libnm-core/nm-setting-bridge-port.c: In function nm_setting_bridge_port_remove_vlan_by_vid: libnm-core/nm-setting-bridge-port.c:252:6: error: v_start may be used uninitialized in this function [-Werror=maybe-uninitialized] 252 | if (v_start == vid_start && v_end == vid_end) { | ^ libnm-core/nm-setting-bridge-port.c:239:10: note: v_start was declared here 239 | guint16 v_start, v_end; | ^ libnm-core/nm-setting-bridge-port.c:252:28: error: v_end may be used uninitialized in this function [-Werror=maybe-uninitialized] 252 | if (v_start == vid_start && v_end == vid_end) { | ^ libnm-core/nm-setting-bridge-port.c:239:19: note: v_end was declared here 239 | guint16 v_start, v_end; | ^ Avoid the (false positive) warning.
* nm-online: fix build of nm-online for missing libcsiphash.laThomas Haller2020-05-021-0/+1
| | | | Fixes: e468b48ab7b8 ('nm-online: allow configuring timeout via NM_ONLINE_TIMEOUT environment')
* dispatcher: merge branch 'th/dispatcher-doc-connectivity-change-arg'Thomas Haller2020-04-302-12/+15
|\ | | | | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/485
| * dispatcher: minor cleanup error paths in script_dispatch()Thomas Haller2020-04-301-9/+8
| | | | | | | | Handle the error case first and return early.
View Lorry Controller Status