From a73efb059f5ffdcc200ec30c443d06b6d656fcfe Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Thu, 21 Nov 2019 18:05:11 +0100 Subject: manager: don't activate device if the parent is missing In multiple places we currently proceed to creating a virtual device even if the connection specifies a parent device which is missing. This can be easily reproduced with: nmcli con add type vxlan ifname vxlan1 \ vxlan.parent not-exists \ id 43 remote 172.25.1.1 which creates a vxlan1 interface without activating any connection. Add a check to prevent this. https://bugzilla.redhat.com/show_bug.cgi?id=1774074 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/344 --- src/nm-manager.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/nm-manager.h') diff --git a/src/nm-manager.h b/src/nm-manager.h index 1c71736bcd..ad06e318f4 100644 --- a/src/nm-manager.h +++ b/src/nm-manager.h @@ -149,6 +149,7 @@ void nm_manager_device_route_metric_clear (NMManager *self, char * nm_manager_get_connection_iface (NMManager *self, NMConnection *connection, NMDevice **out_parent, + const char **out_parent_spec, GError **error); const char * nm_manager_iface_for_uuid (NMManager *self, -- cgit v1.2.1