From 33f019a5bf9901048822f7cc1701603d4087cf99 Mon Sep 17 00:00:00 2001 From: Lv Zheng Date: Mon, 23 May 2016 23:06:54 +0800 Subject: Applications: Fix a potential issue that help messages may be dumped to AcpiGbl_DebugFile There is an issue for usage macros, if an command line option changed AcpiGbl_DebugFile, then the follow up usage may errornously dumped to the debug file. This is just a bug in theory, because currently AcpiGbl_DebugFile can only be modified by acpibin and acpiexec. Currently this will not trigger such issue because: 1. For acpibin, AcpiGbl_DebugFile will be modified by "-t" option and the program exit after processing this option without dumping help message or other error options. 2. For acpiexec, AcpiGbl_DebugFile will only be modified by the open command, which happens after parsing the command line options, so no help message will be dumped into the debug file. But maintaining this logic is difficult, so this patch modifies AcpiOsPrintf() into printf() for usage macros so that the help messages are ensured to be dumped to the stdout. Lv Zheng. Signed-off-by: Lv Zheng --- source/include/acapps.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/include/acapps.h b/source/include/acapps.h index 8699dcbba..f8b7bd0b3 100644 --- a/source/include/acapps.h +++ b/source/include/acapps.h @@ -151,13 +151,13 @@ /* Macros for usage messages */ #define ACPI_USAGE_HEADER(Usage) \ - AcpiOsPrintf ("Usage: %s\nOptions:\n", Usage); + printf ("Usage: %s\nOptions:\n", Usage); #define ACPI_USAGE_TEXT(Description) \ - AcpiOsPrintf (Description); + printf (Description); #define ACPI_OPTION(Name, Description) \ - AcpiOsPrintf (" %-20s%s\n", Name, Description); + printf (" %-20s%s\n", Name, Description); /* Check for unexpected exceptions */ -- cgit v1.2.1