diff options
| author | Piotr Maziarz <piotrx.maziarz@linux.intel.com> | 2020-08-31 11:08:55 +0200 |
|---|---|---|
| committer | Jaroslav Kysela <perex@perex.cz> | 2020-08-31 13:03:01 +0200 |
| commit | 346a5efa87c38a0d5ff9bd5b5d08be27b6c9bfaf (patch) | |
| tree | 56e3f5231252db9f872c1985c8ee8f8d06625b32 | |
| parent | 1ac965184eaefe503939e454273223a1d8d32f41 (diff) | |
| download | alsa-lib-346a5efa87c38a0d5ff9bd5b5d08be27b6c9bfaf.tar.gz | |
topology: decode: Fix infinite loop in decoding enum control
Accessing memory outside of allocated boundaries caused segmentation fault.
Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
| -rw-r--r-- | src/topology/ctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/topology/ctl.c b/src/topology/ctl.c index 6e6c1d16..0aa49ab8 100644 --- a/src/topology/ctl.c +++ b/src/topology/ctl.c @@ -1367,7 +1367,7 @@ int tplg_decode_control_enum1(snd_tplg_t *tplg, et->texts = tplg_calloc(heap, sizeof(char *) * ec->items); if (!et->texts) return -ENOMEM; - for (i = 0; ec->items; i++) { + for (i = 0; i < ec->items; i++) { unsigned int j = i * sizeof(int) * ENUM_VAL_SIZE; et->texts[i] = ec->texts[i]; et->values[i] = (int *)&ec->values[j]; |