summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Shrewsbury <shrewsbury.dave@gmail.com>2015-06-10 18:06:11 -0400
committerMonty Taylor <mordred@inaugust.com>2015-07-06 18:50:03 -0400
commit5b6c6cac20bc6e1111e0175b2e77c7c3f61a69b5 (patch)
treead6265655719a40d6584f5e6ab3980209c3ea225
parent5758b4ebdce00bbd18ef8e6967122ebcc6de0cde (diff)
downloadansible-modules-core-5b6c6cac20bc6e1111e0175b2e77c7c3f61a69b5.tar.gz
Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the neutron style) rather than -1. Recognize this as the same as -1.
-rw-r--r--cloud/openstack/os_security_group_rule.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/cloud/openstack/os_security_group_rule.py b/cloud/openstack/os_security_group_rule.py
index 287f3021..64f67fbe 100644
--- a/cloud/openstack/os_security_group_rule.py
+++ b/cloud/openstack/os_security_group_rule.py
@@ -87,9 +87,12 @@ def _security_group_rule(module, nova_client, action='create', **kwargs):
def _get_rule_from_group(module, secgroup):
for rule in secgroup['security_group_rules']:
+ # No port, or -1, will be returned as None
+ port_range_min = rule['port_range_min'] or -1
+ port_range_max = rule['port_range_max'] or -1
if (rule['protocol'] == module.params['protocol'] and
- rule['port_range_min'] == module.params['port_range_min'] and
- rule['port_range_max'] == module.params['port_range_max'] and
+ port_range_min == module.params['port_range_min'] and
+ port_range_max == module.params['port_range_max'] and
rule['remote_ip_prefix'] == module.params['remote_ip_prefix']):
return rule
return None