diff options
author | Dag Wieers <dag@wieers.com> | 2016-11-17 15:53:43 +0100 |
---|---|---|
committer | Toshio Kuratomi <a.badger@gmail.com> | 2016-11-17 13:33:13 -0800 |
commit | 5275b509044a30887d58ff4a70d5c52e3a29ca5c (patch) | |
tree | ebe5261b96aac1f1e9d851c19c190ad32016daba | |
parent | 7241d0f67ab7e269d123d7281982fc3ff60e1642 (diff) | |
download | ansible-modules-core-5275b509044a30887d58ff4a70d5c52e3a29ca5c.tar.gz |
Performance improvement using in-operator for hash lookups
Just a small cleanup for the existing occurrences.
Using the in-operator for hash lookups is faster than using .has_key()
http://stackoverflow.com/questions/1323410/has-key-or-in
(cherry picked from commit c411d518b96f373931119af0c4cd1799fcb86499)
-rw-r--r-- | packaging/os/rhn_register.py | 2 | ||||
-rw-r--r-- | system/user.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/packaging/os/rhn_register.py b/packaging/os/rhn_register.py index f30cf090..f5ee2982 100644 --- a/packaging/os/rhn_register.py +++ b/packaging/os/rhn_register.py @@ -149,7 +149,7 @@ class Rhn(RegistrationBase): def get_option_default(self, key, default=''): # ignore pep8 W601 errors for this line # setting this to use 'in' does not work in the rhn library - if self.has_key(key): + if key in self: return self[key] else: return default diff --git a/system/user.py b/system/user.py index ab2c4be2..38fc51f3 100644 --- a/system/user.py +++ b/system/user.py @@ -1693,7 +1693,7 @@ class DarwinUser(User): self.chown_homedir(int(self.uid), int(self.group), self.home) for field in self.fields: - if self.__dict__.has_key(field[0]) and self.__dict__[field[0]]: + if field[0] in self.__dict__ and self.__dict__[field[0]]: cmd = self._get_dscl() cmd += [ '-create', '/Users/%s' % self.name, field[1], self.__dict__[field[0]]] @@ -1730,7 +1730,7 @@ class DarwinUser(User): self._make_group_numerical() for field in self.fields: - if self.__dict__.has_key(field[0]) and self.__dict__[field[0]]: + if field[0] in self.__dict__ and self.__dict__[field[0]]: current = self._get_user_property(field[1]) if current is None or current != self.__dict__[field[0]]: cmd = self._get_dscl() |