summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Fix authorized_key module to preserve the order of options"revert-5329-fix-authorized_key-random-hashToshio Kuratomi2016-10-201-61/+31
|
* Fix authorized_key module to preserve the order of optionsToshio Kuratomi2016-10-201-31/+61
| | | | | | | | | | | | | | | | The last fix allowing multiple definitions of the same option key (for permitopen support) introduced a set() which removed the guaranteed ordering of the options. This change restores ordering. The change is larger than simply removing the set because we do need to handle the non-dict semantics around keys not being unique in the data structure. The new code make use of __setitem__() and items() to do its work. Trying to use getitem() or keys() should be looked upon with suspicion as neither of those follow dictionary semantics and it is quite possible the coder doesn't realize this. The next time we need to touch or enhance the keydict code it should probably be rewritten to not pretend to extend the dictionary interface.
* Add separate checkout and update parameters (#5306)Matthew Jones2016-10-201-3/+38
| | | | | | | | | | | | | * Add separate checkout and update parameters This brings the svn module in line with the git module for controlling individual update and checkout functionality based on whether the directory exists or not. It also allows specifying `no` for both to pull the remote revision without performing a checkout * Update version-added for new parameters
* Add separate clone parameter (#5307)Matthew Jones2016-10-201-5/+36
| | | | | | | | | | | | | * Add separate clone parameter This brings the hg module in line with the git module for controlling individual update and checkout functionality based on whether the directory exists or not. It also allows specifying `no` for both to pull the remote revision without performing a checkout * Reflect the right added ver for the hg clone arg
* Remove unused YAML import from cloudformationRyan S. Brown2016-10-191-1/+0
|
* Support native YAML in CloudFormation module (#5327)Ryan Brown2016-10-191-9/+6
| | | | | Support the new native YAML format in the CloudFormation API. This means the existing `template_format` parameter is deprecated. This commit also adds a warning for the deprecated parameter.
* Typo in cleanup (#5322)John R Barker2016-10-191-1/+1
|
* Fix incorrect line wrapping in output from yum check-updatesFilip Hubík2016-10-191-0/+2
| | | | https://github.com/ansible/ansible-modules-core/issues/4318#issuecomment-251416661
* Run validate-modules from ansible/ansible@devel (#5257)John R Barker2016-10-191-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Run validate-modules from devel Use a clean dir for checkout typo Correct path validate-modules requires mock and voluptuous==0.8.8 typo Ensure script is running Remove testing debug Install Ansible only once Install ansible and validate_modules requirements Now that we no longer pip install Ansible we need to manually install it's dependencies Debug Dependencies are listed in ansible/ansible debug submodules typo typo working * Matt's feedback * Use mktemp to checkout and delete directory after running * Single quotes
* fix unclear documentation for docker containerDaniel Andrei Minca2016-10-191-1/+2
| | | | | | | | | | the docker container module's `exposed_ports` was slightly ambigous. Use the official Docker documentation to define what an `exposed port` is. Resolves: ansible/ansible-modules-core#5303 Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
* Fix code for python 3Michael Scherer2016-10-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | Since dict.keys return a dictkeys under python 3, we hav to cast it to a list to avoid traceback: Traceback (most recent call last): File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 496, in <module> main() File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 490, in main results = enforce_state(module, module.params) File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 410, in enforce_state parsed_new_key = parsekey(module, new_key) File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 308, in parsekey options = parseoptions(module, options) File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 259, in parseoptions options_dict[key] = value File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 164, in __setitem__ self.itemlist.append(key) AttributeError: 'dict_keys' object has no attribute 'append' Yet another fix for https://github.com/ansible/ansible/pull/18053
* cleanup import for htpassword moduleMichael Scherer2016-10-191-1/+2
| | | | | In order to ease future refactoring, we should avoid importing '*' from ansible.module_utils.basic.
* Cleanup import for authorized_keyMichael Scherer2016-10-191-2/+3
| | | | | Do not import '*', to ease future refactoring and cleanup of module_utils.
* Fix cloudformation module return parameter documentationRyan S. Brown2016-10-191-28/+34
| | | | Always return stack outputs, even if only an empty dict
* Cloudformation module fix unintentional changed=truetedder2016-10-191-7/+8
| | | | | - Don't rewrite the result; this is causing 'changed=true' on update - Move AWSRetry import to top since it's a decorator, and is needed at definition-time
* Boto3 rewrite of cloudformation moduletedder2016-10-191-142/+216
| | | | | | | | | | | | - removed star-imports, which wasn't possible in Ansible 1.x - boto doesn't have any of the modern features (most notably, changesets), so this rewrite goes all-in on boto3. - tags are updateable, at least in boto3. Fix documentation. - staying with "ansible yaml to json conversion" because I'm trying to keep this scoped properly. The next PR will have AWS-native yaml support. - documented the output. Tried to leave it backwards-compatible but the changes to 'events' might break someone's flow. However, the existing data wasn't terribly useful so I don't assume it will hurt. - split up the code into functions. This should make unit testing possible. - added forward-facing code: 'six' for iterating, started using AWSRetry, common tag conversion. - add todo list - Pass `exception` parameter to fail_json
* Cleanup imports of xattrMichael Scherer2016-10-191-2/+4
| | | | | | | Since the module use re and os, we need to import them. And rather than importing '*', we should limit to the only object/function needed, so we can more easily refactor later.
* Ensure yum failures in with-loop result into a failed taskDag Wieers2016-10-181-7/+15
| | | | | | The implementation is fairly simple, we force the rc= parameter to not be zero so that the check in _executor/task_result.py_ correctly determines that it failed. Without this change Ansible would report the task to be ok (despite failed=True and msg=Some_error_message) although Ansible stops and the summary output reports a failed task. This fixes #4214, #4384 and also relates to ansible/ansible#12070, ansible/ansible#16006, ansible/ansible##16597, ansible/ansible#17208 and ansible/ansible#17252
* verify both tags and commits (#2654)Jamie Evans2016-10-181-1/+5
| | | This fixes a bug where the module fails to verify tags. I added a conditional statement in `verify_commit_sign()` that checks if `version` argument is a tag, if so, use `git verify-tag` instead.
* fixed doc typoBrian Coca2016-10-181-3/+0
|
* added allow_duplicates to include_role docsBrian Coca2016-10-181-0/+5
|
* added allow_duplicates to include_role docsBrian Coca2016-10-181-1/+4
|
* Make the code run on python 3Michael Scherer2016-10-181-1/+1
| | | | | | | | | | | | | | | | | | | Test suite block on: Traceback (most recent call last): File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 496, in <module> main() File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 490, in main results = enforce_state(module, module.params) File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 410, in enforce_state parsed_new_key = parsekey(module, new_key) File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 308, in parsekey options = parseoptions(module, options) File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 253, in parseoptions if options_dict.has_key(key): AttributeError: 'keydict' object has no attribute 'has_key' With keydict being a subclass of dict.
* Group "apt-get update" and "apt-get install" (#5283)John R Barker2016-10-181-3/+3
| | | | | | | | * Group "apt-get update" and "apt-get install" Should speed up sanity * Run apt-get install in quiet mode
* Make pip module use pip3 on python 3Michael Scherer2016-10-171-2/+12
|
* Make subversion module work on python 3Michael Scherer2016-10-171-1/+1
| | | | | | | | | | | | | In python 3, filter return a iterator and so result in this traceback: Traceback (most recent call last): File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 264, in <module> main() File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 243, in main local_mods = svn.has_local_mods() File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 178, in has_local_mods return len(filter(regex.match, lines)) > 0 TypeError: object of type 'filter' has no len()
* Remove the wide try/expect clauseMichael Scherer2016-10-171-18/+15
| | | | | This doesn't catch anything precise, and none of the methods should throw a expection for anything. This also hide python 3 errors.
* Fix `fail_json` invocation in `cloudformation` moduleRyan S. Brown2016-10-171-1/+1
|
* Move job parameter to meet expected requirements (#5151)Steven de Vries2016-10-171-1/+1
| | | closes #5273
* Refactor domain/project handling on os_user module (#5212)Ricardo Carrillo Cruz2016-10-171-26/+39
| | | | | | | | The keys returned by user objects for default domain and default project are respectively default_domain_id and default_project_id. We need to gather those IDs in case the user passed names, so we can then compare with the user object on the needs_update helper function.
* apt: doc: use yaml syntax in examples (#5070)Alfredo Solano2016-10-171-38/+64
|
* Fix unarchive on python3Michael Scherer2016-10-151-2/+4
| | | | | | | Since handler.files_in_archive is a list of files coming from various executables output, that's a bytes list, and we use it with dest who is a str. So we need to convert that to native type.
* Convert name to bytes to compare it to boolsMichael Scherer2016-10-151-1/+2
| | | | | | | | | | On python 3, bools is a list of bytes: >>> rc,bools = selinux.security_get_boolean_names() >>> 'virt_use_nfs' in bools False >>> bools [b'abrt_anon_write', b'abrt_handle_event', ...]
* vsphere_guest: Set extra config and powerstate after template deploy (#4266)Davis Phillips2016-10-131-1/+13
| | | | | * Fixes #1381 * Fixes #2971 * Fixes #3056
* Do not leak the password in log (#5189)Michael Scherer2016-10-131-1/+1
|
* Do not leak the vtp_password in log (#5199)Michael Scherer2016-10-131-1/+1
|
* Do not leak the subversion password in log (#5200)Michael Scherer2016-10-131-1/+1
|
* Do not leak various passwords in log (#5202)Michael Scherer2016-10-131-2/+2
|
* Do not leak the password in log (#5203)Michael Scherer2016-10-131-1/+1
|
* Do not leak api_key or root password in log (#5201)Michael Scherer2016-10-131-2/+2
|
* fixes bug introduced in 3670215 in junos_config (#5251)Peter Sprygada2016-10-131-1/+3
| | | The previous fix created a new bug that this PR resolves
* Bulk spelling improvement to modules-core (#5225)John R Barker2016-10-1391-146/+147
| | | | | | | | | | * Correct spelling mistakes * Correct more spelling issues * merge conflict * Revert typo in parms
* Added libcloud guard for Managed Instance Groups. (#4911)Tom Melendez2016-10-131-3/+7
|
* GCE module examples update. Correct syntax, demonstrate other options and ↵Tom Melendez2016-10-131-84/+96
| | | | creation of multiple instances. (#5192)
* fixes issue with collecting all filesystems in ios (#5248)Peter Sprygada2016-10-131-2/+2
| | | | | | earlier versions of ios do not provide the all-filesystems argument. This fix will now only report on the flash filesystem for ios_facts fixes #4712
* ios_config will now explicitly disconnect from remote host (#5247)Peter Sprygada2016-10-121-0/+2
| | | | | | The ios_config module will now explicitly send a disconnect to the remote host at the conclusion of the module run ref #5181
* Update pn_vlan (#5223)amitsi2016-10-121-2/+0
| | | removed name from an older file which got left out
* removes automated backup of ios to flash due to errors (#5245)Peter Sprygada2016-10-121-20/+0
| | | | The feature is extremely unstable right now and decision to pull it out for 2.2. Workaround is to do the same in the playbook
* fixes issue with pushing config to versions that do not support sessions (#5236)Peter Sprygada2016-10-121-2/+9
| | | | | | | earlier versions of eos do not support configuration sessions. this change will now check if sessions are supported and if not will fallback to not using config sessions fixes #4909
* Correct functional typosJohn Barker2016-10-117-7/+7
|
View Lorry Controller Status