summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix authorized_key crash in Python3 with remote key file (#20037)temp-post-2.2.1-stagingJames Cooke2017-01-091-0/+4
| | | | | | | * Decode downloaded keys bytes if Python3 * Fixes #20007 * Thanks @georgepsarakis (cherry picked from fafe5bba59163c525b82b6eaf12d0d4627a79bf7)
* Do not use the fstab parameter on openbsd for mounting (#5805)Toshio Kuratomi2017-01-091-17/+34
| | | | | | | | | | | | * Do not use the fstab parameter on openbsd for mounting OpenBSD's mount command doesn't allow selecting which fstab file to use. So if we're operating on the live filesystem (mount or remount) return an error if the user specified an fstab file. Fixes #5591 * Fix the logic inversion (thanks to @landryb)
* Check the command result status in easy_install plugin (#16519)THEBAULT Julien2017-01-041-0/+2
| | | | (cherry picked from ee1dee08b60feb31282b3402b8b6bff30a599d6c)
* Fix #19189 django_manage bug with python3 filter() returning iterator insted ↵Serhiy Martynenko2017-01-031-1/+1
| | | | | | of list (cherry picked from c7637992fe957a5ebcc6059d99d8bad873a8d8ba)
* git ssh wrapper: py3-compatability with stringstedder2017-01-031-2/+2
| | | | | | | | | | | | | | | | Wrap the fh.write(str) in b() to ensure the string is of the proper type in py2/py3. Otherwise, the following error occurs when using its ssh_wrapper: An exception occurred during task execution. The full traceback is: Traceback (most recent call last): File "/tmp/ansible_8r299r6t/ansible_module_git.py", line 1049, in <module> main() File "/tmp/ansible_8r299r6t/ansible_module_git.py", line 928, in main ssh_wrapper = write_ssh_wrapper() File "/tmp/ansible_8r299r6t/ansible_module_git.py", line 330, in write_ssh_wrapper fh.write(template) TypeError: 'str' does not support the buffer interface (cherry-picked from 15e12d2cf2f3f1449d1b044fd191f0862e19f557)
* Change the keydict object in authorized_keys so it doesn't throw a false ↵Toshio Kuratomi2016-12-141-4/+4
| | | | | | | | | | positive keydict is a bad data structure anyway. We don't use the iteritems and itervalues methods so just disable them so that the code-smell tests do not trigger on it. (cherry picked from 0b440a928908b6b8c973a16f6fc7b26f893cce04)
* Fix UnboundLocalError remote_head in git (#19057)Toshio Kuratomi2016-12-141-21/+14
| | | | | | | | | | | | | | | | | | | | * Fix UnboundLocalError remote_head in git Fixes #5505 The use of remote_head was a leftover of #4562. remote_head is not necessary, since the repo is unchanged anyway and after is set correctly. Further changes: * Set changed=True and msg once local_mods are detected and reset. * Remove need_fetch that is always True (due to previous if) to improve clarity * Don't exit early for local_mods but run submodules update and switch_version * Add test for git with local modifications (cherry picked from afca95739630891d5678d362362877270ae2e80e)
* New release v2.2.1.0-0.2.rc2James Cammarata2016-12-141-1/+1
|
* Remove itervalues (not available on py3)Toshio Kuratomi2016-12-131-2/+2
| | | | (cherry picked from 51491c990444be4153d8d4e07ced00f8af348ddd)
* This is for py3 compatibility, addressed in #18506Andrea Tartaglia2016-12-1269-197/+198
| | | | (cherry picked from ef391a11ec536d0efb1b59e8139735b27b67c67f)
* use 'six' for urlparse compatability (#5777)Ted Timmons2016-12-011-1/+1
| | | | | | * use 'six' for urlparse compatability (cherry picked from commit edcbc2410ab6b90b79f809fc91d4d9ea7f57bb2b)
* systemd: Start inactive units for reload/restartDustin C. Hatch2016-11-301-1/+4
| | | | | | | | | | The `service` module starts services that are not running when `action=restarted` or `action=reloaded`, which is especially convenient for initial deployments because it eliminates an extraneous operation for when the service starts for the first time. This commit adjusts the behavior of the `systemd` module to match. (cherry picked from commit 286021056f9700ab58fae92d03d9555300aef580)
* Fix test failures in win_command/win_shell on Powershell 3Matt Davis2016-11-292-2/+2
| | | | | | Switched to use Exit-Json to avoid JSON escaping bugs in ConvertTo-Json formatter without -Compress option. (cherry picked from commit 6890003c4f8dcd8f63a5b280211068cfaf1dcc35)
* mysql_user: fix user_mod on MySQL(-like) 5.7+ (Fixes #3003) (#5388)Wouter Oosterveld2016-11-291-1/+1
| | | | (cherry picked from commit 30fb384e7fb9a94ac3929e4a650877e45d8834c9)
* added docs for use optionBrian Coca2016-11-241-0/+6
|
* Force BSDs to use umount/mount instead of trying to use remount. (#5715)Toshio Kuratomi2016-11-231-3/+13
| | | | | | | | | | * Force BSDs to use umount/mount instead of trying to use remount. Fixes #5591 * Initialize out and err (cherry picked from commit 90a92f17fae8fab2a45da3ec1762a4bd489d8b0a)
* systemctl show rc changes across versionsBrian Coca2016-11-231-33/+30
| | | | | | | | | to avoid different errors across versions, ignore rc in favor of found/notfound fixes #5710 (cherry picked from commit aa0cad528adcdc5cd3f69cb257ae54644090eb91)
* Fall back if mountinfo reading failed (fixing #5603)Jiri Tyr2016-11-231-2/+7
| | | | (cherry picked from commit 351dd9344e4f9c41d47ba574f554eb16c15c2ce2)
* Improve `ec2` module Python3 Support (#5497)Zaius Dr2016-11-221-5/+7
| | | | | Imported six module from ansible module_utils for backwards compatibility. (cherry picked from commit 135c70bdd8c9398fa0e716602d940edc5c82183f)
* ported iterkeys to py3 syntax (#5657)Andrea Tartaglia2016-11-221-3/+4
| | | | | | | | | | | | * ported iterkeys to py3 syntax Addresses ansible/ansible#18507 * Use ansible.module_utils.six.moves iterkeys instead of dict.keys() * Removed 'iterkeys' (cherry picked from commit ff9bf54891945b90d1a1008274774b6eeeb06bf2)
* Ensure proper error when fetch_url returns status -1Dag Wieers2016-11-211-1/+5
| | | | | | | | | When using a file:// or ftp:// URL the normal provisions that a non-200 status code means error have been disabled. But the common error status -1 from fetch_url is not properly returning an error message. This fix ensures that if the status code returns -1, we return a proper error message. This fixes #3563 (cherry picked from commit 7903b39fc0c1e7559c98b838e4da5bc157a24412)
* Set b_src to abspath of b_path so that symlinks work again. (#5678)jctanner2016-11-211-0/+1
| | | | | Fixes #5653 (cherry picked from commit 3acd6f45194e6248518aee6d600798c8d0d57b4d)
* New release v2.2.1.0-0.1.rc1James Cammarata2016-11-181-1/+1
|
* Fix for call to umount() in remount()Toshio Kuratomi2016-11-181-1/+1
| | | | (cherry picked from commit 5c986306be5fa357eb64036915ab5eb98ad17327)
* try remount but fallback to unmount + mount (#2445)Brian Coca2016-11-181-8/+36
| | | | | | | | | | | | | | | | * allow mount to try remount falls back to unmount/mount * fixed fstab handling and switched to ismount custom function deals with bind mounts unlike built in * un ** args * last ** args (cherry picked from commit 9b09acc549c4422a8c4e93216136b8f5379ebe47)
* Fix wait_for Module to handle socket response as string in Python3zaiusdr2016-11-181-1/+3
| | | | | | | In Python3 socket module returns responses as bytes type. So it's necessary to convert it to string for the module work correctly. (cherry picked from commit 7ed1af0a6d3f5e852a21aeb0b310ec71fddb2b28)
* Prevent handle inheritance from blocking Windows async_wrapper (#5666)Matt Davis2016-11-181-1/+1
| | | | (cherry picked from commit 9724ed77defa17808d264ed339ec775def0ea419)
* Several systemd fixesBrian Coca2016-11-181-44/+59
| | | | | | | | | | | Allow some operations on missing services Better sysv handling Rearranged error reporting fixed load error catching and order logic also minor doc/comment updates added warnings (cherry picked from commit b835ae271734821c8e41ce8cd278a01266a2247b)
* Revert "ios_mods - added stdout to exception output. Removed to_lines()" (#5663)Peter Sprygada2016-11-182-4/+9
| | | | (cherry picked from commit 89b47ae7964adcd09598690092b8194f63030045)
* Clarify the commentToshio Kuratomi2016-11-171-2/+2
| | | | (cherry picked from commit 2a9ddb1c70cab02af8341f674265384af250452b)
* Older versions of rhn-client-tools don't understand containment tests.Toshio Kuratomi2016-11-171-3/+4
| | | | (cherry picked from commit d3543ff67c788531cadfcaee19395bbb70125364)
* Performance improvement using in-operator for hash lookupsDag Wieers2016-11-172-3/+3
| | | | | | | | | Just a small cleanup for the existing occurrences. Using the in-operator for hash lookups is faster than using .has_key() http://stackoverflow.com/questions/1323410/has-key-or-in (cherry picked from commit c411d518b96f373931119af0c4cd1799fcb86499)
* Ini_file: fix regression with the create optionGyorgy Szombathelyi2016-11-141-4/+4
| | | | | | | | | The new create option with the default value 'no' changes the behavior from the previous Ansible releases. Change the default to 'yes' to create missing ini files by default. Fixes: #5488 (cherry picked from commit 4863335cfac0266dca8e0e92157c57019546fb61)
* stat: doc: add version for new returns (#5594)René Moser2016-11-141-3/+3
| | | | (cherry picked from commit 8c762d7b02f0b904da7dade882e0588fb5e97f13)
* Make service work when the service is not present in rc.confMichael Scherer2016-11-081-2/+4
| | | | | | | | | | | | After installing a package from the ports collection on a fresh FreeBSD 11.0, Ansible was unable to enable it, failing with "unable to get current rcvar value". Debugging showed that sysrc didn't see the variable from /usr/local/etc/rc.d/myservice, but adding the value was working. So we will just fallback to the default value if we can't find it. (cherry picked from commit 872594b49a69a1f3795e0de3f7cf0194b6bdfd53)
* Updated documentation for PR http://github.com/ansible/ansible/pull/17207Allen Sanabria2016-11-081-5/+47
| | | | (cherry picked from commit 375aa92315961a75032d13d02315e94ae6a4377e)
* fix parsing show module command for 9372 (#5485)Jason Edelman2016-11-071-0/+2
|
* ios_mods - added stdout to exception output. Removed to_lines() (#5428)bdowling2016-11-072-9/+4
| | | | | | | | | | | | | | stdout lines are now available when certain exceptions occur (Ref ansible/ansible#18241) Also noticed that to_lines was essentially handled in lib/ansible/plugins/action/__init__.py -- only difference was it didn't handle a list. to_lines() could be removed across network modules now, but this commit is only for ios_command. Also adds disconnect() to ios_command that was added to ios_config in #5247 (cherry picked from commit 933f508cfa050c79d8e36b2624ddb2d0eea26739)
* Adding missing param (#5447)Gabriele2016-11-071-1/+1
|
* nxos_snmp_community bugfix (#5450)Gabriele2016-11-071-198/+100
| | | | | | * Fixing pr * Fix param name
* Fixing module (#5451)Gabriele2016-11-071-3/+2
|
* apt: fix changed when cache updated but not pkg (#5487)René Moser2016-11-061-6/+0
|
* ios_facts module will no longer error on missing command (#5491)Peter Sprygada2016-11-031-60/+56
| | | | | | | | | | | | | | The module will error if it tries to use a cli command that is not available on a given platform. This fix will address that problem. If the cli command is not available, then the command is silently discarded and the facts that the command output is based on is not returned. Any failed commands are provided in the module return under the failed_commands key. This fix also updates the Examples docstring to make it consistent with other ios_* modules fixes #5444 fixes #5372 (cherry picked from commit be846c0995c1052929977ef2fd92b78e4852bad1)
* fix the behavior that the dest is directoryzuiurs2016-11-031-6/+7
| | | | | | | | | This fixes the behavior that the dest is directory, when we set the "force: no" argument. To be join the dest and the src's basename, before checking the "force" argument. (cherry picked from commit cb1d90ccfd2f3ed62fc8fb1e6620463f5c9c15fe)
* make sure all svcadm operations are syncronousBrian Coca2016-11-011-2/+2
| | | | | | fixes #5296 (cherry picked from commit ebcc46fa27de3a62904cd85392b50598271905d2)
* fix JSON junk in win_file state=directory caseMatt Davis2016-11-011-1/+1
| | | | (cherry picked from commit fdf92ade263474ddde48ddc306fd56de47e610ec)
* Record existing cron file as string property, rather than only recording ↵Evan Kaufman2016-11-011-9/+11
| | | | | | | | termination This seems less hackish, and feels more proper for diff generation (cherry picked from commit b0c94e957ecffad4d96ec6c8723289a7cd2807e9)
* Rendering of crontab should reflect actual newline termination, in diff modeEvan Kaufman2016-11-011-3/+3
| | | | (cherry picked from commit 7c9401a7ff4e3c1d1078be06293afca089d7fc05)
* Ensure trailing newline is written to cron fileEvan Kaufman2016-11-011-3/+12
| | | | | | | | Records whether existing cron file (or CRONCMD output) has a terminating newline, and ensures a trailing newline is written as necessary EVEN IF NO CHANGE WAS MADE to the target env/job Fixes #2316 (cherry picked from commit 10b0580ff48b7d7937836425a3f2c37322ad34a8)
* Fix incorrect line wrapping in output from yum check-updatesFilip Hubík2016-11-011-0/+2
| | | | | https://github.com/ansible/ansible-modules-core/issues/4318#issuecomment-251416661 (cherry picked from commit 2d459b797f954ea9239e49bb0360f29be91eb3d3)