summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Davis <nitzmahone@users.noreply.github.com>2016-04-05 10:00:40 -0700
committerMatt Davis <nitzmahone@users.noreply.github.com>2016-04-05 10:00:40 -0700
commit6a3670b1f07e16ec71b00f20ab2a9e60eecb5e34 (patch)
tree93d7259a219c8e8d7e559c4c9b154a48daa5935f
parent0f2b1244d26d35cd25ef43ebaa451e5a7c3313d5 (diff)
parent4985411816b21d53b5b0c4246ac54a1bddf7e8ea (diff)
downloadansible-6a3670b1f07e16ec71b00f20ab2a9e60eecb5e34.tar.gz
Merge pull request #15281 from jpic/fix_plugin_configuration
Regression fix: proper plugin configuration was reset
-rw-r--r--lib/ansible/plugins/__init__.py2
-rw-r--r--test/units/plugins/test_plugins.py13
2 files changed, 14 insertions, 1 deletions
diff --git a/lib/ansible/plugins/__init__.py b/lib/ansible/plugins/__init__.py
index c10d19cd38..03558df986 100644
--- a/lib/ansible/plugins/__init__.py
+++ b/lib/ansible/plugins/__init__.py
@@ -66,7 +66,7 @@ class PluginLoader:
if config and not isinstance(config, list):
config = [config]
- else:
+ elif not config:
config = []
self.config = config
diff --git a/test/units/plugins/test_plugins.py b/test/units/plugins/test_plugins.py
index 76a2600f53..e8b48afcf1 100644
--- a/test/units/plugins/test_plugins.py
+++ b/test/units/plugins/test_plugins.py
@@ -75,3 +75,16 @@ class TestErrors(unittest.TestCase):
#with patch('glob.glob', mock_glob):
# pass
+ def assertPluginLoaderConfigBecomes(self, arg, expected):
+ pl = PluginLoader('test', '', arg, 'test_plugin')
+ self.assertEqual(pl.config, expected)
+
+ def test_plugin__init_config_list(self):
+ config = ['/one', '/two']
+ self.assertPluginLoaderConfigBecomes(config, config)
+
+ def test_plugin__init_config_str(self):
+ self.assertPluginLoaderConfigBecomes('test', ['test'])
+
+ def test_plugin__init_config_none(self):
+ self.assertPluginLoaderConfigBecomes(None, [])