summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Cammarata <jimi@sngx.net>2014-08-12 16:55:14 -0500
committerJames Cammarata <jimi@sngx.net>2014-08-14 15:41:57 -0500
commit48b4805d771fdb7eccbadbc4a1468894f1968be8 (patch)
treec03d0448e9137cd8f481faef47bde5c2d37f825a
parent7589105c235c642a592df71d1233bddb1ac3659c (diff)
downloadansible-48b4805d771fdb7eccbadbc4a1468894f1968be8.tar.gz
Disallow args: to be specified as a string
-rw-r--r--lib/ansible/runner/__init__.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/ansible/runner/__init__.py b/lib/ansible/runner/__init__.py
index 2546cb376b..5ff976f07a 100644
--- a/lib/ansible/runner/__init__.py
+++ b/lib/ansible/runner/__init__.py
@@ -215,6 +215,10 @@ class Runner(object):
# changed later via options like accelerate
self.original_transport = self.transport
+ # enforce complex_args as a dict
+ if type(self.complex_args) != dict:
+ raise errors.AnsibleError("args must be a dictionary, received %s (%s)" % (self.complex_args, type(self.complex_args)))
+
# misc housekeeping
if subset and self.inventory._subset is None:
# don't override subset when passed from playbook
@@ -659,11 +663,6 @@ class Runner(object):
# logic to decide how to run things depends on whether with_items is used
if items is None:
- if isinstance(complex_args, basestring):
- complex_args = template.template(self.basedir, complex_args, inject, convert_bare=True)
- complex_args = utils.safe_eval(complex_args)
- if type(complex_args) != dict:
- raise errors.AnsibleError("args must be a dictionary, received %s" % complex_args)
return self._executor_internal_inner(host, self.module_name, self.module_args, inject, port, complex_args=complex_args)
elif len(items) > 0: