diff options
author | Matt Martz <matt@sivel.net> | 2023-03-22 11:04:56 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-22 11:04:56 -0500 |
commit | 2ae013667ef226635fe521be886efd1bf58cd46f (patch) | |
tree | 480d9448c18a1fd559657c0c14dd508eb3f2e31e /changelogs/fragments | |
parent | cba395243454b0a959edea20425618fe7b9be775 (diff) | |
download | ansible-2ae013667ef226635fe521be886efd1bf58cd46f.tar.gz |
ansible-galaxy collection install retry improvements (#80180)
* clog frag
* Fix retries so that each explicit call to _call_galaxy is retried for the correct number of attempts. Fixes #80174
* Extend retry logic to common URL related connection errors. Fixes #80170
* Extend retries to downloading artifacts
* Extend param docs for change
* Rework the exception handling
* Don't be overly broad, reduce to TimeoutError, and BadStatusLine for now
* _download_file needs to raise AnsibleError.orig_exc
* Remove unused import
* Add IncompleteRead
* Add socket.timeout for py39
* Add 502 to retry codes
* Move http error code checking first
* Use itertools.tee to replay the backoff_iterator instead of using a callable
* Actually set a CLI default of 60s for timeout, to prevent implicit galaxy from using 10s as default from Request.open
* Import typing
* fix type hints
* Use http.HTTPStatus instead of int HTTP error codes where feasible
* Split exception handling
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
* Add missing import
---------
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Diffstat (limited to 'changelogs/fragments')
-rw-r--r-- | changelogs/fragments/galaxy-improve-retries.yml | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/changelogs/fragments/galaxy-improve-retries.yml b/changelogs/fragments/galaxy-improve-retries.yml new file mode 100644 index 0000000000..ab0c7b216c --- /dev/null +++ b/changelogs/fragments/galaxy-improve-retries.yml @@ -0,0 +1,3 @@ +bugfixes: +- ansible-galaxy - Improve retries for collection installs, to properly retry, and extend retry logic to common URL related connection errors + (https://github.com/ansible/ansible/issues/80170 https://github.com/ansible/ansible/issues/80174) |