diff options
author | Sloane Hertel <shertel@redhat.com> | 2017-12-08 10:13:22 -0500 |
---|---|---|
committer | Toshio Kuratomi <a.badger@gmail.com> | 2018-01-24 08:51:05 -0800 |
commit | deaa9a21f9b5cdc65791cf4c8ef46c2353ae108d (patch) | |
tree | 8e5fb44a05bd4b4f6fa34b89d8fcd897322166a9 /lib/ansible/plugins/action/__init__.py | |
parent | 6233daaa446993e4820f0eaa83ffdeb673dbcced (diff) | |
download | ansible-deaa9a21f9b5cdc65791cf4c8ef46c2353ae108d.tar.gz |
Fix using loops with environment and add tests (#32796)
(cherry picked from commit 7bb35e8781b46cb6024a6e45e76cb663185fe10d)
Diffstat (limited to 'lib/ansible/plugins/action/__init__.py')
-rw-r--r-- | lib/ansible/plugins/action/__init__.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/ansible/plugins/action/__init__.py b/lib/ansible/plugins/action/__init__.py index 45a256b24f..a2717e2fef 100644 --- a/lib/ansible/plugins/action/__init__.py +++ b/lib/ansible/plugins/action/__init__.py @@ -176,10 +176,9 @@ class ActionBase(with_metaclass(ABCMeta, object)): if not isinstance(environments, list): environments = [ environments ] - # the environments as inherited need to be reversed, to make - # sure we merge in the parent's values first so those in the - # block then task 'win' in precedence - environments.reverse() + # The order of environments matters to make sure we merge + # in the parent's values first so those in the block then + # task 'win' in precedence for environment in environments: if environment is None or len(environment) == 0: continue |