summaryrefslogtreecommitdiff
path: root/test/units/utils/collection_loader/test_collection_loader.py
diff options
context:
space:
mode:
authorSviatoslav Sydorenko <webknjaz@redhat.com>2021-02-12 03:23:57 +0100
committerGitHub <noreply@github.com>2021-02-11 18:23:57 -0800
commitf327e65d11bb905ed9f15996024f857a95592629 (patch)
treebf31b3ea4fc5475c3f4e6ccefe2c0e7573ef117b /test/units/utils/collection_loader/test_collection_loader.py
parentf533d46572113655a0a698beab4b38671744a458 (diff)
downloadansible-f327e65d11bb905ed9f15996024f857a95592629.tar.gz
Use iskeyword and str.isidentifier for "is FQCN" (#73279)
* Use valid FQCN in test_verbosity_arguments * Use iskeyword and str.isidentifier for "is FQCN"
Diffstat (limited to 'test/units/utils/collection_loader/test_collection_loader.py')
-rw-r--r--test/units/utils/collection_loader/test_collection_loader.py19
1 files changed, 19 insertions, 0 deletions
diff --git a/test/units/utils/collection_loader/test_collection_loader.py b/test/units/utils/collection_loader/test_collection_loader.py
index a2bee819a1..c8187676e6 100644
--- a/test/units/utils/collection_loader/test_collection_loader.py
+++ b/test/units/utils/collection_loader/test_collection_loader.py
@@ -719,6 +719,25 @@ def test_fqcr_parsing_valid(ref, ref_type, expected_collection,
@pytest.mark.parametrize(
+ ('fqcn', 'expected'),
+ (
+ ('ns1.coll2', True),
+ ('def.coll3', False),
+ ('ns4.return', False),
+ ('assert.this', False),
+ ('import.that', False),
+ ('.that', False),
+ ('this.', False),
+ ('.', False),
+ ('', False),
+ ),
+)
+def test_fqcn_validation(fqcn, expected):
+ """Vefiry that is_valid_collection_name validates FQCN correctly."""
+ assert AnsibleCollectionRef.is_valid_collection_name(fqcn) is expected
+
+
+@pytest.mark.parametrize(
'ref,ref_type,expected_error_type,expected_error_expression',
[
('no_dots_at_all_action', 'action', ValueError, 'is not a valid collection reference'),